eal/windows: revert definition of ETOOMANYREFS
PATCH 1/1 eal/windows: revert definition of ETOOMANYREFS
This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.
The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.
--- lib/librte_eal/windows/include/rte_os.h | 2 -- 1 file changed, 2 deletions(-)
lib/librte_eal/windows/include/rte_os.h +0 -2
@@ -51,8 +51,6 @@ extern "C" {/* as in <windows.h> */ typedef long long ssize_t ; -#define ETOOMANYREFS 10059/* WSAETOOMANYREFS */ -#ifndef RTE_TOOLCHAIN_GCC static inline int
Signature · 1 line
2.16.1.windows.4
Quoted 26 lines · Tal Shnaiderman
This reverts commit
c917b54b0c743c7a570a4d8df8954c61d8b818c4.The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")Signed-off-by Tal Shnaiderman <[email protected]>--- lib/librte_eal/windows/include/rte_os.h | 2 -- 1 file changed, 2 deletions(-)lib/librte_eal/windows/include/rte_os.h +0
-2@@ -51,8 +51,6 @@ extern "C" {/* as in <windows.h> */ typedef long long ssize_t ; -#define ETOOMANYREFS 10059/* WSAETOOMANYREFS */ -#ifndef RTE_TOOLCHAIN_GCC static inline int
Quoted 7 lines · Tal Shnaiderman
This reverts commit
c917b54b0c743c7a570a4d8df8954c61d8b818c4.The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
No need to copy stable, the reverted commit is only in the current release.
Quoted 1 line
Signed-off-by Tal Shnaiderman <[email protected]>
Applied, thanks.
Signature · 1 line
David Marchand
Quoted 8 lines · David Marchand
Quoted 6 lines · Tal Shnaiderman
This reverts commit
c917b54b0c743c7a570a4d8df8954c61d8b818c4.The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.
Quoted 8 lines
Quoted 1 line
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")No need to copy stable, the reverted commit is only in the current release.
Quoted 1 line
Signed-off-by Tal Shnaiderman <[email protected]>Reviewed-by Nick Connolly <[email protected]>Applied, thanks.
Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion. Can I get some acks please ?
Signature · 1 line
David Marchand
Quoted 10 lines · Tal Shnaiderman
This reverts commit
c917b54b0c743c7a570a4d8df8954c61d8b818c4.The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")Signed-off-by Tal Shnaiderman <[email protected]>---
On Fri, Nov 20, 2020 at 10:12 AM David Marchand
Quoted 5 lines
<[email protected]> wrote:
Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion. Can I get some acks please ?
Discussion thread, for the reference:
https://mails.dpdk.org/archives/dev/2020-November/192842.html
Quoted 7 lines · Dmitry Kozlyuk
Quoted 5 lines · Tal Shnaiderman
This reverts commit
c917b54b0c743c7a570a4d8df8954c61d8b818c4.The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.
Quoted 7 lines
Quoted 5 lines
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")Signed-off-by Tal Shnaiderman <[email protected]>---
Acked-by Dmitry Kozlyuk <[email protected]>
Thank you Dmitry.
Applied for real this time.
Quoted 9 lines
On Fri, Nov 20, 2020 at 10:12 AM David Marchand
Quoted 5 lines
<[email protected]> wrote:
Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion. Can I get some acks please ?Discussion thread, for the reference:
https://mails.dpdk.org/archives/dev/2020-November/192842.html
And a patch was just merged in next-net for rte_flow.h + mlx5 driver.
http://patchwork.dpdk.org/patch/84411/
Signature · 1 line
David Marchand