Skip to contentSkip to conversation

eal/windows: revert definition of ETOOMANYREFS

PATCH Applied Tal Shnaiderman 4 participants 6 messages Nov 19, 2020 – Nov 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eal/windows: revert definition of ETOOMANYREFS

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.

Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
---
 lib/librte_eal/windows/include/rte_os.h | 2 --
 1 file changed, 2 deletions(-)
lib/librte_eal/windows/include/rte_os.h +0 -2
index 8300ea483a..569ed92d51 100644
@@ -51,8 +51,6 @@ extern "C" {
 /* as in <windows.h> */
 typedef long long ssize_t;
 
-#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
-
 #ifndef RTE_TOOLCHAIN_GCC
 
 static inline int
Signature · 1 line
2.16.1.windows.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 26 lines · Tal Shnaiderman

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.

Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")
---
  lib/librte_eal/windows/include/rte_os.h | 2 --
  1 file changed, 2 deletions(-)
lib/librte_eal/windows/include/rte_os.h +0 -2
index 8300ea483a..569ed92d51 100644
@@ -51,8 +51,6 @@ extern "C" {
  /* as in <windows.h> */
  typedef long long ssize_t;
 
-#define ETOOMANYREFS 10059 /* WSAETOOMANYREFS */
-
  #ifndef RTE_TOOLCHAIN_GCC
 
  static inline int
Reviewed-by Nick Connolly on v1 1/1 Applied
#2 lore raw
In reply to Tal Shnaiderman
Quoted 7 lines · Tal Shnaiderman

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.

Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")

No need to copy stable, the reverted commit is only in the current release.

Quoted 1 line

Applied, thanks.

Signature · 1 line
David Marchand
#3 lore raw
Quoted 8 lines · David Marchand
Quoted 6 lines · Tal Shnaiderman

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.

Quoted 8 lines
Quoted 1 line
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")

No need to copy stable, the reverted commit is only in the current release.

Quoted 1 line

Applied, thanks.

Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion. Can I get some acks please ?

Signature · 1 line
David Marchand
Acked-by on v1 1/1
#4 lore raw
In reply to Tal Shnaiderman
Quoted 10 lines · Tal Shnaiderman

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.

Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")

---

On Fri, Nov 20, 2020 at 10:12 AM David Marchand

Quoted 5 lines

<[email protected]> wrote:

Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion. Can I get some acks please ?

Discussion thread, for the reference:
https://mails.dpdk.org/archives/dev/2020-November/192842.html

#5 lore raw
Quoted 7 lines · Dmitry Kozlyuk
Quoted 5 lines · Tal Shnaiderman

This reverts commit c917b54b0c743c7a570a4d8df8954c61d8b818c4.

The definition of ETOOMANYREFS is reverted as it breaks build of external applications already defining it.

Quoted 7 lines
Quoted 5 lines
Fixes c917b54b0c ("eal/windows: add definition of ETOOMANYREFS")

---

Thank you Dmitry.
Applied for real this time.

Quoted 9 lines

On Fri, Nov 20, 2020 at 10:12 AM David Marchand

Quoted 5 lines

<[email protected]> wrote:

Hum, pulling back on this.
I did not see any Windows maintainer opine in the discussion. Can I get some acks please ?

Discussion thread, for the reference:
https://mails.dpdk.org/archives/dev/2020-November/192842.html

And a patch was just merged in next-net for rte_flow.h + mlx5 driver.
http://patchwork.dpdk.org/patch/84411/

Signature · 1 line
David Marchand