mmc: tmio: do not print real IOMEM pointer
Subsystems (2)
PATCH 1/1 mmc: tmio: do not print real IOMEM pointer
Printing kernel pointers is discouraged because they might leak kernel memory layout. This fixes smatch warning:
drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Krzysztof Kozlowski <[email protected]>
--- drivers/mmc/host/tmio_mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/host/tmio_mmc.c +1 -2
@@ -174,8 +174,7 @@ static int tmio_mmc_probe(struct platform_device *pdev)if (ret) goto host_remove; -pr_info ("%s at 0x%08lx irq %d\n" ,mmc_hostname (host->mmc), - (unsigned long )host->ctl, irq); +pr_info ("%s at 0x%p irq %d\n" ,mmc_hostname (host->mmc), host->ctl, irq);return 0 ;
Signature · 1 line
2.25.1
Quoted 8 lines · Krzysztof Kozlowski
Printing kernel pointers is discouraged because they might leak kernel memory layout. This fixes smatch warning:
drivers/mmc/host/tmio_mmc.c:177tmio_mmc_probe()warn: argument 3 to %08lx specifier is cast from pointerReported-by kernel test robot <[email protected]>Reported-by Dan Carpenter <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Reviewed-by Wolfram Sang <[email protected]>