Convert the intel iommu driver to the dma-iommu api
Subsystems (4)
Lu Baolu
maintainerv5 cover Convert the intel iommu driver to the dma-iommu api
Hi Will,
The previous post of this series could be found here.
https://lore.kernel.org/linux-iommu/[email protected]/
Changes in this version:
- Add Tested-by: Logan Gunthorpe <[email protected]>
- Rebase to v5.10-rc3
Please review and consider it for iommu/next.
Best regards,
baolu
Lu Baolu (3):
iommu: Add quirk for Intel graphic devices in map_sg iommu/vt-d: Update domain geometry in iommu_ops.at(de)tach_dev iommu/vt-d: Cleanup after converting to dma-iommu ops
Tom Murphy (4):
iommu: Handle freelists when using deferred flushing in iommu drivers
iommu: Add iommu_dma_free_cpu_cached_iovas()
iommu: Allow the dma-iommu api to use bounce buffers iommu/vt-d: Convert intel iommu driver to the iommu ops
.../admin-guide/kernel-parameters.txt | 5 - drivers/iommu/dma-iommu.c | 228 ++++- drivers/iommu/intel/Kconfig | 1 + drivers/iommu/intel/iommu.c | 905 +++--------------- include/linux/dma-iommu.h | 8 + include/linux/iommu.h | 1 + 6 files changed, 336 insertions(+), 812 deletions(-)
Signature · 1 line
2.25.1
Lu Baolu
maintainerPATCH v5 1/7 iommu: Handle freelists when using deferred flushing in iommu drivers
From: Tom Murphy <[email protected]>
Allow the iommu_unmap_fast to return newly freed page table pages and pass the freelist to queue_iova in the dma-iommu ops path.
This is useful for iommu drivers (in this case the intel iommu driver) which need to wait for the ioTLB to be flushed before newly free/unmapped page table pages can be freed. This way we can still batch ioTLB free operations and handle the freelists.
--- drivers/iommu/dma-iommu.c | 29 +++++++++++++------ drivers/iommu/intel/iommu.c | 55 ++++++++++++++++++++++++------------- include/linux/iommu.h | 1 + 3 files changed, 58 insertions(+), 27 deletions(-)
drivers/iommu/dma-iommu.c +21 -8
@@ -49,6 +49,18 @@ struct iommu_dma_cookie {struct iommu_domain *fq_domain; }; +static void iommu_dma_entry_dtor (unsigned long data) +{ +struct page *freelist = (struct page *)data; + +while (freelist) { +unsigned long p = (unsigned long )page_address (freelist); + + freelist = freelist->freelist; +free_page (p); + } +} +static inline size_t cookie_msi_granule (struct iommu_dma_cookie *cookie) {if (cookie->type ==IOMMU_DMA_IOVA_COOKIE )
@@ -343,7 +355,7 @@ static int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,if (!cookie->fq_domain && !iommu_domain_get_attr (domain,DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE , &attr) && attr) {if (init_iova_flush_queue (iovad, iommu_dma_flush_iotlb_all, -NULL )) + iommu_dma_entry_dtor))pr_warn ("iova flush queue initialization failed\n" );else cookie->fq_domain = domain;
@@ -440,7 +452,7 @@ static dma_addr_t iommu_dma_alloc_iova(struct iommu_domain *domain, }static void iommu_dma_free_iova (struct iommu_dma_cookie *cookie, -dma_addr_t iova,size_t size) +dma_addr_t iova,size_t size,struct page *freelist) {struct iova_domain *iovad = &cookie->iovad;
@@ -449,7 +461,8 @@ static void iommu_dma_free_iova(struct iommu_dma_cookie *cookie, cookie->msi_iova -= size; else if (cookie->fq_domain) /* non-strict mode */ queue_iova(iovad, iova_pfn(iovad, iova), - size >> iova_shift(iovad), 0); + size >> iova_shift(iovad), + (unsigned long)freelist); elsefree_iova_fast (iovad ,iova_pfn (iovad ,iova ), size >> iova_shift(iovad));
@@ -474,7 +487,7 @@ static void __iommu_dma_unmap(struct device *dev, dma_addr_t dma_addr,if (!cookie->fq_domain)iommu_iotlb_sync (domain, &iotlb_gather); -iommu_dma_free_iova (cookie, dma_addr, size); +iommu_dma_free_iova (cookie, dma_addr, size, iotlb_gather.freelist); } static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys,
@@ -496,7 +509,7 @@ static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys,return DMA_MAPPING_ERROR ;if (iommu_map_atomic (domain, iova, phys - iova_off, size, prot)) { -iommu_dma_free_iova (cookie, iova, size); +iommu_dma_free_iova (cookie, iova, size,NULL );return DMA_MAPPING_ERROR ; }return iova + iova_off;
@@ -649,7 +662,7 @@ static void *iommu_dma_alloc_remap(struct device *dev, size_t size, out_free_sg:sg_free_table (&sgt); out_free_iova: -iommu_dma_free_iova (cookie, iova, size); +iommu_dma_free_iova (cookie, iova, size,NULL ); out_free_pages:__iommu_dma_free_pages (pages, count);return NULL ;
@@ -900,7 +913,7 @@ static int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg,return __finalise_sg (dev, sg, nents, iova); out_free_iova: -iommu_dma_free_iova (cookie, iova, iova_len); +iommu_dma_free_iova (cookie, iova, iova_len,NULL ); out_restore_sg:__invalidate_sg (sg, nents);return 0 ;
@@ -1228,7 +1241,7 @@ static struct iommu_dma_msi_page *iommu_dma_get_msi_page(struct device *dev,return msi_page; out_free_iova: -iommu_dma_free_iova (cookie, iova, size); +iommu_dma_free_iova (cookie, iova, size,NULL ); out_free_page:kfree (msi_page);return NULL ;
drivers/iommu/intel/iommu.c +36 -19
112 lines not on this page · raw message
include/linux/iommu.h +1 -0
@@ -180,6 +180,7 @@ struct iommu_iotlb_gather {unsigned long start;unsigned long end;size_t pgsize; +struct page *freelist; };/**
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Lu Baolu
maintainerPATCH v5 2/7 iommu: Add iommu_dma_free_cpu_cached_iovas()
In reply to Lu BaoluFrom: Tom Murphy <[email protected]>
Add a iommu_dma_free_cpu_cached_iovas function to allow drivers which use the dma-iommu ops to free cached cpu iovas.
--- drivers/iommu/dma-iommu.c | 9 +++++++++ include/linux/dma-iommu.h | 8 ++++++++ 2 files changed, 17 insertions(+)
drivers/iommu/dma-iommu.c +9 -0
@@ -49,6 +49,15 @@ struct iommu_dma_cookie {struct iommu_domain *fq_domain; }; +void iommu_dma_free_cpu_cached_iovas (unsigned int cpu, +struct iommu_domain *domain) +{ +struct iommu_dma_cookie *cookie = domain->iova_cookie; +struct iova_domain *iovad = &cookie->iovad; + +free_cpu_cached_iovas (cpu, iovad); +} +static void iommu_dma_entry_dtor (unsigned long data) {struct page *freelist = (struct page *)data;
include/linux/dma-iommu.h +8 -0
@@ -37,6 +37,9 @@ void iommu_dma_compose_msi_msg(struct msi_desc *desc,void iommu_dma_get_resv_regions (struct device *dev,struct list_head *list); +void iommu_dma_free_cpu_cached_iovas (unsigned int cpu, +struct iommu_domain *domain); +#else /* CONFIG_IOMMU_DMA */ struct iommu_domain ;
@@ -78,5 +81,10 @@ static inline void iommu_dma_get_resv_regions(struct device *dev, struct list_he { } +static inline void iommu_dma_free_cpu_cached_iovas (unsigned int cpu, +struct iommu_domain *domain) +{ +} +#endif /* CONFIG_IOMMU_DMA */ #endif /* __DMA_IOMMU_H */
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Lu Baolu
maintainerPATCH v5 3/7 iommu: Allow the dma-iommu api to use bounce buffers
In reply to Lu BaoluFrom: Tom Murphy <[email protected]>
Allow the dma-iommu api to use bounce buffers for untrusted devices. This is a copy of the intel bounce buffer code.
--- drivers/iommu/dma-iommu.c | 163 +++++++++++++++++++++++++++++++++++--- 1 file changed, 150 insertions(+), 13 deletions(-)
drivers/iommu/dma-iommu.c +150 -13
@@ -20,9 +20,11 @@#include <linux/mm.h> #include <linux/mutex.h> #include <linux/pci.h> +#include <linux/swiotlb.h> #include <linux/scatterlist.h> #include <linux/vmalloc.h> #include <linux/crash_dump.h> +#include <linux/dma-direct.h> struct iommu_dma_msi_page {struct list_head list;
@@ -499,6 +501,31 @@ static void __iommu_dma_unmap(struct device *dev, dma_addr_t dma_addr,iommu_dma_free_iova (cookie, dma_addr, size, iotlb_gather.freelist); } +static void __iommu_dma_unmap_swiotlb (struct device *dev,dma_addr_t dma_addr, +size_t size,enum dma_data_direction dir, +unsigned long attrs) +{ +struct iommu_domain *domain =iommu_get_dma_domain (dev); +struct iommu_dma_cookie *cookie = domain->iova_cookie; +struct iova_domain *iovad = &cookie->iovad; +phys_addr_t phys; + + phys =iommu_iova_to_phys (domain, dma_addr); +if (WARN_ON (!phys)) +return ; + +__iommu_dma_unmap (dev, dma_addr, size); + +if (unlikely (is_swiotlb_buffer (phys))) +swiotlb_tbl_unmap_single (dev, phys, size, +iova_align (iovad, size), dir, attrs); +} + +static bool dev_is_untrusted (struct device *dev) +{ +return dev_is_pci (dev) &&to_pci_dev (dev)->untrusted; +} +static dma_addr_t __iommu_dma_map (struct device *dev,phys_addr_t phys,size_t size,int prot,u64 dma_mask) {
@@ -524,6 +551,55 @@ static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys,return iova + iova_off; } +static dma_addr_t __iommu_dma_map_swiotlb (struct device *dev,phys_addr_t phys, +size_t org_size,dma_addr_t dma_mask,bool coherent, +enum dma_data_direction dir,unsigned long attrs) +{ +int prot =dma_info_to_prot (dir, coherent, attrs); +struct iommu_domain *domain =iommu_get_dma_domain (dev); +struct iommu_dma_cookie *cookie = domain->iova_cookie; +struct iova_domain *iovad = &cookie->iovad; +size_t aligned_size = org_size; +void *padding_start; +size_t padding_size; +dma_addr_t iova; + +/* +* If both the physical buffer start address and size are +* page aligned, we don't need to use a bounce page. +*/ +if (IS_ENABLED (CONFIG_SWIOTLB ) &&dev_is_untrusted (dev) && +iova_offset (iovad, phys | org_size)) { + aligned_size =iova_align (iovad, org_size); + phys =swiotlb_tbl_map_single (dev, +phys_to_dma (dev, io_tlb_start), + phys, org_size, aligned_size, dir, attrs); + +if (phys ==DMA_MAPPING_ERROR ) +return DMA_MAPPING_ERROR ; + +/* Cleanup the padding area. */ + padding_start =phys_to_virt (phys); + padding_size = aligned_size; + +if (!(attrs &DMA_ATTR_SKIP_CPU_SYNC ) && + (dir ==DMA_TO_DEVICE || + dir ==DMA_BIDIRECTIONAL )) { + padding_start += org_size; + padding_size -= org_size; + } + +memset (padding_start,0 , padding_size); + } + + iova =__iommu_dma_map (dev, phys, aligned_size, prot, dma_mask); +if ((iova ==DMA_MAPPING_ERROR ) &&is_swiotlb_buffer (phys)) +swiotlb_tbl_unmap_single (dev, phys, org_size, + aligned_size, dir, attrs); + +return iova; +} +static void __iommu_dma_free_pages (struct page **pages,int count) {while (count--)
@@ -697,11 +773,15 @@ static void iommu_dma_sync_single_for_cpu(struct device *dev, {phys_addr_t phys; -if (dev_is_dma_coherent (dev)) +if (dev_is_dma_coherent (dev) && !dev_is_untrusted (dev))return ; phys =iommu_iova_to_phys (iommu_get_dma_domain (dev), dma_handle); -arch_sync_dma_for_cpu (phys, size, dir); +if (!dev_is_dma_coherent (dev)) +arch_sync_dma_for_cpu (phys, size, dir); + +if (is_swiotlb_buffer (phys)) +swiotlb_tbl_sync_single (dev, phys, size, dir,SYNC_FOR_CPU ); } static void iommu_dma_sync_single_for_device(struct device *dev,
@@ -709,11 +789,15 @@ static void iommu_dma_sync_single_for_device(struct device *dev, {phys_addr_t phys; -if (dev_is_dma_coherent (dev)) +if (dev_is_dma_coherent (dev) && !dev_is_untrusted (dev))return ; phys =iommu_iova_to_phys (iommu_get_dma_domain (dev), dma_handle); -arch_sync_dma_for_device (phys, size, dir); +if (is_swiotlb_buffer (phys)) +swiotlb_tbl_sync_single (dev, phys, size, dir,SYNC_FOR_DEVICE ); + +if (!dev_is_dma_coherent (dev)) +arch_sync_dma_for_device (phys, size, dir); } static void iommu_dma_sync_sg_for_cpu(struct device *dev,
@@ -723,11 +807,17 @@ static void iommu_dma_sync_sg_for_cpu(struct device *dev,struct scatterlist *sg;int i; -if (dev_is_dma_coherent (dev)) +if (dev_is_dma_coherent (dev) && !dev_is_untrusted (dev))return ; -for_each_sg (sgl, sg, nelems, i) -arch_sync_dma_for_cpu (sg_phys (sg), sg->length, dir); +for_each_sg (sgl, sg, nelems, i) { +if (!dev_is_dma_coherent (dev)) +arch_sync_dma_for_cpu (sg_phys (sg), sg->length, dir); + +if (is_swiotlb_buffer (sg_phys (sg))) +swiotlb_tbl_sync_single (dev,sg_phys (sg), sg->length, + dir,SYNC_FOR_CPU ); + } } static void iommu_dma_sync_sg_for_device(struct device *dev,
@@ -737,11 +827,17 @@ static void iommu_dma_sync_sg_for_device(struct device *dev,struct scatterlist *sg;int i; -if (dev_is_dma_coherent (dev)) +if (dev_is_dma_coherent (dev) && !dev_is_untrusted (dev))return ; -for_each_sg (sgl, sg, nelems, i) -arch_sync_dma_for_device (sg_phys (sg), sg->length, dir); +for_each_sg (sgl, sg, nelems, i) { +if (is_swiotlb_buffer (sg_phys (sg))) +swiotlb_tbl_sync_single (dev,sg_phys (sg), sg->length, + dir,SYNC_FOR_DEVICE ); + +if (!dev_is_dma_coherent (dev)) +arch_sync_dma_for_device (sg_phys (sg), sg->length, dir); + } } static dma_addr_t iommu_dma_map_page(struct device *dev, struct page *page,
@@ -750,10 +846,10 @@ static dma_addr_t iommu_dma_map_page(struct device *dev, struct page *page, {phys_addr_t phys =page_to_phys (page) + offset;bool coherent =dev_is_dma_coherent (dev); -int prot =dma_info_to_prot (dir, coherent, attrs);dma_addr_t dma_handle; - dma_handle =__iommu_dma_map (dev, phys, size, prot,dma_get_mask (dev)); + dma_handle =__iommu_dma_map_swiotlb (dev, phys, size,dma_get_mask (dev), + coherent, dir, attrs);if (!coherent && !(attrs &DMA_ATTR_SKIP_CPU_SYNC ) && dma_handle !=DMA_MAPPING_ERROR )arch_sync_dma_for_device (phys, size, dir);
@@ -765,7 +861,7 @@ static void iommu_dma_unmap_page(struct device *dev, dma_addr_t dma_handle, {if (!(attrs &DMA_ATTR_SKIP_CPU_SYNC ))iommu_dma_sync_single_for_cpu (dev, dma_handle, size, dir); -__iommu_dma_unmap (dev, dma_handle, size); +__iommu_dma_unmap_swiotlb (dev, dma_handle, size, dir, attrs); }/*
@@ -843,6 +939,39 @@ static void __invalidate_sg(struct scatterlist *sg, int nents) } } +static void iommu_dma_unmap_sg_swiotlb (struct device *dev,struct scatterlist *sg, +int nents,enum dma_data_direction dir,unsigned long attrs) +{ +struct scatterlist *s; +int i; + +for_each_sg (sg, s, nents, i) +__iommu_dma_unmap_swiotlb (dev,sg_dma_address (s), +sg_dma_len (s), dir, attrs); +} + +static int iommu_dma_map_sg_swiotlb (struct device *dev,struct scatterlist *sg, +int nents,enum dma_data_direction dir,unsigned long attrs) +{ +struct scatterlist *s; +int i; + +for_each_sg (sg, s, nents, i) { +sg_dma_address (s) =__iommu_dma_map_swiotlb (dev,sg_phys (s), + s->length,dma_get_mask (dev), +dev_is_dma_coherent (dev), dir, attrs); +if (sg_dma_address (s) ==DMA_MAPPING_ERROR ) + goto out_unmap; +sg_dma_len (s) = s->length; + } + +return nents; + +out_unmap: +iommu_dma_unmap_sg_swiotlb (dev, sg, i, dir, attrs |DMA_ATTR_SKIP_CPU_SYNC ); +return 0 ; +} +/* * The DMA API client is passing in a scatterlist which could describe * any old buffer layout, but the IOMMU API requires everything to be
@@ -869,6 +998,9 @@ static int iommu_dma_map_sg(struct device *dev, struct scatterlist *sg,if (!(attrs &DMA_ATTR_SKIP_CPU_SYNC ))iommu_dma_sync_sg_for_device (dev, sg, nents, dir); +if (dev_is_untrusted (dev)) +return iommu_dma_map_sg_swiotlb (dev, sg, nents, dir, attrs); +/* * Work out how much IOVA space we need, and align the segments to * IOVA granules for the IOMMU driver to handle. With some clever
@@ -938,6 +1070,11 @@ static void iommu_dma_unmap_sg(struct device *dev, struct scatterlist *sg,if (!(attrs &DMA_ATTR_SKIP_CPU_SYNC ))iommu_dma_sync_sg_for_cpu (dev, sg, nents, dir); +if (dev_is_untrusted (dev)) { +iommu_dma_unmap_sg_swiotlb (dev, sg, nents, dir, attrs); +return ; + } +/* * The scatterlist segments are mapped into a single * contiguous IOVA allocation, so this is incredibly easy.
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v5 3/7] iommu: Allow the dma-iommu api to use bounce buffers
drivers/iommu/dma-iommu.c static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys, · line 576
Quoted 10 lines
drivers/iommu/dma-iommu.c +10
-0+/* +* If both the physical buffer start address and size are +* page aligned, we don't need to use a bounce page. +*/ +if (IS_ENABLED (CONFIG_SWIOTLB ) &&dev_is_untrusted (dev) && +iova_offset (iovad, phys | org_size)) { + aligned_size =iova_align (iovad, org_size); + phys =swiotlb_tbl_map_single (dev, +phys_to_dma (dev, io_tlb_start), + phys, org_size, aligned_size, dir, attrs);
swiotlb_tbl_map_single takes one less argument in 5.10-rc now.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Lu Baolu
maintainerRe: [PATCH v5 3/7] iommu: Allow the dma-iommu api to use bounce buffers
Hi Christoph,
Quoted 4 lines · Christoph Hellwig
Quoted 4 lines
drivers/iommu/dma-iommu.c +4
-0+/* +* If both the physical buffer start address and size are +* page aligned, we don't need to use a bounce page. +*/
Quoted 9 lines
drivers/iommu/dma-iommu.c static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys, · line 576
Quoted 6 lines
drivers/iommu/dma-iommu.c +6
-0+if (IS_ENABLED (CONFIG_SWIOTLB ) &&dev_is_untrusted (dev) && +iova_offset (iovad, phys | org_size)) { + aligned_size =iova_align (iovad, org_size); + phys =swiotlb_tbl_map_single (dev, +phys_to_dma (dev, io_tlb_start), + phys, org_size, aligned_size, dir, attrs);
swiotlb_tbl_map_singletakes one less argument in 5.10-rc now.
Yes. But Will's iommu/next branch is based on 5.10-rc3. I synced with him, we agreed to keep it 5.10-rc3 and resolve this conflict when merging it.
Best regards,
baolu
Will Deacon
maintainerRe: [PATCH v5 3/7] iommu: Allow the dma-iommu api to use bounce buffers
Quoted 15 lines · Lu Baolu
Quoted 4 lines · Christoph Hellwig
Quoted 4 lines
drivers/iommu/dma-iommu.c +4
-0+/* +* If both the physical buffer start address and size are +* page aligned, we don't need to use a bounce page. +*/ Quoted 9 lines
drivers/iommu/dma-iommu.c static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys, · line 576
Quoted 6 lines
drivers/iommu/dma-iommu.c +6
-0+if (IS_ENABLED (CONFIG_SWIOTLB ) &&dev_is_untrusted (dev) && +iova_offset (iovad, phys | org_size)) { + aligned_size =iova_align (iovad, org_size); + phys =swiotlb_tbl_map_single (dev, +phys_to_dma (dev, io_tlb_start), + phys, org_size, aligned_size, dir, attrs);
swiotlb_tbl_map_singletakes one less argument in 5.10-rc now.
Quoted 3 lines
Yes. But Will's iommu/next branch is based on 5.10-rc3. I synced with him, we agreed to keep it 5.10-rc3 and resolve this conflict when merging it.
That's right, although I failed to appreciate the conflict was due to a change in function prototype rather than just a context collision. So I've updated the vt-d branch to contain the stuff fron Konrad:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/iommu/vt-d
Sorry for messing you around!
Will
Lu Baolu
maintainerRe: [PATCH v5 3/7] iommu: Allow the dma-iommu api to use bounce buffers
Hi Will,
Quoted 20 lines · Will Deacon
Quoted 15 lines · Lu Baolu
Quoted 4 lines · Christoph Hellwig
Quoted 4 lines
drivers/iommu/dma-iommu.c +4
-0+/* +* If both the physical buffer start address and size are +* page aligned, we don't need to use a bounce page. +*/ Quoted 9 lines
drivers/iommu/dma-iommu.c static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys, · line 576
Quoted 6 lines
drivers/iommu/dma-iommu.c +6
-0+if (IS_ENABLED (CONFIG_SWIOTLB ) &&dev_is_untrusted (dev) && +iova_offset (iovad, phys | org_size)) { + aligned_size =iova_align (iovad, org_size); + phys =swiotlb_tbl_map_single (dev, +phys_to_dma (dev, io_tlb_start), + phys, org_size, aligned_size, dir, attrs);
swiotlb_tbl_map_singletakes one less argument in 5.10-rc now.Quoted 3 lines
Yes. But Will's iommu/next branch is based on 5.10-rc3. I synced with him, we agreed to keep it 5.10-rc3 and resolve this conflict when merging it.
Quoted 7 lines
That's right, although I failed to appreciate the conflict was due to a change in function prototype rather than just a context collision. So I've updated the vt-d branch to contain the stuff fron Konrad:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/iommu/vt-d
Sorry for messing you around!
It's okay. I will re-base the patch series later.
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Lu Baolu
maintainerPATCH v5 4/7 iommu: Add quirk for Intel graphic devices in map_sg
In reply to Lu BaoluCombining the sg segments exposes a bug in the Intel i915 driver which causes visual artifacts and the screen to freeze. This is most likely because of how the i915 handles the returned list. It probably doesn't respect the returned value specifying the number of elements in the list and instead depends on the previous behaviour of the Intel iommu driver which would return the same number of elements in the output list as in the input list.
--- drivers/iommu/dma-iommu.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
drivers/iommu/dma-iommu.c +27 -0
@@ -879,6 +879,33 @@ static int __finalise_sg(struct device *dev, struct scatterlist *sg, int nents,unsigned int cur_len =0 , max_len =dma_get_max_seg_size (dev);int i, count =0 ; +/* +* The Intel graphic driver is used to assume that the returned +* sg list is not combound. This blocks the efforts of converting +* Intel IOMMU driver to dma-iommu api's. Add this quirk to make the +* device driver work and should be removed once it's fixed in i915 +* driver. +*/ +if (IS_ENABLED (CONFIG_DRM_I915 ) &&dev_is_pci (dev) && +to_pci_dev (dev)->vendor ==PCI_VENDOR_ID_INTEL && + (to_pci_dev (dev)->class >>16 ) ==PCI_BASE_CLASS_DISPLAY ) { +for_each_sg (sg, s, nents, i) { +unsigned int s_iova_off =sg_dma_address (s); +unsigned int s_length =sg_dma_len (s); +unsigned int s_iova_len = s->length; + + s->offset += s_iova_off; + s->length = s_length; +sg_dma_address (s) = dma_addr + s_iova_off; +sg_dma_len (s) = s_length; + dma_addr += s_iova_len; + +pr_info_once ("sg combining disabled due to i915 driver\n" ); + } + +return nents; + } +for_each_sg (sg, s, nents, i) {/* Restore this segment's original unaligned fields first */ unsigned int s_iova_off =sg_dma_address (s);
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Lu Baolu
maintainerPATCH v5 5/7 iommu/vt-d: Update domain geometry in iommu_ops.at(de)tach_dev
In reply to Lu BaoluThe iommu-dma constrains IOVA allocation based on the domain geometry that the driver reports. Update domain geometry everytime a domain is attached to or detached from a device.
--- drivers/iommu/intel/iommu.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/iommu/intel/iommu.c +14 -2
@@ -67,8 +67,8 @@#define MAX_AGAW_WIDTH 64#define MAX_AGAW_PFN_WIDTH (MAX_AGAW_WIDTH - VTD_PAGE_SHIFT) -#define __DOMAIN_MAX_PFN (gaw) ((((uint64_t)1) << (gaw-VTD_PAGE_SHIFT)) - 1) -#define __DOMAIN_MAX_ADDR (gaw) ((((uint64_t)1) << gaw) - 1) +#define __DOMAIN_MAX_PFN (gaw) ((((uint64_t)1) << ((gaw) - VTD_PAGE_SHIFT)) - 1) +#define __DOMAIN_MAX_ADDR (gaw) ((((uint64_t)1) << (gaw)) - 1)/* We limit DOMAIN_MAX_PFN to fit in an unsigned long, and DOMAIN_MAX_ADDR to match. That way, we can use 'unsigned long' for PFNs with impunity. */
@@ -739,6 +739,18 @@ static void domain_update_iommu_cap(struct dmar_domain *domain)*/ if (domain->nid ==NUMA_NO_NODE ) domain->nid =domain_update_device_node (domain); + +/* +* First-level translation restricts the input-address to a +* canonical address (i.e., address bits 63:N have the same +* value as address bit [N-1], where N is 48-bits with 4-level +* paging and 57-bits with 5-level paging). Hence, skip bit +* [N-1]. +*/ +if (domain_use_first_level (domain)) + domain->domain.geometry.aperture_end =__DOMAIN_MAX_ADDR (domain->gaw -1 ); +else + domain->domain.geometry.aperture_end =__DOMAIN_MAX_ADDR (domain->gaw); } struct context_entry *iommu_context_addr(struct intel_iommu *iommu, u8 bus,
Signature · 1 line
2.25.1
Lu Baolu
maintainerPATCH v5 6/7 iommu/vt-d: Convert intel iommu driver to the iommu ops
In reply to Lu BaoluFrom: Tom Murphy <[email protected]>
Convert the intel iommu driver to the dma-iommu api. Remove the iova handling and reserve region code from the intel iommu driver.
--- drivers/iommu/intel/Kconfig | 1 + drivers/iommu/intel/iommu.c | 746 ++---------------------------------- 2 files changed, 43 insertions(+), 704 deletions(-)
drivers/iommu/intel/Kconfig +1 -0
@@ -13,6 +13,7 @@ config INTEL_IOMMU select DMAR_TABLE select SWIOTLB select IOASID + select IOMMU_DMA help DMA remapping (DMAR) devices support enables independent address translations for Direct Memory Access (DMA) from devices.
drivers/iommu/intel/iommu.c +42 -704
878 lines not on this page · raw message
Signature · 1 line
2.25.1
Lu Baolu
maintainerPATCH v5 7/7 iommu/vt-d: Cleanup after converting to dma-iommu ops
In reply to Lu BaoluSome cleanups after converting the driver to use dma-iommu ops.
- Remove nobounce option;
- Cleanup and simplify the path in domain mapping.
--- .../admin-guide/kernel-parameters.txt | 5 -- drivers/iommu/intel/iommu.c | 90 ++++++------------- 2 files changed, 28 insertions(+), 67 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +0 -5
@@ -1883,11 +1883,6 @@ Note that using this option lowers the security provided by tboot because it makes the system vulnerable to DMA attacks. - nobounce [Default off] - Disable bounce buffer for untrusted devices such as - the Thunderbolt devices. This will treat the untrusted - devices as the trusted ones, hence might expose security - risks of DMA attacks. intel_idle.max_cstate= [KNL,HW,ACPI,X86] 0 disables intel_idle and fall back on acpi_idle.
drivers/iommu/intel/iommu.c +28 -62
175 lines not on this page · raw message
Signature · 1 line
2.25.1
Quoting Lu Baolu (2020-11-20 10:17:12)
Quoted 10 lines
Lu Baolu (3):
iommu: Add quirk for Intel graphic devices inmap_sgiommu/vt-d: Update domain geometry in iommu_ops.at(de)tach_dev iommu/vt-d: Cleanup after converting to dma-iommu opsTom Murphy (4):
iommu: Handle freelists when using deferred flushing in iommu drivers
iommu: Addiommu_dma_free_cpu_cached_iovas()
iommu: Allow the dma-iommu api to use bounce buffers iommu/vt-d: Convert intel iommu driver to the iommu ops
Something that may be of interest is that we encounter problems with using intel-iommu across a PCI remove event. All HW generations fail with faults like:
DMAR: DRHD: handling fault status reg 3
DMAR: [DMA Write] Request device [00:02.0] PASID ffffffff fault addr 4b822000 [fault reason 02] Present bit in context entry is clear
i.e. they all report missing present bit after re-adding the device to the iommu group. Forcing an identity map (or disabling iommu) works fine.
I applied this series just on the off-chance it changed the symptoms; it does not. If you have any ideas on how to chase down this fault, that would be very useful. We have a few other DMAR faults visible on many platforms, all "[fault reason 07] Next page table ptr is invalid" that are again not affected by this series, that we also need to resolve. -Chris
Lu Baolu
maintainerHi Chris,
Quoted 19 lines · Chris Wilson
Quoting Lu Baolu (2020-11-20 10:17:12)
Quoted 10 lines
Lu Baolu (3):
iommu: Add quirk for Intel graphic devices inmap_sgiommu/vt-d: Update domain geometry in iommu_ops.at(de)tach_dev iommu/vt-d: Cleanup after converting to dma-iommu opsTom Murphy (4):
iommu: Handle freelists when using deferred flushing in iommu drivers
iommu: Addiommu_dma_free_cpu_cached_iovas()
iommu: Allow the dma-iommu api to use bounce buffers iommu/vt-d: Convert intel iommu driver to the iommu opsSomething that may be of interest is that we encounter problems with using intel-iommu across a PCI remove event. All HW generations fail with faults like:
DMAR: DRHD: handling fault status reg 3
DMAR: [DMA Write] Request device [00:02.0] PASID ffffffff fault addr4b822000[fault reason 02] Present bit in context entry is clear
Quoted 8 lines
i.e. they all report missing present bit after re-adding the device to the iommu group. Forcing an identity map (or disabling iommu) works fine.
I applied this series just on the off-chance it changed the symptoms; it does not. If you have any ideas on how to chase down this fault, that would be very useful. We have a few other DMAR faults visible on many platforms, all "[fault reason 07] Next page table ptr is invalid" that are again not affected by this series, that we also need to resolve.
This series only replaces the previous vt-d self-made dma api's with the generic one (which has already been used by some other vendor iommu drivers). It shouldn't solve the problem you're having.
How about reporting them in https://bugzilla.kernel.org/? I have interests to help to figure out possible fixes.
Quoted 2 lines
-Chris
Best regards,
baolu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu