Skip to contentSkip to conversation

mmc: sdhci-sprd: drop of_match_ptr from of_device_id table

PATCH In review Krzysztof Kozlowski 3 participants 5 messages Nov 20, 2020 – Nov 23, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mmc: sdhci-sprd: drop of_match_ptr from of_device_id table

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). This fixes compile warning (!CONFIG_OF on x86_64):

drivers/mmc/host/sdhci-sprd.c:723:34: warning:
‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]

---
 drivers/mmc/host/sdhci-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-sprd.c +1 -1
index 58109c5b53e2..f85171edabeb 100644
@@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
 	.driver = {
 		.name = "sdhci_sprd_r11",
 		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
-		.of_match_table = of_match_ptr(sdhci_sprd_of_match),
+		.of_match_table = sdhci_sprd_of_match,
 		.pm = &sdhci_sprd_pm_ops,
 	},
 };
Signature · 1 line
2.25.1
#1 lore raw

PATCH 2/2 mmc: sdhci-st: drop of_match_ptr from of_device_id table

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). This fixes compile warning (!CONFIG_OF on x86_64):

drivers/mmc/host/sdhci-st.c:512:34: warning:
‘st_sdhci_match’ defined but not used [-Wunused-const-variable=]

---
 drivers/mmc/host/sdhci-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-st.c +1 -1
index 4e9ff3e828ba..962872aec164 100644
@@ -523,7 +523,7 @@ static struct platform_driver sdhci_st_driver = {
 		   .name = "sdhci-st",
 		   .probe_type = PROBE_PREFER_ASYNCHRONOUS,
 		   .pm = &sdhci_st_pmops,
-		   .of_match_table = of_match_ptr(st_sdhci_match),
+		   .of_match_table = st_sdhci_match,
 		  },
 };
 
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH 2/2] mmc: sdhci-st: drop of_match_ptr from of_device_id table

Quoted 10 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). This fixes compile warning (!CONFIG_OF on x86_64):

drivers/mmc/host/sdhci-st.c:512:34: warning:
‘st_sdhci_match’ defined but not used [-Wunused-const-variable=]

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/sdhci-st.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-st.c +1 -2
index 4e9ff3e828ba..962872aec164 100644
@@ -523,7 +523,7 @@ static struct platform_driver sdhci_st_driver = {
                   .name = "sdhci-st",
                   .probe_type = PROBE_PREFER_ASYNCHRONOUS,
                   .pm = &sdhci_st_pmops,
-                  .of_match_table = of_match_ptr(st_sdhci_match),
+                  .of_match_table = st_sdhci_match,
                  },
 };
 
--

2.25.1

reviewer Acked-by on v1 1/2
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 11 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). This fixes compile warning (!CONFIG_OF on x86_64):

drivers/mmc/host/sdhci-sprd.c:723:34: warning:
‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]

Quoted 20 lines
---
 drivers/mmc/host/sdhci-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-sprd.c +1 -2
index 58109c5b53e2..f85171edabeb 100644
@@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
        .driver = {
                .name = "sdhci_sprd_r11",
                .probe_type = PROBE_PREFER_ASYNCHRONOUS,
-               .of_match_table = of_match_ptr(sdhci_sprd_of_match),
+               .of_match_table = sdhci_sprd_of_match,
                .pm = &sdhci_sprd_pm_ops,
        },
 };
--

2.25.1

#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 11 lines · Krzysztof Kozlowski

The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). This fixes compile warning (!CONFIG_OF on x86_64):

drivers/mmc/host/sdhci-sprd.c:723:34: warning:
‘sdhci_sprd_of_match’ defined but not used [-Wunused-const-variable=]

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines
---
 drivers/mmc/host/sdhci-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/sdhci-sprd.c +1 -2
index 58109c5b53e2..f85171edabeb 100644
@@ -788,7 +788,7 @@ static struct platform_driver sdhci_sprd_driver = {
        .driver = {
                .name = "sdhci_sprd_r11",
                .probe_type = PROBE_PREFER_ASYNCHRONOUS,
-               .of_match_table = of_match_ptr(sdhci_sprd_of_match),
+               .of_match_table = sdhci_sprd_of_match,
                .pm = &sdhci_sprd_pm_ops,
        },
 };
--

2.25.1