Skip to contentSkip to conversation

rt-tests: Don't compress man pages by default

PATCH In review John Kacur 2 participants 3 messages Nov 21, 2020 – Nov 23, 2020 Kbuild

lore
Share & tools
lore

John Kacur

author
#0 lore raw

PATCH 1/1 rt-tests: Don't compress man pages by default

This patch changes the default behavior of the Makefile to install man pages without compression. This allows distribution build systems to use the kind of compression they wish to use without the Makefile getting in the way.

It is still possible to compress the man pages using the Makefile, for example

make MAN_COMPRESSION=gzip

or

make MAN_OMPRESSION=bzip2

---
 Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Makefile +1 -2
index a410cb24cf34..3b38d21afb3a 100644
@@ -59,10 +59,9 @@ MANPAGES = src/cyclictest/cyclictest.8 \
 
 ifdef PYLIB
 	MANPAGES += src/cyclictest/get_cyclictest_snapshot.8 \
-	MANPAGES += src/hwlatdetect/hwlatdetect.8
+	src/hwlatdetect/hwlatdetect.8
 endif
 
-MAN_COMPRESSION ?= gzip
 ifeq ($(MAN_COMPRESSION),gzip)
 	MANPAGES := $(MANPAGES:.8=.8.gz)
 else ifeq ($(MAN_COMPRESSION),bzip2)
Signature · 1 line
2.26.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · John Kacur

This patch changes the default behavior of the Makefile to install man pages without compression. This allows distribution build systems to use the kind of compression they wish to use without the Makefile getting in the way.

It is still possible to compress the man pages using the Makefile, for example

Quoted 7 lines

make MAN_COMPRESSION=gzip

or

make MAN_OMPRESSION=bzip2

Yea, that's why I introduced that option in the first place :). Up to now I've used MAN_COMPRESSION=none for build systems.

Thanks,
Kurt

author
#2 lore raw
Quoted 17 lines · Kurt Kanzenbach
Quoted 8 lines · John Kacur

This patch changes the default behavior of the Makefile to install man pages without compression. This allows distribution build systems to use the kind of compression they wish to use without the Makefile getting in the way.

It is still possible to compress the man pages using the Makefile, for example

Quoted 7 lines

make MAN_COMPRESSION=gzip

or

make MAN_OMPRESSION=bzip2

Quoted 8 lines

Yea, that's why I introduced that option in the first place :). Up to now I've used MAN_COMPRESSION=none for build systems.

Thanks,
Kurt

Added your comment and ack to the commit
Cheers!

John