Skip to contentSkip to conversation

checkpatch: add --fix option for INCLUDE_LINUX

PATCH In review Dwaipayan Ray 1 participant 2 messages Nov 21, 2020 – Nov 23, 2020 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 checkpatch: add --fix option for INCLUDE_LINUX

Provide fix option to INCLUDE_LINUX check to replace asm includes.

Macros of type:
#include <asm/percpu.h>

are corrected to:
#include <linux/percpu.h>

---

Changes in v2:
- Use \Q..\E quoting
- Use @ as regex delimiter

 scripts/checkpatch.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +5 -2
index 0da6422cd0fd..e4feb91a0fe4 100755
@@ -5468,8 +5468,11 @@ sub process {
 						CHK("ARCH_INCLUDE_LINUX",
 						    "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
 					} else {
-						WARN("INCLUDE_LINUX",
-						     "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
+						if (WARN("INCLUDE_LINUX",
+							 "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr) &&
+						    $fix) {
+							$fixed[$fixlinenr] =~ s@\Q<asm/$file>\E@<linux/$file>@;
+						}
 					}
 				}
 			}
Signature · 6 lines
2.27.0

_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
#1 lore raw
Quoted 4 lines · Dwaipayan Ray

Provide fix option to INCLUDE_LINUX check to replace asm includes.

Quoted 9 lines

Macros of type:
#include <asm/percpu.h>

are corrected to:
#include <linux/percpu.h>

---

Hello Joe,
Could I get some review on this if you are not too busy.

Thank you,
Dwaipayan.

Quoted 28 lines

Changes in v2:
- Use \Q..\E quoting
- Use @ as regex delimiter

 scripts/checkpatch.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +5 -3
index 0da6422cd0fd..e4feb91a0fe4 100755
@@ -5468,8 +5468,11 @@ sub process {
                                                CHK("ARCH_INCLUDE_LINUX",
                                                    "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
                                        } else {
-                                               WARN("INCLUDE_LINUX",
-                                                    "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
+                                               if (WARN("INCLUDE_LINUX",
+                                                        "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr) &&
+                                                   $fix) {
+                                                       $fixed[$fixlinenr] =~ s@\Q<asm/$file>\E@<linux/$file>@;
+                                               }
                                        }
                                }
                        }
--

2.27.0