Skip to contentSkip to conversation

dpaa2-eth: Fix compile error due to missing devlink support

PATCH In review Ezequiel Garcia 2 participants 4 messages Nov 22, 2020 – Nov 23, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dpaa2-eth: Fix compile error due to missing devlink support

The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to devlink_trap_report' drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'

---
 drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/freescale/dpaa2/Kconfig +1 -0
index cfd369cf4c8c..aee59ead7250 100644
@@ -2,6 +2,7 @@
 config FSL_DPAA2_ETH
 	tristate "Freescale DPAA2 Ethernet"
 	depends on FSL_MC_BUS && FSL_MC_DPIO
+	select NET_DEVLINK
 	select PHYLINK
 	select PCS_LYNX
 	help
Signature · 1 line
2.27.0
maintainer
#1 lore raw

Hi Ezequiel,

Thanks a lot for the fix, I overlooked this when adding devlink support.

Quoted 8 lines · Ezequiel Garcia

The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to devlink_trap_report' drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'

What tree is this intended for?

Maybe add a fixes tag and send this towards the net tree?

Ioana

Quoted 20 lines
---
 drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/freescale/dpaa2/Kconfig +1 -1
index cfd369cf4c8c..aee59ead7250 100644
@@ -2,6 +2,7 @@
 config FSL_DPAA2_ETH
      tristate "Freescale DPAA2 Ethernet"
      depends on FSL_MC_BUS && FSL_MC_DPIO
+     select NET_DEVLINK
      select PHYLINK
      select PCS_LYNX
      help
--

2.27.0

#2 lore raw

Hi Ioana,

Quoted 4 lines · Ioana Ciornei

Hi Ezequiel,

Thanks a lot for the fix, I overlooked this when adding devlink support.

No worries :)

Quoted 12 lines · Ezequiel Garcia
Quoted 8 lines

The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to devlink_trap_report' drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'

What tree is this intended for?

Oops, I forgot about netdev rules. I guess I haven't sent a net patch in a long time.

This patch is a fix, so I guess it's for the 'net' tree.

Quoted 2 lines

Maybe add a fixes tag and send this towards the net tree?

Would you mind too much taking care of this, putting the Fixes you think matches best?

That would be really appreciated!

Thanks,
Ezequiel

Quoted 21 lines

Ioana

Quoted 19 lines
---
 drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/freescale/dpaa2/Kconfig +1 -1
index cfd369cf4c8c..aee59ead7250 100644
@@ -2,6 +2,7 @@
 config FSL_DPAA2_ETH
      tristate "Freescale DPAA2 Ethernet"
      depends on FSL_MC_BUS && FSL_MC_DPIO
+     select NET_DEVLINK
      select PHYLINK
      select PCS_LYNX
      help
--

2.27.0

maintainer
#3 lore raw
Quoted 28 lines · Ezequiel Garcia

Hi Ioana,

Quoted 4 lines · Ioana Ciornei

Hi Ezequiel,

Thanks a lot for the fix, I overlooked this when adding devlink support.

No worries :)

Quoted 12 lines · Ezequiel Garcia
Quoted 8 lines

The dpaa2 driver depends on devlink, so it should select NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to devlink_trap_report' drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'

What tree is this intended for?

Oops, I forgot about netdev rules. I guess I haven't sent a net patch in a long time.

This patch is a fix, so I guess it's for the 'net' tree.

Quoted 8 lines
Quoted 2 lines

Maybe add a fixes tag and send this towards the net tree?

Would you mind too much taking care of this, putting the Fixes you think matches best?

That would be really appreciated!

Sure, I'll respin this.

Ioana