Skip to contentSkip to conversation

wlroots: package does not require locale support

PATCH New Paul Cercueil 3 participants 7 messages Nov 22, 2020 – Dec 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 wlroots: package does not require locale support

Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency of libinput which is selected by wlroots. However, libinput does not depend at all on BR2_ENABLE_LOCALE.

---
 package/wlroots/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/wlroots/Config.in +1 -3
index eb4c4725ac..2f72fd4945 100644
@@ -3,16 +3,14 @@ comment "wlroots needs udev, mesa3d w/ EGL and GLES support"
 		!BR2_PACKAGE_MESA3D_OPENGL_ES || \
 		!BR2_PACKAGE_HAS_UDEV
 
-comment "wlroots needs a toolchain w/ threads, locale, dynamic library"
+comment "wlroots needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_ENABLE_LOCALE || \
 		BR2_STATIC_LIBS
 
 config BR2_PACKAGE_WLROOTS
 	bool "wlroots"
 	depends on !BR2_STATIC_LIBS # wayland
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libdrm, wayland
-	depends on BR2_ENABLE_LOCALE # libinput
 	depends on BR2_PACKAGE_HAS_UDEV # libinput
 	# Technically wlroots should work with any OpenGL implementation
 	# which provides EGL, GLES2, and libgbm; but in practice only
Signature · 1 line
2.29.2
#1 lore raw

PATCH 2/2 cage: package des not require locale support

Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency of wlroots, but wlroots does not depend on it anymore.

---
 package/cage/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/cage/Config.in +1 -3
index c8097751f0..3bef08f037 100644
@@ -3,16 +3,14 @@ comment "cage needs udev, mesa3d w/ EGL and GLES support"
 		!BR2_PACKAGE_MESA3D_OPENGL_ES || \
 		!BR2_PACKAGE_HAS_UDEV
 
-comment "cage needs a toolchain w/ threads, locale, dynamic library"
+comment "cage needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_ENABLE_LOCALE || \
 		BR2_STATIC_LIBS
 
 config BR2_PACKAGE_CAGE
 	bool "cage"
 	depends on !BR2_STATIC_LIBS # wlroots
 	depends on BR2_TOOLCHAIN_HAS_THREADS # wlroots
-	depends on BR2_ENABLE_LOCALE # wlroots
 	depends on BR2_PACKAGE_HAS_UDEV # wlroots
 	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # wlroots
 	depends on BR2_PACKAGE_MESA3D_OPENGL_ES # wlroots
Signature · 1 line
2.29.2
#2 lore raw

PATCH 2/2 cage: package des not require locale support

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Paul" == Paul Cercueil <[email protected]> writes:

s/des/does/, and the prefix should be package/cage, not just cage:

Committed with that fixed, thanks.

Quoted 37 lines

Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency of wlroots, but wlroots does not depend on it anymore.

---
 package/cage/Config.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/cage/Config.in +1 -3
index c8097751f0..3bef08f037 100644
@@ -3,16 +3,14 @@ comment "cage needs udev, mesa3d w/ EGL and GLES support"
 		!BR2_PACKAGE_MESA3D_OPENGL_ES || \
 		!BR2_PACKAGE_HAS_UDEV
 
-comment "cage needs a toolchain w/ threads, locale, dynamic library"
+comment "cage needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_ENABLE_LOCALE || \
 		BR2_STATIC_LIBS
 
 config BR2_PACKAGE_CAGE
 	bool "cage"
 	depends on !BR2_STATIC_LIBS # wlroots
 	depends on BR2_TOOLCHAIN_HAS_THREADS # wlroots
-	depends on BR2_ENABLE_LOCALE # wlroots
 	depends on BR2_PACKAGE_HAS_UDEV # wlroots
 	depends on BR2_PACKAGE_MESA3D_OPENGL_EGL # wlroots
 	depends on BR2_PACKAGE_MESA3D_OPENGL_ES # wlroots
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/2 wlroots: package does not require locale support

In reply to Paul Cercueil
Quoted 3 lines · On Sun, 22 Nov 2020 16:00:07 +0000 Paul Cercueil <[email protected]> wrote:

Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency of libinput which is selected by wlroots. However, libinput does not depend at all on BR2_ENABLE_LOCALE.

The dependency of libinput on BR2_ENABLE_LOCALE was dropped in commit bef6b92b67e08ee8cba085ae95af7e94e7a28202.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/2 wlroots: package does not require locale support

In reply to Paul Cercueil
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Paul" == Paul Cercueil <[email protected]> writes:

Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency of libinput which is selected by wlroots. However, libinput does not depend at all on BR2_ENABLE_LOCALE.

Committed after extending the commit message to explain when libinput lost its locale dependency as suggested by Thomas, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/2 wlroots: package does not require locale support

In reply to Paul Cercueil
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Paul" == Paul Cercueil <[email protected]> writes:

Drop dependency on BR2_ENABLE_LOCALE, which was marked as a dependency of libinput which is selected by wlroots. However, libinput does not depend at all on BR2_ENABLE_LOCALE.

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard