net: dsa: hellcreek: Minor cleanups
Kurt Kanzenbach
maintainercover net: dsa: hellcreek: Minor cleanups
Hi,
fix two minor issues in the hellcreek driver.
Thanks,
Kurt
Kurt Kanzenbach (2):
net: dsa: tag_hellcreek: Cleanup includes
net: dsa: hellcreek: Don't print error message on defer
drivers/net/dsa/hirschmann/hellcreek.c | 2 +- net/dsa/tag_hellcreek.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-)
Signature · 1 line
2.20.1
Kurt Kanzenbach
maintainerPATCH 1/2 net: dsa: tag_hellcreek: Cleanup includes
Remove unused and add needed includes. No functional change.
--- net/dsa/tag_hellcreek.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/dsa/tag_hellcreek.c +1 -3
@@ -8,9 +8,7 @@* Based on tag_ksz.c. */ -#include <linux/etherdevice.h> -#include <linux/list.h> -#include <linux/slab.h> +#include <linux/skbuff.h> #include <net/dsa.h> #include "dsa_priv.h"
Signature · 1 line
2.20.1
Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes
Quoted 4 lines · Kurt Kanzenbach
Remove unused and add needed includes. No functional change.
Suggested-by Vladimir Oltean <[email protected]>Signed-off-by Kurt Kanzenbach <[email protected]>
Signature · 1 line
Florian
Re: [PATCH net-next 1/2] net: dsa: tag_hellcreek: Cleanup includes
In reply to Kurt KanzenbachQuoted 5 lines · Kurt Kanzenbach
Remove unused and add needed includes. No functional change.
Suggested-by Vladimir Oltean <[email protected]>Signed-off-by Kurt Kanzenbach <[email protected]>---
Kurt Kanzenbach
maintainerPATCH 2/2 net: dsa: hellcreek: Don't print error message on defer
In reply to Kurt KanzenbachWhen DSA is not loaded when the driver is probed an error message is printed. But, that's not really an error, just a defer. Use dev_err_probe() instead.
--- drivers/net/dsa/hirschmann/hellcreek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/hirschmann/hellcreek.c +1 -1
@@ -1266,7 +1266,7 @@ static int hellcreek_probe(struct platform_device *pdev) ret =dsa_register_switch (hellcreek->ds);if (ret) { -dev_err (dev,"Unable to register switch\n" ); +dev_err_probe (dev, ret,"Unable to register switch\n" );return ret; }
Signature · 1 line
2.20.1
Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer
Quoted 5 lines · Kurt Kanzenbach
When DSA is not loaded when the driver is probed an error message is printed. But, that's not really an error, just a defer. Use
dev_err_probe()instead.Signed-off-by Kurt Kanzenbach <[email protected]>
Signature · 1 line
Florian
Re: [PATCH net-next 2/2] net: dsa: hellcreek: Don't print error message on defer
In reply to Kurt KanzenbachQuoted 6 lines · Kurt Kanzenbach
When DSA is not loaded when the driver is probed an error message is printed. But, that's not really an error, just a defer. Use
dev_err_probe()instead.Signed-off-by Kurt Kanzenbach <[email protected]>---
This series was applied to netdev/net-next.git (refs/heads/master):
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
Quoted 8 lines · On Sat, 21 Nov 2020 12:44:53 +0100 you wrote:
Hi,
fix two minor issues in the hellcreek driver.
Thanks,
Kurt[...]
Here is the summary with links:
- [net-next,1/2] net: dsa: tag_hellcreek: Cleanup includes
https://git.kernel.org/netdev/net-next/c/8551fad63cd3 - [net-next,2/2] net: dsa: hellcreek: Don't print error message on defer https://git.kernel.org/netdev/net-next/c/ed5ef9fb2023
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html