Skip to contentSkip to conversation

mmc: sdhci-pci-gli: Reduce power consumption for GL9755

PATCH In review Ben Chuang 2 participants 2 messages Nov 23, 2020 – Nov 24, 2020

Subsystems (2)
lore
Share & tools
lore

Ben Chuang

author
#0 lore raw

PATCH 1/1 mmc: sdhci-pci-gli: Reduce power consumption for GL9755

From: Ben Chuang <[email protected]>

For GL9755, reduce power consumption by lowering the LFCLK and disabling the DMACLK on low-power.

---
 drivers/mmc/host/sdhci-pci-gli.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
drivers/mmc/host/sdhci-pci-gli.c +20 -0
index 9887485a4134..f10bdfbfce36 100644
@@ -97,6 +97,10 @@
 #define   GLI_9755_WT_EN_ON     0x1
 #define   GLI_9755_WT_EN_OFF    0x0
 
+#define PCI_GLI_9755_PECONF   0x44
+#define   PCI_GLI_9755_LFCLK    GENMASK(14, 12)
+#define   PCI_GLI_9755_DMACLK   BIT(29)
+
 #define PCI_GLI_9755_PLL            0x64
 #define   PCI_GLI_9755_PLL_LDIV       GENMASK(9, 0)
 #define   PCI_GLI_9755_PLL_PDIV       GENMASK(14, 12)
@@ -519,6 +523,21 @@ static void sdhci_gl9755_set_clock(struct sdhci_host *host, unsigned int clock)
 	sdhci_enable_clk(host, clk);
 }
 
+static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
+{
+	struct pci_dev *pdev = slot->chip->pdev;
+	u32 value;
+
+	gl9755_wt_on(pdev);
+
+	pci_read_config_dword(pdev, PCI_GLI_9755_PECONF, &value);
+	value &= ~PCI_GLI_9755_LFCLK;
+	value &= ~PCI_GLI_9755_DMACLK;
+	pci_write_config_dword(pdev, PCI_GLI_9755_PECONF, value);
+
+	gl9755_wt_off(pdev);
+}
+
 static int gli_probe_slot_gl9750(struct sdhci_pci_slot *slot)
 {
 	struct sdhci_host *host = slot->host;
@@ -534,6 +553,7 @@ static int gli_probe_slot_gl9755(struct sdhci_pci_slot *slot)
 {
 	struct sdhci_host *host = slot->host;
 
+	gl9755_hw_setting(slot);
 	gli_pcie_enable_msi(slot);
 	slot->host->mmc->caps2 |= MMC_CAP2_NO_SDIO;
 	sdhci_enable_v4_mode(host);
Signature · 1 line
2.29.2
#1 lore raw
Quoted 7 lines · Ben Chuang

From: Ben Chuang <[email protected]>

For GL9755, reduce power consumption by lowering the LFCLK and disabling the DMACLK on low-power.

Applied for next, thanks!

Kind regards
Uffe

Quoted 52 lines
---
 drivers/mmc/host/sdhci-pci-gli.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
drivers/mmc/host/sdhci-pci-gli.c +20 -1
index 9887485a4134..f10bdfbfce36 100644
@@ -97,6 +97,10 @@
 #define   GLI_9755_WT_EN_ON     0x1
 #define   GLI_9755_WT_EN_OFF    0x0
 
+#define PCI_GLI_9755_PECONF   0x44
+#define   PCI_GLI_9755_LFCLK    GENMASK(14, 12)
+#define   PCI_GLI_9755_DMACLK   BIT(29)
+
 #define PCI_GLI_9755_PLL            0x64
 #define   PCI_GLI_9755_PLL_LDIV       GENMASK(9, 0)
 #define   PCI_GLI_9755_PLL_PDIV       GENMASK(14, 12)
@@ -519,6 +523,21 @@ static void sdhci_gl9755_set_clock(struct sdhci_host *host, unsigned int clock)
        sdhci_enable_clk(host, clk);
 }
 
+static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
+{
+       struct pci_dev *pdev = slot->chip->pdev;
+       u32 value;
+
+       gl9755_wt_on(pdev);
+
+       pci_read_config_dword(pdev, PCI_GLI_9755_PECONF, &value);
+       value &= ~PCI_GLI_9755_LFCLK;
+       value &= ~PCI_GLI_9755_DMACLK;
+       pci_write_config_dword(pdev, PCI_GLI_9755_PECONF, value);
+
+       gl9755_wt_off(pdev);
+}
+
 static int gli_probe_slot_gl9750(struct sdhci_pci_slot *slot)
 {
        struct sdhci_host *host = slot->host;
@@ -534,6 +553,7 @@ static int gli_probe_slot_gl9755(struct sdhci_pci_slot *slot)
 {
        struct sdhci_host *host = slot->host;
 
+       gl9755_hw_setting(slot);
        gli_pcie_enable_msi(slot);
        slot->host->mmc->caps2 |= MMC_CAP2_NO_SDIO;
        sdhci_enable_v4_mode(host);
--

2.29.2