Skip to contentSkip to conversation

Input: soc_button_array - add missing include

PATCH In review Dmitry Torokhov 2 participants 2 messages Nov 23, 2020

Subsystems (2)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: soc_button_array - add missing include

This fixes the following build errors:

CC [M] drivers/input/misc/soc_button_array.o
drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration]

                        irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
                        ^
drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW'
                        irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
                                              ^

2 errors generated.

Fixes 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags")
---
 drivers/input/misc/soc_button_array.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/misc/soc_button_array.c +1 -0
index cae1a3fae83a..d14a65683c5e 100644
@@ -9,6 +9,7 @@
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/init.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/acpi.h>
 #include <linux/dmi.h>
Signature · 5 lines
2.29.2.454.gaff20da3a2-goog


-- 
Dmitry
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 9 lines · Dmitry Torokhov

This fixes the following build errors:

CC [M] drivers/input/misc/soc_button_array.o
drivers/input/misc/soc_button_array.c:156:4: error: implicit declaration of function 'irq_set_irq_type' [-Werror,-Wimplicit-function-declaration]

                        irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
                        ^
drivers/input/misc/soc_button_array.c:156:26: error: use of undeclared identifier 'IRQ_TYPE_LEVEL_LOW'
                        irq_set_irq_type(irq, IRQ_TYPE_LEVEL_LOW);
                                              ^
Quoted 5 lines

2 errors generated.

Fixes 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which modify the irqflags")

Thanks, patch looks good to me:

Regards,

Hans

Quoted 17 lines
---
 drivers/input/misc/soc_button_array.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/misc/soc_button_array.c +1 -0
index cae1a3fae83a..d14a65683c5e 100644
@@ -9,6 +9,7 @@
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/init.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/acpi.h>
 #include <linux/dmi.h>