net/ice: fix outer UDP Tx offload checksum error

PATCH Applied Murphy Yang 4 participants 4 messages Nov 23, 2020 – Mar 29, 2024 Network drivers

Share & tools

Murphy Yang

author

2020-11-23 07:07 UTC #0 lore raw

PATCH 1/1 net/ice: fix outer UDP Tx offload checksum error

If enable hardware outer UDP TX offload checksum, it doesn't take effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.

In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can calculate the outer tunneling UDP checksum.

Fixes bd70c451532c ("net/ice: support Tx checksum offload for tunnel")

Signed-off-by Murphy Yang <[email protected]>

---
 drivers/net/ice/ice_rxtx.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

drivers/net/ice/ice_rxtx.c +5 -2

index 5fbd68eafc..9769e216bf 100644
@@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
 	*cd_tunneling |= (tx_offload.l2_len >> 1) <<
 		ICE_TXD_CTX_QW0_NATLEN_S;
 
-	if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
-	    (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
+	/**
+	 * Calculate the tunneling UDP checksum.
+	 * Shall be set only if L4TUNT = 01b and EIPT is not zero
+	 */
+	if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
 	    (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
 		*cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;
 }

Signature · 1 line

2.17.1

Xie, WeiX

Tested-by on v1 1/1

2020-11-23 08:30 UTC #1 lore raw

Tested-by Xie,WeiX < [email protected]>

Regards,
Xie Wei

Quoted 43 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Murphy Yang
Sent: Monday, November 23, 2020 3:05 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Yang, MurphyX <[email protected]>
Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error
If enable hardware outer UDP TX offload checksum, it doesn't take effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can calculate the outer tunneling UDP checksum.
Fixes bd70c451532c ("net/ice: support Tx checksum offload for tunnel")
Signed-off-by Murphy Yang <[email protected]>
---
 drivers/net/ice/ice_rxtx.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ice/ice_rxtx.c index renamed from drivers/net/ice/ice_rxtx.c +0 -0
5fbd68eafc..9769e216bf 100644
drivers/net/ice/ice_rxtx.c +5 -3
@@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
 	*cd_tunneling |= (tx_offload.l2_len >> 1) <<
 		ICE_TXD_CTX_QW0_NATLEN_S;
 
-	if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
-	    (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
+	/**
+	 * Calculate the tunneling UDP checksum.
+	 * Shall be set only if L4TUNT = 01b and EIPT is not zero
+	 */
+	if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&
 	    (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
 		*cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;  }
--
2.17.1

Zhang, Qi Z

Acked-by Applied

2020-12-11 02:08 UTC #2 lore raw

Quoted 12 lines

-----Original Message-----
From: Xie, WeiX <[email protected]>
Sent: Monday, November 23, 2020 4:31 PM
To: Yang, MurphyX <[email protected]>; [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Yang, MurphyX <[email protected]>
Subject: RE: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error

Quoted 26 lines

Tested-by Xie,WeiX < [email protected]>
Regards,
Xie Wei
Quoted 21 lines
-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Murphy Yang
Sent: Monday, November 23, 2020 3:05 PM
To: [email protected]
Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>; Yang, SteveX <[email protected]>; Yang, MurphyX <[email protected]>
Subject: [dpdk-dev] [PATCH] net/ice: fix outer UDP Tx offload checksum error
If enable hardware outer UDP TX offload checksum, it doesn't take effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can calculate the outer tunneling UDP checksum.
Fixes bd70c451532c ("net/ice: support Tx checksum offload for
tunnel")
Signed-off-by Murphy Yang <[email protected]>

Acked-by Qi Zhang <[email protected]>

Applied to dpdk-next-net-intel.

Thanks
Qi

David Marchand

2024-03-29 08:26 UTC #3 lore raw

In reply to Murphy Yang

Hello,

Quoted 20 lines · Murphy Yang

If enable hardware outer UDP TX offload checksum, it doesn't take effect when send 'IPv6/UDP/VXLAN' packet with error outer UDP checksum.
In order to take effect, set the 'L4T_CS' flag valid only when 'L4TUNT' equals one and 'EIPT' is not zero. If 'L4T_CS' flag marked, the hardware can calculate the outer tunneling UDP checksum.
Fixes bd70c451532c ("net/ice: support Tx checksum offload for tunnel")
Signed-off-by Murphy Yang <[email protected]>
---
 drivers/net/ice/ice_rxtx.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ice/ice_rxtx.c +0 -0
index 5fbd68eafc..9769e216bf 100644

drivers/net/ice/ice_rxtx.c ice_parse_tunneling_params(uint64_t ol_flags, · line 2326

Quoted 10 lines

drivers/net/ice/ice_rxtx.c +5 -2

@@ -2319,8 +2319,11 @@ ice_parse_tunneling_params(uint64_t ol_flags,
        *cd_tunneling |= (tx_offload.l2_len >> 1) <<
                ICE_TXD_CTX_QW0_NATLEN_S;
 
-       if ((ol_flags & PKT_TX_OUTER_UDP_CKSUM) &&
-           (ol_flags & PKT_TX_OUTER_IP_CKSUM) &&
+       /**
+        * Calculate the tunneling UDP checksum.
+        * Shall be set only if L4TUNT = 01b and EIPT is not zero
+        */
+       if (!(*cd_tunneling & ICE_TX_CTX_EIPT_NONE) &&

drivers/net/ice/base/ice_lan_tx_rx.h: ICE_TX_CTX_EIPT_NONE = 0x0,
So this check above is always true...

I suspect the intent was:
if ((*cd_tunneling & ICE_TXD_CTX_QW0_EIPT_M) != ICE_TX_CTX_EIPT_NONE)

Quoted 6 lines

drivers/net/ice/ice_rxtx.c +0 -1

            (*cd_tunneling & ICE_TXD_CTX_UDP_TUNNELING))
                *cd_tunneling |= ICE_TXD_CTX_QW0_L4T_CS_M;
 }
--

2.17.1

Signature · 1 line

David Marchand