i40e: allow controlling PTP external clock features
Subsystems (2)
PATCH 1/1 i40e: allow controlling PTP external clock features
From: Piotr Kwapulinski <[email protected]>
Provide information what functions are supported by PTP pins and allow controlling them.
Implemented in i40e_ptp_verify() and i40e_pps_configure(). Previously it was not possible to control PTP external clock features.
--- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_ptp.c +14 -2
@@ -241,7 +241,15 @@ static void i40_ptp_reset_timing_events(struct i40e_pf *pf)static int i40e_ptp_verify (struct ptp_clock_info *ptp,unsigned int pin,enum ptp_pin_function func,unsigned int chan) { -/* TODO: implement pin checking */ +switch (func) { +case PTP_PF_NONE : +case PTP_PF_EXTTS : +case PTP_PF_PEROUT : +break ; +case PTP_PF_PHYSYNC : +return -EOPNOTSUPP ; + } +return 0 ; }
@@ -486,7 +494,11 @@ static int i40e_pps_configure(struct ptp_clock_info *ptp, struct ptp_clock_request *rq, int on) { -/* TODO: implement PPS events */ + struct i40e_pf *pf = container_of(ptp, struct i40e_pf, ptp_caps); + +if (!!on) +i40e_ptp_set_1pps_signal_hw (pf); +return 0 ; }
Signature · 7 lines
2.17.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN. Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
PATCH 1/1 i40e: allow controlling PTP external clock features
Quoted 6 lines · Mateusz Palczewski
From: Piotr Kwapulinski <[email protected]>
Provide information what functions are supported by PTP pins and allow controlling them.
Implemented ini40e_ptp_verify()andi40e_pps_configure(). Previously it was not possible to control PTP external clock features.
Why you target that to 'net' tree? it's not a bug fix if you ask me, but a feature implementation.
drivers/net/ethernet/intel/i40e/i40e_ptp.c static void i40_ptp_reset_timing_events(struct i40e_pf *pf) · line 242
Quoted 13 lines
Signed-off-by Piotr Kwapulinski <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)drivers/net/ethernet/intel/i40e/i40e_ptp.c +0
-0@@ -241,7 +241,15 @@ static void i40_ptp_reset_timing_events(struct i40e_pf *pf)static int i40e_ptp_verify (struct ptp_clock_info *ptp,unsigned int pin,enum ptp_pin_function func,unsigned int chan)
I don't see i40e_ptp_verify in the upstream code. Am I missing something?
It also looks to me that you only make use of 1 out of 4 functions args. This will produce compiler warnings.
Quoted 15 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +9
-1{ -/* TODO: implement pin checking */ +switch (func) { +case PTP_PF_NONE : +case PTP_PF_EXTTS : +case PTP_PF_PEROUT : +break ; +case PTP_PF_PHYSYNC : +return -EOPNOTSUPP ; + } +return 0 ; }
drivers/net/ethernet/intel/i40e/i40e_ptp.c static int i40e_pps_configure(struct ptp_clock_info *ptp, · line 496
Quoted 3 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +0
-0@@ -486,7 +494,11 @@ static int i40e_pps_configure(struct ptp_clock_info *ptp,struct ptp_clock_request *rq, int on) {
Again, 'rq' is unused. Also it looks like it could return void.
Quoted 23 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +5
-1-/* TODO: implement PPS events */ + struct i40e_pf *pf = container_of(ptp, struct i40e_pf, ptp_caps); + +if (!!on) +i40e_ptp_set_1pps_signal_hw (pf); +return 0 ; }Signature · 13 lines
2.17.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN. Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan at osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Kwapulinski
PATCH 1/1 i40e: allow controlling PTP external clock features
Quoted 9 lines · Mateusz Palczewski
Quoted 6 lines
From: Piotr Kwapulinski <[email protected]>
Provide information what functions are supported by PTP pins and allow controlling them.
Implemented ini40e_ptp_verify()andi40e_pps_configure(). Previously it was not possible to control PTP external clock features.Why you target that to 'net' tree? it's not a bug fix if you ask me, but a feature implementation.
Thank you for review.
It is intended to go to 'net' tree as all patches related to i40e driver. Isn't it appropriate approach ?
Quoted 7 lines
Quoted 7 lines
Signed-off-by Piotr Kwapulinski <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-)
Quoted 10 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c static void i40_ptp_reset_timing_events(struct · line 242
Quoted 8 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +0
-0@@ -241,7 +241,15 @@ static void i40_ptp_reset_timing_events(struct i40e_pf *pf) static int i40e_ptp_verify(struct ptp_clock_info *ptp, unsigned int pin,enum ptp_pin_function func,unsigned int chan)I don't see
i40e_ptp_verifyin the upstream code. Am I missing something?
There is another patch "i40e: add support for PTP external synchronization clock" being reviewed on intel-wired-lan. It was posted some time ago.
Quoted 3 lines
It also looks to me that you only make use of 1 out of 4 functions args. This will produce compiler warnings.
It depends on compiler options. I cannot see any warnings on my (default) setup. The interface is fixed and just not all arguments are needed. Other drivers use this similarly.
Quoted 15 lines
Quoted 15 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +9
-1{ -/* TODO: implement pin checking */ +switch (func) { +case PTP_PF_NONE : +case PTP_PF_EXTTS : +case PTP_PF_PEROUT : +break ; +case PTP_PF_PHYSYNC : +return -EOPNOTSUPP ; + } +return 0 ; }
Quoted 6 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c static int i40e_pps_configure(struct ptp_clock_info *ptp, · line 496
Quoted 4 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +0
-0@@ -486,7 +494,11 @@ static int i40e_pps_configure(struct ptp_clock_info *ptp,struct ptp_clock_request *rq, int on) {Again, 'rq' is unused. Also it looks like it could return void.
For 'rq' please see my comment above.
Please be more detailed about 'returning void' scenario - I cannot see this.
Quoted 9 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c static int i40e_pps_configure(struct ptp_clock_info *ptp, · line 503
Quoted 9 lines
drivers/net/ethernet/intel/i40e/i40e_ptp.c +5
-1-/* TODO: implement PPS events */ + struct i40e_pf *pf = container_of(ptp, struct i40e_pf, ptp_caps); + +if (!!on) +i40e_ptp_set_1pps_signal_hw (pf); +return 0 ; }
Best Regards,
Piotr