Skip to contentSkip to conversation

linux-next: build warnings after merge of the tip tree

PATCH New Stephen Rothwell 4 participants 4 messages Nov 23, 2020 – Nov 24, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the tip tree, today's linux-next build (htmldocs) produced these warnings:

arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member 'encl' not described in 'sgx_ioc_enclave_provision' arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter 'enclave' description in 'sgx_ioc_enclave_provision'

Introduced by commit

c82c61865024 ("x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw

PATCH 1/1 x86/sgx: Fix sgx_ioc_enclave_provision() kernel-doc comment

Quoted 11 lines · Stephen Rothwell

Hi all,

After merging the tip tree, today's linux-next build (htmldocs) produced these warnings:

arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member 'encl' not described in 'sgx_ioc_enclave_provision' arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter 'enclave' description in 'sgx_ioc_enclave_provision'

Introduced by commit

c82c61865024 ("x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION")

---
From: Borislav Petkov <[email protected]>

Fix

./arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member \
'encl' not described in 'sgx_ioc_enclave_provision'
./arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter \
'enclave' description in 'sgx_ioc_enclave_provision'

---
 arch/x86/kernel/cpu/sgx/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
index 30aefc93a31d..c206aee80a04 100644
@@ -652,7 +652,7 @@ static long sgx_ioc_enclave_init(struct sgx_encl *encl, void __user *arg)
 
 /**
  * sgx_ioc_enclave_provision() - handler for %SGX_IOC_ENCLAVE_PROVISION
- * @enclave:	an enclave pointer
+ * @encl:	an enclave pointer
  * @arg:	userspace pointer to a struct sgx_enclave_provision instance
  *
  * Allow ATTRIBUTE.PROVISION_KEY for an enclave by providing a file handle to
Signature · 7 lines
2.21.0

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
maintainer
#2 lore raw
In reply to Stephen Rothwell
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the tip tree, today's linux-next build (htmldocs) produced these warnings:

Quoted 10 lines

arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member 'encl' not described in 'sgx_ioc_enclave_provision' arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter 'enclave' description in 'sgx_ioc_enclave_provision'

Introduced by commit

c82c61865024 ("x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION")

Signature · 2 lines
Cheers,
Stephen Rothwell

Thanks, was about sending a fix but saw that Boris put already one out, when adding "Link: https://lore.kernel.org/linux-next/[email protected]/"

/Jarkko

#3 lore raw

[tip: x86/sgx] x86/sgx: Fix sgx_ioc_enclave_provision() kernel-doc comment

In reply to Stephen Rothwell
The following commit has been merged into the x86/sgx branch of tip:

The following commit has been merged into the x86/sgx branch of tip:

Commit-ID:     afe76eca862ccde2a0c30105fc97a46a0b59339b
Gitweb:        https://git.kernel.org/tip/afe76eca862ccde2a0c30105fc97a46a0b59339b
Author:        Borislav Petkov <[email protected]>
AuthorDate:    Mon, 23 Nov 2020 11:11:17 +01:00
Committer:     Borislav Petkov <[email protected]>
CommitterDate: Tue, 24 Nov 2020 10:46:01 +01:00

x86/sgx: Fix sgx_ioc_enclave_provision() kernel-doc comment

Fix

./arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Function parameter or member \
'encl' not described in 'sgx_ioc_enclave_provision'
./arch/x86/kernel/cpu/sgx/ioctl.c:666: warning: Excess function parameter \
'enclave' description in 'sgx_ioc_enclave_provision'

---
 arch/x86/kernel/cpu/sgx/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
index 30aefc9..c206aee 100644
@@ -652,7 +652,7 @@ out:
 
 /**
  * sgx_ioc_enclave_provision() - handler for %SGX_IOC_ENCLAVE_PROVISION
- * @enclave:	an enclave pointer
+ * @encl:	an enclave pointer
  * @arg:	userspace pointer to a struct sgx_enclave_provision instance
  *
  * Allow ATTRIBUTE.PROVISION_KEY for an enclave by providing a file handle to