Skip to contentSkip to conversation

via/via_irq: use __func__ to replace string function name

PATCH In review Bernard Zhao 3 participants 4 messages Nov 19, 2020 – Nov 24, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 via/via_irq: use __func__ to replace string function name

This change also fix checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using 'via_driver_irq_postinstall', this function's name, in a string
+ DRM_DEBUG("via_driver_irq_postinstall\n");

---
 drivers/gpu/drm/via/via_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/via/via_irq.c +1 -1
index 24cc445169e2..56ce5d4ee24a 100644
@@ -308,7 +308,7 @@ int via_driver_irq_postinstall(struct drm_device *dev)
 	drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private;
 	u32 status;
 
-	DRM_DEBUG("via_driver_irq_postinstall\n");
+	DRM_DEBUG("fun: %s\n", __func__);
 	if (!dev_priv)
 		return -EINVAL;
 
Signature · 1 line
2.29.0
#1 lore raw

Hi Bernard.

Quoted 15 lines · Bernard Zhao

This change also fix checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using 'via_driver_irq_postinstall', this function's name, in a string

(quoted diff) +1 -0
+	DRM_DEBUG("via_driver_irq_postinstall\n");
---
 drivers/gpu/drm/via/via_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/via/via_irq.c +0 -0
index 24cc445169e2..56ce5d4ee24a 100644

drivers/gpu/drm/via/via_irq.c int via_driver_irq_postinstall(struct drm_device *dev) · line 311

Quoted 5 lines
drivers/gpu/drm/via/via_irq.c +1 -1
@@ -308,7 +308,7 @@ int via_driver_irq_postinstall(struct drm_device *dev)
 	drm_via_private_t *dev_priv = (drm_via_private_t *) dev->dev_private;
 	u32 status;
 
-	DRM_DEBUG("via_driver_irq_postinstall\n");
+	DRM_DEBUG("fun: %s\n", __func__);

DRM_DEBUG() will print the name of the calling function so the use of __func__ here is not relevant.

For this old driver we should try to limit patches to bug fixing and infrastructure updates.

Sam
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#2 lore raw

RFC PATCH 1/1 Add a new "Frozen" status to MAINTAINERS subsystem entries

Quoted 2 lines · Sam Ravnborg

For this old driver we should try to limit patches to bug fixing and infrastructure updates.

It might be useful to add a new "S:" entry type to these old drivers as supported/maintained/obsolete may not really be appropriate.

How about something like "S: Frozen" and checkpatch could emit a message similar to the one for unnecessary changes to obsolete code?

So using the below would emit:

$ ./scripts/checkpatch.pl -f drivers/gpu/drm/via/via_dma.c
WARNING: drivers/gpu/drm/via/via_dma.c is marked as 'frozen' in the MAINTAINERS hierarchy.  No unnecessary modifications please.

Maybe like the below (and fyi there's no additional git lookup overhead as the initial obsolete check already caches the git result).

---
 MAINTAINERS           | 10 +++++++++-
 scripts/checkpatch.pl | 11 +++++++----
 2 files changed, 16 insertions(+), 5 deletions(-)
MAINTAINERS +9 -1
index 5f10105cac6f..6374d29180b8 100644
@@ -88,7 +88,10 @@ Descriptions of section entries and preferred order
 	   Supported:	Someone is actually paid to look after this.
 	   Maintained:	Someone actually looks after it.
 	   Odd Fixes:	It has a maintainer but they don't have time to do
-			much other than throw the odd patch in. See below..
+			much other than throw the odd patch in.
+	   Frozen:	Old code that should not be modified unless changes
+			are to correct actual defects or API infrastructure.
+			Cleanup/style changes are not generally accepted.
 	   Orphan:	No current maintainer [but maybe you could take the
 			role as you write your new code].
 	   Obsolete:	Old code. Something tagged obsolete generally means
@@ -5718,6 +5721,11 @@ S:	Supported
 T:	git git://anongit.freedesktop.org/drm/drm-misc
 F:	drivers/gpu/drm/udl/
 
+DRM DRIVER FOR VIA
+L:	[email protected]
+S:	Frozen
+F:	drivers/gpu/drm/via/
+
 DRM DRIVER FOR VIRTUAL KERNEL MODESETTING (VKMS)
 M:	Rodrigo Siqueira <[email protected]>
 M:	Melissa Wen <[email protected]>
scripts/checkpatch.pl +7 -4
index fdfd5ec09be6..79321cbfb761 100755
@@ -902,8 +902,8 @@ sub seed_camelcase_file {
 
 our %maintained_status = ();
 
-sub is_maintained_obsolete {
-	my ($filename) = @_;
+sub is_maintained {
+	my ($filename, $test) = @_;
 
 	return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
 
@@ -911,7 +911,7 @@ sub is_maintained_obsolete {
 		$maintained_status{$filename} = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback -f $filename 2>&1`;
 	}
 
-	return $maintained_status{$filename} =~ /obsolete/i;
+	return $maintained_status{$filename} =~ /$test/i;
 }
 
 sub is_SPDX_License_valid {
@@ -2633,9 +2633,12 @@ sub process {
 		}
 
 		if ($found_file) {
-			if (is_maintained_obsolete($realfile)) {
+			if (is_maintained($realfile, "obsolete")) {
 				WARN("OBSOLETE",
 				     "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
+			} elsif (is_maintained($realfile, "frozen")) {
+				WARN("FROZEN",
+				     "$realfile is marked as 'frozen' in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
 			}
 			if ($realfile =~ m@^(?:drivers/net/|net/|drivers/staging/)@) {
 				$check = 1;
author
#3 lore raw

Re:[RFC PATCH] Add a new "Frozen" status to MAINTAINERS subsystem entries

CkZyb206IEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+CkRhdGU6IDIwMjAtMTEtMjQgMDY6 MjQ6MDcKVG86ICBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+LEJlcm5hcmQgWmhhbyA8 YmVybmFyZEB2aXZvLmNvbT4KQ2M6ICBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnLEFuZHJl dyBNb3J0b24gPGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc+LExpbnVzIFRvcnZhbGRzIDx0b3J2 YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4sa2VybmVsLWphbml0b3JzIDxrZXJuZWwtamFuaXRv cnNAdmdlci5rZXJuZWwub3JnPixHcmVnIEtIIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4K U3ViamVjdDogW1JGQyBQQVRDSF0gQWRkIGEgbmV3ICJGcm96ZW4iIHN0YXR1cyB0byBNQUlOVEFJ TkVSUyBzdWJzeXN0ZW0gZW50cmllcz5PbiBNb24sIDIwMjAtMTEtMjMgYXQgMjI6NDIgKzAxMDAs IFNhbSBSYXZuYm9yZyB3cm90ZToKPj4gRm9yIHRoaXMgb2xkIGRyaXZlciB3ZSBzaG91bGQgdHJ5 IHRvIGxpbWl0IHBhdGNoZXMgdG8gYnVnIGZpeGluZyBhbmQKPj4gaW5mcmFzdHJ1Y3R1cmUgdXBk YXRlcy4KPgo+SXQgbWlnaHQgYmUgdXNlZnVsIHRvIGFkZCBhIG5ldyAiUzoiIGVudHJ5IHR5cGUg dG8gdGhlc2Ugb2xkIGRyaXZlcnMKPmFzIHN1cHBvcnRlZC9tYWludGFpbmVkL29ic29sZXRlIG1h eSBub3QgcmVhbGx5IGJlIGFwcHJvcHJpYXRlLgo+Cj5Ib3cgYWJvdXQgc29tZXRoaW5nIGxpa2Ug IlM6IEZyb3plbiIgYW5kIGNoZWNrcGF0Y2ggY291bGQgZW1pdCBhCj5tZXNzYWdlIHNpbWlsYXIg dG8gdGhlIG9uZSBmb3IgdW5uZWNlc3NhcnkgY2hhbmdlcyB0byBvYnNvbGV0ZSBjb2RlPwo+Cj5T byB1c2luZyB0aGUgYmVsb3cgd291bGQgZW1pdDoKPgo+JCAuL3NjcmlwdHMvY2hlY2twYXRjaC5w bCAtZiBkcml2ZXJzL2dwdS9kcm0vdmlhL3ZpYV9kbWEuYwo+V0FSTklORzogZHJpdmVycy9ncHUv ZHJtL3ZpYS92aWFfZG1hLmMgaXMgbWFya2VkIGFzICdmcm96ZW4nIGluIHRoZSBNQUlOVEFJTkVS UyBoaWVyYXJjaHkuICBObyB1bm5lY2Vzc2FyeSBtb2RpZmljYXRpb25zIHBsZWFzZS4KPgo+TWF5 YmUgbGlrZSB0aGUgYmVsb3cgKGFuZCBmeWkgdGhlcmUncyBubyBhZGRpdGlvbmFsIGdpdCBsb29r dXAgb3ZlcmhlYWQgYXMKPnRoZSBpbml0aWFsIG9ic29sZXRlIGNoZWNrIGFscmVhZHkgY2FjaGVz IHRoZSBnaXQgcmVzdWx0KS4KPgo+LS0tCj4gTUFJTlRBSU5FUlMgICAgICAgICAgIHwgMTAgKysr KysrKysrLQo+IHNjcmlwdHMvY2hlY2twYXRjaC5wbCB8IDExICsrKysrKystLS0tCj4gMiBmaWxl cyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Cj5kaWZmIC0tZ2l0 IGEvTUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwo+aW5kZXggNWYxMDEwNWNhYzZmLi42Mzc0ZDI5 MTgwYjggMTAwNjQ0Cj4tLS0gYS9NQUlOVEFJTkVSUwo+KysrIGIvTUFJTlRBSU5FUlMKPkBAIC04 OCw3ICs4OCwxMCBAQCBEZXNjcmlwdGlvbnMgb2Ygc2VjdGlvbiBlbnRyaWVzIGFuZCBwcmVmZXJy ZWQgb3JkZXIKPiAJICAgU3VwcG9ydGVkOglTb21lb25lIGlzIGFjdHVhbGx5IHBhaWQgdG8gbG9v ayBhZnRlciB0aGlzLgo+IAkgICBNYWludGFpbmVkOglTb21lb25lIGFjdHVhbGx5IGxvb2tzIGFm dGVyIGl0Lgo+IAkgICBPZGQgRml4ZXM6CUl0IGhhcyBhIG1haW50YWluZXIgYnV0IHRoZXkgZG9u J3QgaGF2ZSB0aW1lIHRvIGRvCj4tCQkJbXVjaCBvdGhlciB0aGFuIHRocm93IHRoZSBvZGQgcGF0 Y2ggaW4uIFNlZSBiZWxvdy4uCj4rCQkJbXVjaCBvdGhlciB0aGFuIHRocm93IHRoZSBvZGQgcGF0 Y2ggaW4uCj4rCSAgIEZyb3plbjoJT2xkIGNvZGUgdGhhdCBzaG91bGQgbm90IGJlIG1vZGlmaWVk IHVubGVzcyBjaGFuZ2VzCj4rCQkJYXJlIHRvIGNvcnJlY3QgYWN0dWFsIGRlZmVjdHMgb3IgQVBJ IGluZnJhc3RydWN0dXJlLgo+KwkJCUNsZWFudXAvc3R5bGUgY2hhbmdlcyBhcmUgbm90IGdlbmVy YWxseSBhY2NlcHRlZC4KPiAJICAgT3JwaGFuOglObyBjdXJyZW50IG1haW50YWluZXIgW2J1dCBt YXliZSB5b3UgY291bGQgdGFrZSB0aGUKPiAJCQlyb2xlIGFzIHlvdSB3cml0ZSB5b3VyIG5ldyBj b2RlXS4KPiAJICAgT2Jzb2xldGU6CU9sZCBjb2RlLiBTb21ldGhpbmcgdGFnZ2VkIG9ic29sZXRl IGdlbmVyYWxseSBtZWFucwo+QEAgLTU3MTgsNiArNTcyMSwxMSBAQCBTOglTdXBwb3J0ZWQKPiBU OglnaXQgZ2l0Oi8vYW5vbmdpdC5mcmVlZGVza3RvcC5vcmcvZHJtL2RybS1taXNjCj4gRjoJZHJp dmVycy9ncHUvZHJtL3VkbC8KPiAKPitEUk0gRFJJVkVSIEZPUiBWSUEKPitMOglkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4rUzoJRnJvemVuCj4rRjoJZHJpdmVycy9ncHUvZHJtL3Zp YS8KPisKPiBEUk0gRFJJVkVSIEZPUiBWSVJUVUFMIEtFUk5FTCBNT0RFU0VUVElORyAoVktNUykK PiBNOglSb2RyaWdvIFNpcXVlaXJhIDxyb2RyaWdvc2lxdWVpcmFtZWxvQGdtYWlsLmNvbT4KPiBN OglNZWxpc3NhIFdlbiA8bWVsaXNzYS5zcndAZ21haWwuY29tPgo+ZGlmZiAtLWdpdCBhL3Njcmlw dHMvY2hlY2twYXRjaC5wbCBiL3NjcmlwdHMvY2hlY2twYXRjaC5wbAo+aW5kZXggZmRmZDVlYzA5 YmU2Li43OTMyMWNiZmI3NjEgMTAwNzU1Cj4tLS0gYS9zY3JpcHRzL2NoZWNrcGF0Y2gucGwKPisr KyBiL3NjcmlwdHMvY2hlY2twYXRjaC5wbAo+QEAgLTkwMiw4ICs5MDIsOCBAQCBzdWIgc2VlZF9j YW1lbGNhc2VfZmlsZSB7Cj4gCj4gb3VyICVtYWludGFpbmVkX3N0YXR1cyA9ICgpOwo+IAo+LXN1 YiBpc19tYWludGFpbmVkX29ic29sZXRlIHsKPi0JbXkgKCRmaWxlbmFtZSkgPSBAXzsKPitzdWIg aXNfbWFpbnRhaW5lZCB7Cj4rCW15ICgkZmlsZW5hbWUsICR0ZXN0KSA9IEBfOwo+IAo+IAlyZXR1 cm4gMCBpZiAoISR0cmVlIHx8ICEoLWUgIiRyb290L3NjcmlwdHMvZ2V0X21haW50YWluZXIucGwi KSk7Cj4gCj5AQCAtOTExLDcgKzkxMSw3IEBAIHN1YiBpc19tYWludGFpbmVkX29ic29sZXRlIHsK PiAJCSRtYWludGFpbmVkX3N0YXR1c3skZmlsZW5hbWV9ID0gYHBlcmwgJHJvb3Qvc2NyaXB0cy9n ZXRfbWFpbnRhaW5lci5wbCAtLXN0YXR1cyAtLW5vbSAtLW5vbCAtLW5vZ2l0IC0tbm9naXQtZmFs bGJhY2sgLWYgJGZpbGVuYW1lIDI+JjFgOwo+IAl9Cj4gCj4tCXJldHVybiAkbWFpbnRhaW5lZF9z dGF0dXN7JGZpbGVuYW1lfSA9fiAvb2Jzb2xldGUvaTsKPisJcmV0dXJuICRtYWludGFpbmVkX3N0 YXR1c3skZmlsZW5hbWV9ID1+IC8kdGVzdC9pOwo+IH0KPiAKPiBzdWIgaXNfU1BEWF9MaWNlbnNl X3ZhbGlkIHsKPkBAIC0yNjMzLDkgKzI2MzMsMTIgQEAgc3ViIHByb2Nlc3Mgewo+IAkJfQo+IAo+ IAkJaWYgKCRmb3VuZF9maWxlKSB7Cj4tCQkJaWYgKGlzX21haW50YWluZWRfb2Jzb2xldGUoJHJl YWxmaWxlKSkgewo+KwkJCWlmIChpc19tYWludGFpbmVkKCRyZWFsZmlsZSwgIm9ic29sZXRlIikp IHsKPiAJCQkJV0FSTigiT0JTT0xFVEUiLAo+IAkJCQkgICAgICIkcmVhbGZpbGUgaXMgbWFya2Vk IGFzICdvYnNvbGV0ZScgaW4gdGhlIE1BSU5UQUlORVJTIGhpZXJhcmNoeS4gIE5vIHVubmVjZXNz YXJ5IG1vZGlmaWNhdGlvbnMgcGxlYXNlLlxuIik7Cj4rCQkJfSBlbHNpZiAoaXNfbWFpbnRhaW5l ZCgkcmVhbGZpbGUsICJmcm96ZW4iKSkgewo+KwkJCQlXQVJOKCJGUk9aRU4iLAo+KwkJCQkgICAg ICIkcmVhbGZpbGUgaXMgbWFya2VkIGFzICdmcm96ZW4nIGluIHRoZSBNQUlOVEFJTkVSUyBoaWVy YXJjaHkuICBObyB1bm5lY2Vzc2FyeSBtb2RpZmljYXRpb25zIHBsZWFzZS5cbiIpOwo+IAkJCX0K PiAJCQlpZiAoJHJlYWxmaWxlID1+IG1AXig/OmRyaXZlcnMvbmV0L3xuZXQvfGRyaXZlcnMvc3Rh Z2luZy8pQCkgewo+IAkJCQkkY2hlY2sgPSAxOwoKSGk6CgpGb3IgbWUsIHRoaXMgc2VlbXMgdG8g YmUgYSBuaWNlIGlkZWEuCkFzIGEgIG5ld2NvbWVyIHRvIHRoZSBjb21tdW5pdHksIG1heWJlIEkg YW0gbm90IHN1cmUgd2hpY2ggZHJpdmVycyBhcmUgaG90IGFuZCB3aGljaCBvbmVzIGRvIG5vdCBu ZWVkIHRvbyBtdWNoIGF0dGVudGlvbi4KV2l0aCB0aGlzIHBhdGNoIHNjcmlwdCwgaXQgd2lsbCBn aXZlIHVzIGEgYmV0dGVyIGd1aWRlLgoKQlIvL0Jlcm5hcmQKPgoNCg0K