Skip to contentSkip to conversation

Create.c: close mdfd and generate uevent

PATCH Applied Mariusz Tkaczyk 2 participants 2 messages Nov 24, 2020 – Nov 25, 2020 MD RAID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Create.c: close mdfd and generate uevent

During mdfd closing change event is not generated because open() is called before start watching mddevice by udev.
Device is ready at this stage. Unblock device, close fd and generate event to give a chance next layers to work.

---
 Create.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
Create.c +2 -5
index 0efa19c..51f8826 100644
@@ -1083,12 +1083,9 @@ int Create(struct supertype *st, char *mddev,
 	} else {
 		pr_err("not starting array - not enough devices.\n");
 	}
-	close(mdfd);
-	/* Give udev a moment to process the Change event caused
-	 * by the close.
-	 */
-	usleep(100*1000);
 	udev_unblock();
+	close(mdfd);
+	sysfs_uevent(&info, "change");
 	return 0;
 
  abort:
Signature · 1 line
2.25.0
Applied
#1 lore raw
Quoted 9 lines · Mariusz Tkaczyk

During mdfd closing change event is not generated because open() is called before start watching mddevice by udev.
Device is ready at this stage. Unblock device, close fd and generate event to give a chance next layers to work.

---
 Create.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Applied!

Thanks,
Jes