libtraceevent: Install kbuffer.h from the install_lib make target
PATCH 1/1 libtraceevent: Install kbuffer.h from the install_lib make target
This file is included in the list of installed headers in ./tools/lib/traceevent in the kernel tree, but was left out here.
--- Makefile | 1 + 1 file changed, 1 insertion(+)
Makefile +1 -0
@@ -418,6 +418,7 @@ install_libs: libs $(Q)$(call do_install,$(LIBTRACEEVENT_SHARED),$(libdir_SQ)/traceevent) $(Q)$(call do_install,$(LIBTRACEFS_SHARED),$(libdir_SQ)/tracefs) $(Q)$(call do_install,$(src)/include/traceevent/event-parse.h,$(includedir_SQ)/traceevent) + $(Q)$(call do_install,$(src)/include/traceevent/kbuffer.h,$(includedir_SQ)/traceevent) $(Q)$(call do_install,$(src)/include/traceevent/trace-seq.h,$(includedir_SQ)/traceevent) $(Q)$(call do_install,$(src)/include/trace-cmd/trace-cmd.h,$(includedir_SQ)/trace-cmd) $(Q)$(call do_install,$(src)/include/tracefs/tracefs.h,$(includedir_SQ)/tracefs)
Signature · 1 line
2.20.1
I figured I'd send this because it might have been left out by mistake given that it's included in the library in the kernel tree, and I've been working on a program that uses kbuffer.h, so thought other people might find it useful, too. Feel free to ignore if it was left out on purpose, though
-Marcelo
Quoted 24 lines · Marcelo Diop-Gonzalez
This file is included in the list of installed headers in
./tools/lib/traceeventin the kernel tree, but was left out here.Signed-off-by Marcelo Diop-Gonzalez <[email protected]>--- Makefile | 1 + 1 file changed, 1 insertion(+)Makefile +1
-1@@ -418,6 +418,7 @@ install_libs: libs $(Q)$(call do_install,$(LIBTRACEEVENT_SHARED),$(libdir_SQ)/traceevent) $(Q)$(call do_install,$(LIBTRACEFS_SHARED),$(libdir_SQ)/tracefs) $(Q)$(call do_install,$(src)/include/traceevent/event-parse.h,$(includedir_SQ)/traceevent) + $(Q)$(call do_install,$(src)/include/traceevent/kbuffer.h,$(includedir_SQ)/traceevent) $(Q)$(call do_install,$(src)/include/traceevent/trace-seq.h,$(includedir_SQ)/traceevent) $(Q)$(call do_install,$(src)/include/trace-cmd/trace-cmd.h,$(includedir_SQ)/trace-cmd) $(Q)$(call do_install,$(src)/include/tracefs/tracefs.h,$(includedir_SQ)/tracefs) --2.20.1
Quoted 6 lines · On Tue, 24 Nov 2020 12:30:28 -0500 Marcelo Diop-Gonzalez…
I figured I'd send this because it might have been left out by mistake given that it's included in the library in the kernel tree, and I've been working on a program that uses
kbuffer.h, so thought other people might find it useful, too. Feel free to ignore if it was left out on purpose, though
Thanks! This was definitely an oversight on my part. I'll add your patch next week as I'm not starting my turkey vacation ;-)
-- Steve
Quoted 10 lines · On Tue, 24 Nov 2020 17:02:58 -0500 Steven Rostedt <[email protected]> wrote:
Quoted 6 lines · On Tue, 24 Nov 2020 12:30:28 -0500 Marcelo Diop-Gonzalez…
I figured I'd send this because it might have been left out by mistake given that it's included in the library in the kernel tree, and I've been working on a program that uses
kbuffer.h, so thought other people might find it useful, too. Feel free to ignore if it was left out on purpose, though
Quoted 3 lines
Thanks! This was definitely an oversight on my part. I'll add your patch next week as I'm not starting my turkey vacation ;-)
I took a quick look before my vacation, and noticed that kbuffer.h is already there. Then I noticed that this is for the trace-cmd.git tree.
The code in trace-cmd.git is now obsolete, and will not be updated for libtraceevent work.
libtraceevent.git now lives at:
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
And we are also moving out libtracefs.git:
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
Sorry for the confusion. We are trying to clean things up, and probably sometime next year, I'll be removing the libtraceevent and libtracefs code from trace-cmd.git, and it will then depend on these as separate packages.
Please feel free to look at those repositories. The libtraceevent is pretty much stable (but will probably be updated as the kernel gets updated), but the libtracefs has a lot more to expand on. It is going to be the API to communicate with the /sys/kernel/tracing directory.
Cheers!
--- Steve
Sounds good! Thanks for taking a look at it.
-Marcelo
Quoted 45 lines · Steven Rostedt
Quoted 10 lines · On Tue, 24 Nov 2020 17:02:58 -0500 Steven Rostedt <[email protected]> wrote:
Quoted 6 lines · On Tue, 24 Nov 2020 12:30:28 -0500 Marcelo Diop-Gonzalez…
I figured I'd send this because it might have been left out by mistake given that it's included in the library in the kernel tree, and I've been working on a program that uses
kbuffer.h, so thought other people might find it useful, too. Feel free to ignore if it was left out on purpose, thoughQuoted 3 lines
Thanks! This was definitely an oversight on my part. I'll add your patch next week as I'm not starting my turkey vacation ;-)
I took a quick look before my vacation, and noticed that
kbuffer.his already there. Then I noticed that this is for the trace-cmd.git tree.The code in trace-cmd.git is now obsolete, and will not be updated for libtraceevent work.
libtraceevent.git now lives at:
https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
And we are also moving out libtracefs.git:
https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
Sorry for the confusion. We are trying to clean things up, and probably sometime next year, I'll be removing the libtraceevent and libtracefs code from trace-cmd.git, and it will then depend on these as separate packages.
Please feel free to look at those repositories. The libtraceevent is pretty much stable (but will probably be updated as the kernel gets updated), but the libtracefs has a lot more to expand on. It is going to be the API to communicate with the
/sys/kernel/tracingdirectory.Cheers!
--- Steve