modpost: Make static exports fatal
PATCH 1/1 modpost: Make static exports fatal
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. Modpost currently reports that as a warning, but clearly this is not a pattern we should allow, and all in-tree occurences should have been fixed by now. So, promote the warn() message to fatal() to make sure this never happens again.
--- scripts/mod/modpost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/mod/modpost.c +3 -3
@@ -2663,9 +2663,9 @@ int main(int argc, char **argv)for (s = symbolhash[n]; s; s = s->next) {if (s->is_static) -warn ("\"%s\" [%s] is a static %s\n" , - s->name, s->module->name, -export_str (s->export)); +fatal ("\"%s\" [%s] is a static %s\n" , + s->name, s->module->name, +export_str (s->export)); } }
Signature · 1 line
2.29.2.454.gaff20da3a2-goog
Quoted 18 lines · Quentin Perret
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. Modpost currently reports that as a warning, but clearly this is not a pattern we should allow, and all in-tree occurences should have been fixed by now. So, promote the
warn()message tofatal()to make sure this never happens again.Signed-off-by Quentin Perret <[email protected]>--- scripts/mod/modpost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)scripts/mod/modpost.c +0
-0@@ -2663,9 +2663,9 @@ int main(int argc, char **argv)for (s = symbolhash[n]; s; s = s->next) {
scripts/mod/modpost.c int main(int argc, char **argv) · line 2671
Quoted 10 lines
scripts/mod/modpost.c +3
-3if (s->is_static) -warn ("\"%s\" [%s] is a static %s\n" , - s->name, s->module->name, -export_str (s->export)); +fatal ("\"%s\" [%s] is a static %s\n" , + s->name, s->module->name, +export_str (s->export)); } }
Quoted 7 lines · Quentin Perret
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. Modpost currently reports that as a warning, but clearly this is not a pattern we should allow, and all in-tree occurences should have been fixed by now. So, promote the
warn()message tofatal()to make sure this never happens again.Signed-off-by Quentin Perret <[email protected]>
Cheers,
Matthias
Quoted 24 lines
---
scripts/mod/modpost.c| 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)scripts/mod/modpost.c +3
-3@@ -2663,9 +2663,9 @@ int main(int argc, char **argv)for (s = symbolhash[n]; s; s = s->next) {if (s->is_static) -warn ("\"%s\" [%s] is a static %s\n" , - s->name, s->module->name, -export_str (s->export)); +fatal ("\"%s\" [%s] is a static %s\n" , + s->name, s->module->name, +export_str (s->export)); } }Signature · 1 line
2.29.2.454.gaff20da3a2-goog
Quoted 30 lines · Quentin Perret
Using EXPORT_SYMBOL*() on static functions is fundamentally wrong. Modpost currently reports that as a warning, but clearly this is not a pattern we should allow, and all in-tree occurences should have been fixed by now. So, promote the
warn()message tofatal()to make sure this never happens again.Signed-off-by Quentin Perret <[email protected]>--- scripts/mod/modpost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)scripts/mod/modpost.c +3
-4@@ -2663,9 +2663,9 @@ int main(int argc, char **argv)for (s = symbolhash[n]; s; s = s->next) {if (s->is_static) -warn ("\"%s\" [%s] is a static %s\n" , - s->name, s->module->name, -export_str (s->export)); +fatal ("\"%s\" [%s] is a static %s\n" , + s->name, s->module->name, +export_str (s->export)); } } --
Quoted 2 lines
2.29.2.454.gaff20da3a2-goog
I am not a big fan of (ab)using fatal() for this case.
Please consider using error() once
the following is queued up.
https://patchwork.kernel.org/project/linux-kbuild/patch/[email protected]/
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 6 lines · Masahiro Yamada
I am not a big fan of (ab)using
fatal()for this case.Please consider using
error()once
the following is queued up.https://patchwork.kernel.org/project/linux-kbuild/patch/[email protected]/
Yes, much nicer, thanks for that series.
I'll post a v2 shortly.
Thanks,
Quentin