Skip to contentSkip to conversation

sandbox: Make tracing totally depends on Kconfig

PATCH New Leo Liang 1 participant 1 message Nov 25, 2020

lore
Share & tools
lore

Leo Liang

author
#0 lore raw

PATCH 1/1 sandbox: Make tracing totally depends on Kconfig

With this patch, 'make sandbox_defconfig', choose tracing support option then 'make', would be enough when trying tracing feature with sandbox.

No need to add FTRACE=1

---

  config.mk                 | 2 +-
  include/configs/sandbox.h | 7 -------
  lib/Kconfig               | 2 +-
  3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/config.mk b/config.mk
index 7bb1fd4ed1..4ca1774280 100644
--- a/config.mk
+++ b/config.mk
@@ -58,7 +58,7 @@ ifdef BOARD
sinclude $(srctree)/board/$(BOARDDIR)/config.mk # include board specific rules
endif

-ifdef FTRACE
+ifdef CONFIG_TRACE
PLATFORM_CPPFLAGS += -finstrument-functions -DFTRACE endif

diff --git a/include/configs/sandbox.h b/include/configs/sandbox.h index e0708fe573..7589162b40 100644
--- a/include/configs/sandbox.h
+++ b/include/configs/sandbox.h
@@ -6,13 +6,6 @@
#ifndef __CONFIG_H
#define __CONFIG_H

-#ifdef FTRACE
-#define CONFIG_TRACE
-#define CONFIG_TRACE_BUFFER_SIZE (16 << 20)
-#define CONFIG_TRACE_EARLY_SIZE (16 << 20)
-#define CONFIG_TRACE_EARLY
-#define CONFIG_TRACE_EARLY_ADDR 0x00100000
-#endif

#ifndef CONFIG_SPL_BUILD
#define CONFIG_IO_TRACE
diff --git a/lib/Kconfig b/lib/Kconfig
index 7673d2e4e0..a6bd7fd3ff 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -209,7 +209,7 @@ config BITREVERSE

config TRACE
bool "Support for tracing of function calls and timing"
- imply CMD_TRACE
+ select CMD_TRACE
help
Enables function tracing within U-Boot. This allows recording of call traces including timing information. The command can write data to
--
2.17.0