Skip to contentSkip to conversation

dt-bindings: arm: bcm: bcm4908: fix yaml validation

PATCH In review Rafał Miłecki 2 participants 2 messages Nov 25, 2020 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: arm: bcm: bcm4908: fix yaml validation

From: Rafał Miłecki <[email protected]>

Root node can obviously have various subnodes so "additionalProperties" should be set to true.

This fixes:
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dt.yaml: /: '#address-cells', '#size-cells', 'aliases', 'axi@81000000', 'chosen', 'clocks', 'cpus', 'gpio-keys-polled', 'interrupt-parent', 'memory@0', 'model', 'pmu', 'soc', 'timer', 'ubus@ff800000' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml

---
Sorry Florian for that. I've just learnt dtbs_check.

---
 Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml +1 -1
index dfe1c1c6bb8c..5fec063d9a13 100644
@@ -33,6 +33,6 @@ properties:
           - const: brcm,bcm49408
           - const: brcm,bcm4908
 
-additionalProperties: false
+additionalProperties: true
 
 ...
Signature · 1 line
2.26.2
#1 lore raw
Quoted 10 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

Root node can obviously have various subnodes so "additionalProperties" should be set to true.

This fixes:
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dt.yaml: /: '#address-cells', '#size-cells', 'aliases', 'axi@81000000', 'chosen', 'clocks', 'cpus', 'gpio-keys-polled', 'interrupt-parent', 'memory@0', 'model', 'pmu', 'soc', 'timer', 'ubus@ff800000' do not match any of the regexes: 'pinctrl-[0-9]+'
From schema: Documentation/devicetree/bindings/arm/bcm/brcm,bcm4908.yaml

Applied and fixed up into "dt-bindings: arm: bcm: document BCM4908 bindings", thanks for the quick turn around!

Signature · 1 line
Florian