ARM: dts: imx28: Fix label name for L2 switch
Subsystems (3)
PATCH 1/3 ARM: dts: imx28: Fix label name for L2 switch
The 'eth_switch' name has been misspelled in the imx28.dtsi file, so this change fixes it.
--- arch/arm/boot/dts/imx28.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx28.dtsi +1 -1
@@ -1317,7 +1317,7 @@ status = "disabled"; }; - etn_switch: switch@800f8000 { + eth_switch: switch@800f8000 { reg = <0x800f8000 0x8000>; status = "disabled"; };
Signature · 1 line
2.20.1
PATCH 2/3 ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
From: Mans Rullgard <[email protected]>
Add pinmux setting for USB1 overcurrent on pwm2 pad.
--- arch/arm/boot/dts/imx28.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)
arch/arm/boot/dts/imx28.dtsi +10 -0
@@ -948,6 +948,16 @@ fsl,pull-up = <MXS_PULL_DISABLE>; }; + usb1_pins_b: usb1@1 { + reg = <1>; + fsl,pinmux-ids = < + MX28_PAD_PWM2__USB1_OVERCURRENT + >; + fsl,drive-strength = <MXS_DRIVE_12mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + usb0_id_pins_a: usb0id@0 { reg = <0>; fsl,pinmux-ids = <
Signature · 1 line
2.20.1
Re: [PATCH 2/3] ARM: dts: imx28: add pinmux for USB1 overcurrent on pwm2
Quoted 5 lines · Lukasz Majewski
From: Mans Rullgard <[email protected]>
Add pinmux setting for USB1 overcurrent on pwm2 pad.
Signed-off-by Mans Rullgard <[email protected]>
Lukasz,
You need to add your SoB.
Shawn
Quoted 28 lines
--- arch/arm/boot/dts/imx28.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)arch/arm/boot/dts/imx28.dtsi +10
-0@@ -948,6 +948,16 @@ fsl,pull-up = <MXS_PULL_DISABLE>; }; + usb1_pins_b: usb1@1 { + reg = <1>; + fsl,pinmux-ids = < + MX28_PAD_PWM2__USB1_OVERCURRENT + >; + fsl,drive-strength = <MXS_DRIVE_12mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + usb0_id_pins_a: usb0id@0 { reg = <0>; fsl,pinmux-ids = <Signature · 1 line
2.20.1
PATCH 3/3 ARM: dts: imx28: Add DTS description of imx28 based XEA board
In reply to Lukasz MajewskiThis patch adds DTS definition of the imx278 based XEA board.
--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx28-lwe.dtsi | 185 +++++++++++++++++++++++++++++++ arch/arm/boot/dts/imx28-xea.dts | 99 +++++++++++++++++ 3 files changed, 286 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx28-lwe.dtsi create mode 100644 arch/arm/boot/dts/imx28-xea.dts
arch/arm/boot/dts/Makefile +2 -1
@@ -702,7 +702,8 @@ dtb-$(CONFIG_ARCH_MXS) += \ imx28-m28evk.dtb \ imx28-sps1.dtb \ imx28-ts4600.dtb \ - imx28-tx28.dtb + imx28-tx28.dtb \ + imx28-xea.dtb dtb-$(CONFIG_ARCH_NOMADIK) += \ ste-nomadik-s8815.dtb \ ste-nomadik-nhk15.dtb
arch/arm/boot/dts/imx28-lwe.dtsi new file +185 -0
185 lines not on this page · raw message
arch/arm/boot/dts/imx28-xea.dts new file +99 -0
99 lines not on this page · raw message
Signature · 1 line
2.20.1
Re: [PATCH 3/3] ARM: dts: imx28: Add DTS description of imx28 based XEA board
Dear Community,
Quoted 312 lines
This patch adds DTS definition of the imx278 based XEA board.
Signed-off-by Lukasz Majewski <[email protected]>--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx28-lwe.dtsi | 185 +++++++++++++++++++++++++++++++ arch/arm/boot/dts/imx28-xea.dts | 99 +++++++++++++++++ 3 files changed, 286 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx28-lwe.dtsi create mode 100644 arch/arm/boot/dts/imx28-xea.dtsarch/arm/boot/dts/Makefile +2
-1@@ -702,7 +702,8 @@ dtb-$(CONFIG_ARCH_MXS) += \ imx28-m28evk.dtb \ imx28-sps1.dtb \ imx28-ts4600.dtb \ - imx28-tx28.dtb + imx28-tx28.dtb \ + imx28-xea.dtb dtb-$(CONFIG_ARCH_NOMADIK) += \ ste-nomadik-s8815.dtb \ ste-nomadik-nhk15.dtb(quoted diff) +0
-0
b/arch/arm/boot/dts/imx28-lwe.dtsinew file mode 100644 index 000000000000..cb2eb4377d9carch/arm/boot/dts/imx28-lwe.dtsi new file +18
-0@@ -0,0 +1,185 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright 2020 + * Lukasz Majewski, DENX Software Engineering, [email protected] + */ + +/dts-v1/; +#include "imx28.dtsi" + +/ { + compatible = "fsl,imx28"; + + aliases { + spi2 = &ssp3; + }; + + chosen { + bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 rorootwait console=ttyAMA0,115200 panic=1";
arch/arm/boot/dts/imx28-lwe.dtsi new file +167
-0+ }; + + memory { + reg = <0x40000000 0x08000000>; + }; + + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + reg_3v3: regulator@0 { + compatible = "regulator-fixed"; + reg = <0>; + regulator-name = "3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + reg_usb_5v: regulator@1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "usb_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high; + }; + + reg_fec_3v3: regulator@2 { + compatible = "regulator-fixed"; + reg = <2>; + regulator-name = "fec-phy"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + regulator-boot-on; + }; + }; +}; + +&duart { + pinctrl-names = "default"; + pinctrl-0 = <&duart_pins_a>; + status = "okay"; +}; + +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins_a>; + status = "okay"; +}; + +&saif0 { + pinctrl-names = "default"; + pinctrl-0 = <&saif0_pins_a>; + #sound-dai-cells = <0>; + assigned-clocks = <&clks 53>; + assigned-clock-rates = <12000000>; + status = "okay"; +}; + +&saif1 { + pinctrl-names = "default"; + pinctrl-0 = <&saif1_pins_a>; + fsl,saif-master = <&saif0>; + #sound-dai-cells = <0>; + status = "okay"; +}; + +&spi3_pins_a { + fsl,pinmux-ids = < + MX28_PAD_AUART2_RX__SSP3_D4 + MX28_PAD_AUART2_TX__SSP3_D5 + MX28_PAD_SSP3_SCK__SSP3_SCK + MX28_PAD_SSP3_MOSI__SSP3_CMD + MX28_PAD_SSP3_MISO__SSP3_D0 + MX28_PAD_SSP3_SS0__SSP3_D3 + MX28_PAD_AUART2_TX__GPIO_3_9 + >; +}; + +&ssp3 { + compatible = "fsl,imx28-spi"; + pinctrl-names = "default"; + pinctrl-0 = <&spi3_pins_a>; + status = "okay"; + + flash0: s25fl256s0@0 { + compatible = "s25fl256s1", "jedec,spi-nor"; + spi-max-frequency = <40000000>; + reg = <0>; + + partitions { + compatible = "fixed-partitions"; + #address-cells = <1>; + #size-cells = <1>; + + partition@0 { + label = "u-boot"; + reg = <0 0x80000>; + read-only; + }; + + partition@80000 { + label = "env0"; + reg = <0x80000 0x10000>; + }; + + partition@90000 { + label = "env1"; + reg = <0x90000 0x10000>; + }; + + partition@100000 { + label = "kernel"; + reg = <0x100000 0x400000>; + }; + + partition@500000 { + label = "swupdate"; + reg = <0x500000 0x800000>; + }; + }; + }; +}; + +&ssp2 { + compatible = "fsl,imx28-spi"; + pinctrl-names = "default"; + pinctrl-0 = <&spi2_pins_a>; + status = "okay"; +}; + +&ssp0 { + compatible = "fsl,imx28-mmc"; + pinctrl-names = "default"; + pinctrl-0 = <&mmc0_8bit_pins_a>; + bus-width = <8>; + vmmc-supply = <®_3v3>; + non-removable; + status = "okay"; +}; + +&usb0 { + vbus-supply = <®_usb_5v>; + pinctrl-names = "default"; + pinctrl-0 = <&usb0_pins_b>, <&usb0_id_pins_a>; + dr_mode = "host"; + status = "okay"; +}; + +&usbphy0 { + status = "okay"; +}; + +&usb1 { + vbus-supply = <®_usb_5v>; + pinctrl-names = "default"; + pinctrl-0 = <&usb1_pins_b>; + dr_mode = "host"; + status = "okay"; +}; + +&usbphy1 { + status = "okay"; +};(quoted diff) +0
-0
b/arch/arm/boot/dts/imx28-xea.dtsnew file mode 100644 index 000000000000..672080485b78arch/arm/boot/dts/imx28-xea.dts new file +89
-0@@ -0,0 +1,99 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright 2020 + * Lukasz Majewski, DENX Software Engineering, [email protected] + */ + +/dts-v1/; +#include "imx28-lwe.dtsi" + +/ { + model = "XEA"; +}; + +&can0 { + pinctrl-names = "default"; + pinctrl-0 = <&can1_pins_a>; + status = "okay"; +}; + +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins_b>; + status = "okay"; +}; + +&pinctrl { + pinctrl-names = "default"; + pinctrl-0 = <&hog_pins_a &hog_pins_tiva>; + + hog_pins_a: hog@0 { + reg = <0>; + fsl,pinmux-ids = < + MX28_PAD_GPMI_D00__GPIO_0_0 + MX28_PAD_GPMI_D02__GPIO_0_2 + MX28_PAD_GPMI_D05__GPIO_0_5 + MX28_PAD_GPMI_CE1N__GPIO_0_17 + MX28_PAD_GPMI_RDY0__GPIO_0_20 + MX28_PAD_GPMI_RDY1__GPIO_0_21 + MX28_PAD_GPMI_RDY2__GPIO_0_22 + MX28_PAD_GPMI_RDN__GPIO_0_24 + MX28_PAD_GPMI_CLE__GPIO_0_27 + MX28_PAD_LCD_VSYNC__GPIO_1_28 + MX28_PAD_SSP1_SCK__GPIO_2_12 + MX28_PAD_SSP1_CMD__GPIO_2_13 + MX28_PAD_SSP2_SS1__GPIO_2_20 + MX28_PAD_SSP2_SS2__GPIO_2_21 + MX28_PAD_LCD_D00__GPIO_1_0 + MX28_PAD_LCD_D01__GPIO_1_1 + MX28_PAD_LCD_D02__GPIO_1_2 + MX28_PAD_LCD_D03__GPIO_1_3 + MX28_PAD_LCD_D04__GPIO_1_4 + MX28_PAD_LCD_D05__GPIO_1_5 + MX28_PAD_LCD_D06__GPIO_1_6 + >; + fsl,drive-strength = <MXS_DRIVE_4mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + + hog_pins_tiva: hog@1 { + reg = <1>; + fsl,pinmux-ids = < + MX28_PAD_GPMI_RDY3__GPIO_0_23 + MX28_PAD_GPMI_WRN__GPIO_0_25 + >; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + + hog_pins_coding: hog@2 { + reg = <2>; + fsl,pinmux-ids = < + MX28_PAD_GPMI_D01__GPIO_0_1 + MX28_PAD_GPMI_D03__GPIO_0_3 + MX28_PAD_GPMI_D04__GPIO_0_4 + MX28_PAD_GPMI_D06__GPIO_0_6 + MX28_PAD_GPMI_D07__GPIO_0_7 + >; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; +}; + +®_fec_3v3 { + gpio = <&gpio0 0 0>; +}; + +®_usb_5v { + gpio = <&gpio0 2 0>;
arch/arm/boot/dts/imx28-xea.dts line 99
Quoted 10 lines
arch/arm/boot/dts/imx28-xea.dts new file +10
-0+}; + +&spi2_pins_a { + fsl,pinmux-ids = < + MX28_PAD_SSP2_SCK__SSP2_SCK + MX28_PAD_SSP2_MOSI__SSP2_CMD + MX28_PAD_SSP2_MISO__SSP2_D0 + MX28_PAD_SSP2_SS0__GPIO_2_19 + >; +};
Gentle ping on this patch.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 3/3] ARM: dts: imx28: Add DTS description of imx28 based XEA board
Hi Shawn,
Quoted 318 lines
Dear Community,
Quoted 316 lines
This patch adds DTS definition of the imx278 based XEA board.
Signed-off-by Lukasz Majewski <[email protected]>--- arch/arm/boot/dts/Makefile | 3 +- arch/arm/boot/dts/imx28-lwe.dtsi | 185 +++++++++++++++++++++++++++++++ arch/arm/boot/dts/imx28-xea.dts | 99 +++++++++++++++++ 3 files changed, 286 insertions(+), 1 deletion(-) create mode 100644 arch/arm/boot/dts/imx28-lwe.dtsi create mode 100644 arch/arm/boot/dts/imx28-xea.dtsarch/arm/boot/dts/Makefile +2
-1@@ -702,7 +702,8 @@ dtb-$(CONFIG_ARCH_MXS) += \ imx28-m28evk.dtb \ imx28-sps1.dtb \ imx28-ts4600.dtb \ - imx28-tx28.dtb + imx28-tx28.dtb \ + imx28-xea.dtb dtb-$(CONFIG_ARCH_NOMADIK) += \ ste-nomadik-s8815.dtb \ ste-nomadik-nhk15.dtb(quoted diff) +0
-0
b/arch/arm/boot/dts/imx28-lwe.dtsinew file mode 100644 index 000000000000..cb2eb4377d9carch/arm/boot/dts/imx28-lwe.dtsi new file +18
-0@@ -0,0 +1,185 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright 2020 + * Lukasz Majewski, DENX Software Engineering, [email protected] + */ + +/dts-v1/; +#include "imx28.dtsi" + +/ { + compatible = "fsl,imx28"; + + aliases { + spi2 = &ssp3; + }; + + chosen { + bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 rorootwait console=ttyAMA0,115200 panic=1";
arch/arm/boot/dts/imx28-lwe.dtsi new file +167
-0+ }; + + memory { + reg = <0x40000000 0x08000000>; + }; + + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>; + + reg_3v3: regulator@0 { + compatible = "regulator-fixed"; + reg = <0>; + regulator-name = "3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + reg_usb_5v: regulator@1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "usb_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high; + }; + + reg_fec_3v3: regulator@2 { + compatible = "regulator-fixed"; + reg = <2>; + regulator-name = "fec-phy"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high; + regulator-boot-on; + }; + }; +}; + +&duart { + pinctrl-names = "default"; + pinctrl-0 = <&duart_pins_a>; + status = "okay"; +}; + +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins_a>; + status = "okay"; +}; + +&saif0 { + pinctrl-names = "default"; + pinctrl-0 = <&saif0_pins_a>; + #sound-dai-cells = <0>; + assigned-clocks = <&clks 53>; + assigned-clock-rates = <12000000>; + status = "okay"; +}; + +&saif1 { + pinctrl-names = "default"; + pinctrl-0 = <&saif1_pins_a>; + fsl,saif-master = <&saif0>; + #sound-dai-cells = <0>; + status = "okay"; +}; + +&spi3_pins_a { + fsl,pinmux-ids = < + MX28_PAD_AUART2_RX__SSP3_D4 + MX28_PAD_AUART2_TX__SSP3_D5 + MX28_PAD_SSP3_SCK__SSP3_SCK + MX28_PAD_SSP3_MOSI__SSP3_CMD + MX28_PAD_SSP3_MISO__SSP3_D0 + MX28_PAD_SSP3_SS0__SSP3_D3 + MX28_PAD_AUART2_TX__GPIO_3_9 + >; +}; + +&ssp3 { + compatible = "fsl,imx28-spi"; + pinctrl-names = "default"; + pinctrl-0 = <&spi3_pins_a>; + status = "okay"; + + flash0: s25fl256s0@0 { + compatible = "s25fl256s1", "jedec,spi-nor"; + spi-max-frequency = <40000000>; + reg = <0>; + + partitions { + compatible = "fixed-partitions"; + #address-cells = <1>; + #size-cells = <1>; + + partition@0 { + label = "u-boot"; + reg = <0 0x80000>; + read-only; + }; + + partition@80000 { + label = "env0"; + reg = <0x80000 0x10000>; + }; + + partition@90000 { + label = "env1"; + reg = <0x90000 0x10000>; + }; + + partition@100000 { + label = "kernel"; + reg = <0x100000 0x400000>; + }; + + partition@500000 { + label = "swupdate"; + reg = <0x500000 0x800000>; + }; + }; + }; +}; + +&ssp2 { + compatible = "fsl,imx28-spi"; + pinctrl-names = "default"; + pinctrl-0 = <&spi2_pins_a>; + status = "okay"; +}; + +&ssp0 { + compatible = "fsl,imx28-mmc"; + pinctrl-names = "default"; + pinctrl-0 = <&mmc0_8bit_pins_a>; + bus-width = <8>; + vmmc-supply = <®_3v3>; + non-removable; + status = "okay"; +}; + +&usb0 { + vbus-supply = <®_usb_5v>; + pinctrl-names = "default"; + pinctrl-0 = <&usb0_pins_b>, <&usb0_id_pins_a>; + dr_mode = "host"; + status = "okay"; +}; + +&usbphy0 { + status = "okay"; +}; + +&usb1 { + vbus-supply = <®_usb_5v>; + pinctrl-names = "default"; + pinctrl-0 = <&usb1_pins_b>; + dr_mode = "host"; + status = "okay"; +}; + +&usbphy1 { + status = "okay"; +};(quoted diff) +0
-0
b/arch/arm/boot/dts/imx28-xea.dtsnew file mode 100644 index 000000000000..672080485b78arch/arm/boot/dts/imx28-xea.dts new file +93
-0@@ -0,0 +1,99 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT +/* + * Copyright 2020 + * Lukasz Majewski, DENX Software Engineering, [email protected] + */ + +/dts-v1/; +#include "imx28-lwe.dtsi" + +/ { + model = "XEA"; +}; + +&can0 { + pinctrl-names = "default"; + pinctrl-0 = <&can1_pins_a>; + status = "okay"; +}; + +&i2c1 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins_b>; + status = "okay"; +}; + +&pinctrl { + pinctrl-names = "default"; + pinctrl-0 = <&hog_pins_a &hog_pins_tiva>; + + hog_pins_a: hog@0 { + reg = <0>; + fsl,pinmux-ids = < + MX28_PAD_GPMI_D00__GPIO_0_0 + MX28_PAD_GPMI_D02__GPIO_0_2 + MX28_PAD_GPMI_D05__GPIO_0_5 + MX28_PAD_GPMI_CE1N__GPIO_0_17 + MX28_PAD_GPMI_RDY0__GPIO_0_20 + MX28_PAD_GPMI_RDY1__GPIO_0_21 + MX28_PAD_GPMI_RDY2__GPIO_0_22 + MX28_PAD_GPMI_RDN__GPIO_0_24 + MX28_PAD_GPMI_CLE__GPIO_0_27 + MX28_PAD_LCD_VSYNC__GPIO_1_28 + MX28_PAD_SSP1_SCK__GPIO_2_12 + MX28_PAD_SSP1_CMD__GPIO_2_13 + MX28_PAD_SSP2_SS1__GPIO_2_20 + MX28_PAD_SSP2_SS2__GPIO_2_21 + MX28_PAD_LCD_D00__GPIO_1_0 + MX28_PAD_LCD_D01__GPIO_1_1 + MX28_PAD_LCD_D02__GPIO_1_2 + MX28_PAD_LCD_D03__GPIO_1_3 + MX28_PAD_LCD_D04__GPIO_1_4 + MX28_PAD_LCD_D05__GPIO_1_5 + MX28_PAD_LCD_D06__GPIO_1_6 + >; + fsl,drive-strength = <MXS_DRIVE_4mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + + hog_pins_tiva: hog@1 { + reg = <1>; + fsl,pinmux-ids = < + MX28_PAD_GPMI_RDY3__GPIO_0_23 + MX28_PAD_GPMI_WRN__GPIO_0_25 + >; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + + hog_pins_coding: hog@2 { + reg = <2>; + fsl,pinmux-ids = < + MX28_PAD_GPMI_D01__GPIO_0_1 + MX28_PAD_GPMI_D03__GPIO_0_3 + MX28_PAD_GPMI_D04__GPIO_0_4 + MX28_PAD_GPMI_D06__GPIO_0_6 + MX28_PAD_GPMI_D07__GPIO_0_7 + >; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; +}; + +®_fec_3v3 { + gpio = <&gpio0 0 0>; +}; + +®_usb_5v { + gpio = <&gpio0 2 0>; +}; + +&spi2_pins_a { + fsl,pinmux-ids = <
Quoted 8 lines
arch/arm/boot/dts/imx28-xea.dts line 99
Quoted 6 lines
arch/arm/boot/dts/imx28-xea.dts new file +6
-0+ MX28_PAD_SSP2_SCK__SSP2_SCK + MX28_PAD_SSP2_MOSI__SSP2_CMD + MX28_PAD_SSP2_MISO__SSP2_D0 + MX28_PAD_SSP2_SS0__GPIO_2_19 + >; +};Gentle ping on this patch.
Gentle ping on this patch. Are there any comments regarding it?
Quoted 4 lines
Best regards,
Quoted 8 lines
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
[email protected]
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]
Fabio Estevam
reviewerRe: [PATCH 3/3] ARM: dts: imx28: Add DTS description of imx28 based XEA board
In reply to Lukasz MajewskiHi Lukasz,
Quoted 7 lines · Lukasz Majewski
arch/arm/boot/dts/imx28-lwe.dtsi new file +1
-0@@ -0,0 +1,185 @@ +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
arch/arm/boot/dts/imx28-lwe.dtsi line 11
Quoted 10 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +10
-0+/* + * Copyright 2020 + * Lukasz Majewski, DENX Software Engineering, [email protected] + */ + +/dts-v1/; +#include "imx28.dtsi" + +/ { + compatible = "fsl,imx28";
You can drop this one.
arch/arm/boot/dts/imx28-lwe.dtsi line 18
Quoted 7 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +7
-0+ + aliases { + spi2 = &ssp3; + }; + + chosen { + bootargs = "root=/dev/mmcblk0p2 rootfstype=ext4 ro rootwait console=ttyAMA0,115200 panic=1";
You could remove bootargs and let the bootloader pass it.
We usually don't pass bootargs in the i.MX dts files.
arch/arm/boot/dts/imx28-lwe.dtsi line 21
Quoted 3 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +3
-0+ }; + + memory {
memory@40000000
otherwise you will get dtc build warnings with W=1.
arch/arm/boot/dts/imx28-lwe.dtsi line 28
Quoted 7 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +7
-0+ reg = <0x40000000 0x08000000>; + }; + + regulators { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <0>;
No need for this 'regulators' container.
arch/arm/boot/dts/imx28-lwe.dtsi line 30
Quoted 2 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +2
-0+ + reg_3v3: regulator@0 {
reg_3v3: regulator-reg-3v3 {
arch/arm/boot/dts/imx28-lwe.dtsi line 32
Quoted 2 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +2
-0+ compatible = "regulator-fixed"; + reg = <0>;
Remove the reg = <0>
Same applies to other regulators.
arch/arm/boot/dts/imx28-lwe.dtsi line 45
Quoted 7 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +7
-0+ reg_usb_5v: regulator@1 { + compatible = "regulator-fixed"; + reg = <1>; + regulator-name = "usb_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + enable-active-high;
Why passing 'enable-active-high' when this is not gpio controlled?
arch/arm/boot/dts/imx28-lwe.dtsi line 54
Quoted 9 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +9
-0+ }; + + reg_fec_3v3: regulator@2 { + compatible = "regulator-fixed"; + reg = <2>; + regulator-name = "fec-phy"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + enable-active-high;
Same here.
arch/arm/boot/dts/imx28-lwe.dtsi line 107
Quoted 7 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +7
-0+&ssp3 { + compatible = "fsl,imx28-spi"; + pinctrl-names = "default"; + pinctrl-0 = <&spi3_pins_a>; + status = "okay"; + + flash0: s25fl256s0@0 {
Node names should be generic
flash@0
arch/arm/boot/dts/imx28-lwe.dtsi line 61
Quoted 6 lines
arch/arm/boot/dts/imx28-lwe.dtsi new file +6
-0+ +/dts-v1/; +#include "imx28-lwe.dtsi" + +/ { + model = "XEA";
compatible = "xea,imx20-lwe", "fsl,imx28";
You should add xea to the vendor prefix in a separate patch.
You also need to add thie board toDocumentation/devicetree/bindings/arm/fsl.yaml
Shawn Guo
AppliedQuoted 4 lines · Lukasz Majewski
The '
eth_switch' name has been misspelled in theimx28.dtsifile, so this change fixes it.Signed-off-by Lukasz Majewski <[email protected]>
Applied, thanks.