leds: lp50xx: add missing fwnode_handle_put in error handling case
PATCH v2 1/1 leds: lp50xx: add missing fwnode_handle_put in error handling case
Fix to set ret and goto child_out for fwnode_handle_put(child) in the error handling case rather than simply return, as done elsewhere in this function.
---
v2: forget to set ret on v1
drivers/leds/leds-lp50xx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/leds/leds-lp50xx.c +4 -2
@@ -487,8 +487,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)*/ mc_led_info =devm_kcalloc (priv->dev,LP50XX_LEDS_PER_MODULE ,sizeof (*mc_led_info),GFP_KERNEL ); -if (!mc_led_info) -return -ENOMEM ; +if (!mc_led_info) { + ret = -ENOMEM ; + goto child_out; + }fwnode_for_each_child_node (child, led_node) { ret = fwnode_property_read_u32(led_node, "color",
Signature · 1 line
2.23.0
Hello
Quoted 21 lines · Qinglang Miao
Fix to set ret and goto
child_outforfwnode_handle_put(child)in the error handling case rather than simply return, as done elsewhere in this function.Fixes 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")Reported-by Hulk Robot <[email protected]>Suggested-by Pavel Machek <[email protected]>Signed-off-by Qinglang Miao <[email protected]>---
v2: forget to set ret on v1drivers/leds/leds-lp50xx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/leds/leds-lp50xx.c +0
-0@@ -487,8 +487,10 @@ static int lp50xx_probe_dt(struct lp50xx *priv)*/ mc_led_info = devm_kcalloc(priv->dev, LP50XX_LEDS_PER_MODULE,
drivers/leds/leds-lp50xx.c static int lp50xx_probe_dt(struct lp50xx *priv) · line 496
Quoted 10 lines
drivers/leds/leds-lp50xx.c +4
-2sizeof(*mc_led_info), GFP_KERNEL); -if (!mc_led_info) -return -ENOMEM ; +if (!mc_led_info) { + ret = -ENOMEM ; + goto child_out; + }fwnode_for_each_child_node (child, led_node) { ret = fwnode_property_read_u32(led_node, "color",
Pavel Machek
AppliedHi!
Quoted 8 lines
Fix to set ret and goto
child_outforfwnode_handle_put(child)in the error handling case rather than simply return, as done elsewhere in this function.Fixes 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")Reported-by Hulk Robot <[email protected]>Suggested-by Pavel Machek <[email protected]>Signed-off-by Qinglang Miao <[email protected]>
Thanks, applied.
Best regards,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek
Quoted 8 lines · Qinglang Miao
Fix to set ret and goto
child_outforfwnode_handle_put(child)in the error handling case rather than simply return, as done elsewhere in this function.Fixes 242b81170fb8 ("leds: lp50xx: Add the LP50XX family of the RGB LED driver")Reported-by Hulk Robot <[email protected]>Suggested-by Pavel Machek <[email protected]>Signed-off-by Qinglang Miao <[email protected]>
Sorry, spoke too fast. We already had equivalent patch in by
RGB LED driver")
Signed-off-by: Christophe JAILLET
<[email protected]>
Let me push that out in few minutes.. so you can double-check.
Sorry for confusion,
Pavel
Signature · 1 line
http://www.livejournal.com/~pavelmachek