Skip to contentSkip to conversation

Revert "package/systemd: disable portabled"

PATCH New Francois Gervais 3 participants 5 messages Nov 25, 2020 – Nov 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 Revert "package/systemd: disable portabled"

This reverts commit b37fa74380557689f2309370c5bc1e770a1831eb.

---
 package/systemd/systemd.mk | 1 -
 1 file changed, 1 deletion(-)
package/systemd/systemd.mk +0 -1
index cb12f667d6..e24c357ccf 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \
 	-Dman=false \
 	-Dmount-path=/usr/bin/mount \
 	-Dnss-systemd=true \
-	-Dportabled=false \
 	-Dquotacheck-path=/usr/sbin/quotacheck \
 	-Dquotaon-path=/usr/sbin/quotaon \
 	-Drootlibdir='/usr/lib' \
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 2/2 package/systemd: add a menu entry to enable portable services

---
 package/systemd/Config.in  | 17 +++++++++++++++++
 package/systemd/systemd.mk |  6 ++++++
 2 files changed, 23 insertions(+)
package/systemd/Config.in +17 -0
index ec34478e3d..3966ba2fc7 100644
@@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
 		!BR2_USE_WCHAR
 
+config BR2_PACKAGE_SYSTEMD_PORTABLED
+	bool "enable portable services"
+	help
+	  Portable services are systemd services that can be dynamically
+	  attached and detached from the system.
+
+	  These services must come with their own root directory which
+	  they are bond to through an automatically generated drop-in.
+
+	  They also have restrictions applied by the host system in the
+	  form of profiles.
+
+	  This functionality is provided by the system service systemd-portabled
+	  along with the corresponding CLI portablectl.
+
+	  https://systemd.io/PORTABLE_SERVICES/
+
 config BR2_PACKAGE_SYSTEMD_QUOTACHECK
 	bool "enable quotacheck tools"
 	help
package/systemd/systemd.mk +6 -0
index e24c357ccf..5aed87f452 100644
@@ -416,6 +416,12 @@ else
 SYSTEMD_CONF_OPTS += -Dpolkit=false
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
+SYSTEMD_CONF_OPTS += -Dportabled=true
+else
+SYSTEMD_CONF_OPTS += -Dportabled=false
+endif
+
 ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
 SYSTEMD_CONF_OPTS += -Dnetworkd=true
 SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management
Signature · 1 line
2.17.1
#2 lore raw

PATCH v2 2/2 package/systemd: add a menu entry to enable portable services

Am Mi., 25. Nov. 2020 um 23:41 Uhr schrieb Francois Gervais <[email protected]>:

Quoted 53 lines
---
 package/systemd/Config.in  | 17 +++++++++++++++++
 package/systemd/systemd.mk |  6 ++++++
 2 files changed, 23 insertions(+)
package/systemd/Config.in +17 -0
index ec34478e3d..3966ba2fc7 100644
@@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"
                !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
                !BR2_USE_WCHAR
 
+config BR2_PACKAGE_SYSTEMD_PORTABLED
+       bool "enable portable services"
+       help
+         Portable services are systemd services that can be dynamically
+         attached and detached from the system.
+
+         These services must come with their own root directory which
+         they are bond to through an automatically generated drop-in.
+
+         They also have restrictions applied by the host system in the
+         form of profiles.
+
+         This functionality is provided by the system service systemd-portabled
+         along with the corresponding CLI portablectl.
+
+         https://systemd.io/PORTABLE_SERVICES/
+
 config BR2_PACKAGE_SYSTEMD_QUOTACHECK
        bool "enable quotacheck tools"
        help
package/systemd/systemd.mk +6 -1
index e24c357ccf..5aed87f452 100644
@@ -416,6 +416,12 @@ else
 SYSTEMD_CONF_OPTS += -Dpolkit=false
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
+SYSTEMD_CONF_OPTS += -Dportabled=true
+else
+SYSTEMD_CONF_OPTS += -Dportabled=false
+endif
+
 ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
 SYSTEMD_CONF_OPTS += -Dnetworkd=true
 SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management
--
Quoted 2 lines

2.17.1

I would prefer this to be a single commit, no point in an extra "revert". Other than that:

Norbert

#3 lore raw

PATCH v2 2/2 package/systemd: add a menu entry to enable portable services

Thank you.

Just a couple administrative questions:

Should I be the one to add your "reviewed-by" tag to the patch or is it the person merging the patch that does it?

Do I increment the patch version doing so?

From: Norbert Lange <[email protected]>
Sent: November 26, 2020 5:44 AM
To: Gervais, Francois <[email protected]>
Cc: buildroot <[email protected]>; Maxime Hadjinlian <[email protected]>; Yann E . MORIN <[email protected]>
Subject: Re: [PATCH v2 2/2] package/systemd: add a menu entry to enable portable services
?
Am Mi., 25. Nov. 2020 um 23:41 Uhr schrieb Francois Gervais
<[email protected]>:

Quoted 49 lines

---
? package/systemd/Config.in? | 17 +++++++++++++++++ ? package/systemd/systemd.mk |? 6 ++++++
? 2 files changed, 23 insertions(+)

package/systemd/Config.in +0 -0
index ec34478e3d..3966ba2fc7 100644
@@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"
 ???????????????? !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \

???????????????? !BR2_USE_WCHAR

package/systemd/Config.in +17 -0
+config BR2_PACKAGE_SYSTEMD_PORTABLED
+?????? bool "enable portable services"
+?????? help
+???????? Portable services are systemd services that can be dynamically
+???????? attached and detached from the system.
+
+???????? These services must come with their own root directory which
+???????? they are bond to through an automatically generated drop-in.
+
+???????? They also have restrictions applied by the host system in the
+???????? form of profiles.
+
+???????? This functionality is provided by the system service systemd-portabled
+???????? along with the corresponding CLI portablectl.
+
+???????? https://urldefense.com/v3/__https://systemd.io/PORTABLE_SERVICES/__;!!Po4YltK3bPMkYw!gdRouwvVrT5d5xkLf7W05Cn-Qm6uCTRtCBu7CTwGU28zxW8UUnLDGHCr_nWk9nwXtJaP3wk$ 
+

? config BR2_PACKAGE_SYSTEMD_QUOTACHECK
???????? bool "enable quotacheck tools"
???????? help

package/systemd/systemd.mk +0 -0
index e24c357ccf..5aed87f452 100644
@@ -416,6 +416,12 @@ else

? SYSTEMD_CONF_OPTS += -Dpolkit=false
? endif

package/systemd/systemd.mk +6 -0
+ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
+SYSTEMD_CONF_OPTS += -Dportabled=true
+else
+SYSTEMD_CONF_OPTS += -Dportabled=false
+endif
+
Quoted 6 lines

? ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
? SYSTEMD_CONF_OPTS += -Dnetworkd=true
? SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management --
2.17.1

I would prefer this to be a single commit, no point in an extra "revert". Other than that:

Norbert

#4 lore raw

PATCH v2 2/2 package/systemd: add a menu entry to enable portable services

Am Do., 26. Nov. 2020 um 14:13 Uhr schrieb Gervais, Francois <[email protected]>:

Quoted 9 lines

Thank you.

Just a couple administrative questions:

Should I be the one to add your "reviewed-by" tag to the patch or is it the person merging the patch that does it?

Do I increment the patch version doing so?

If you don't change anything relevant to my review, and do a patch revision, then you could and should add the tag.

You don't need to revise the patch just to add the tag.

Norbert