hwmon: Add driver for STMicroelectronics PM6764 Voltage Regulator
A message that is not in the archive (sent off-list or not yet received): [email protected]
Guenter Roeck
maintainerQuoted 71 lines · Charles
Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
the output voltage use the
MFR_READ_VOUT0xD4
vout value returned is linear11Signed-off-by Charles Hsu <[email protected]>---
v4:
- Add pm6764tr toDocumentation/hwmon/index.rst. v3:
- Add Documentation(Documentation/hwmon/pm6764tr.rst).
- Fix include order.
v2:
- Fix formatting.
- Removepmbus_do_remove.
- Change from .probe to .probe_new.
v1:
- Initial patchset.
---Documentation/hwmon/index.rst | 1 +
Documentation/hwmon/pm6764tr.rst| 33 ++++++++++++++ drivers/hwmon/pmbus/Kconfig | 9 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/pm6764tr.c | 78 ++++++++++++++++++++++++++++++++5 files changed, 122 insertions(+)create mode 100644
Documentation/hwmon/pm6764tr.rstcreate mode 100644drivers/hwmon/pmbus/pm6764tr.cDocumentation/hwmon/index.rst +0
-0@@ -144,6 +144,7 @@ Hardware Monitoring Kernel Driverspc87360
pc87427
pcf8591
+ pm6764tr
pmbus
powr1220
pxe1610Documentation/hwmon/pm6764tr.rst new file +22
-0@@ -0,0 +1,33 @@ +.. SPDX-License-Identifier: GPL-2.0-only + +Kernel driver pm6764tr +====================== + +Supported chips: + + * ST PM6764TR + + Prefix: 'pm6764tr' + + Addresses scanned: - + + Datasheet: http://www.st.com/resource/en/data_brief/pm6764.pdf + +Authors: + <[email protected]> + +Description: +------------ + +This driver supports the STMicroelectronics PM6764TR chip. The PM6764TR is
Quoted 3 lines
a high
+performance digital controller designed to power Intel’s VR12.5 processors and memories.
This patch is corrupted (line wraps) and thus does not apply.
Quoted 59 lines
Documentation/hwmon/pm6764tr.rst new file +2
-0+ +The device utilizes digital technology to implement all control and powermanagement
+functions to provide maximum flexibility and performance. The NVM is embedded to store
+custom configurations. The PM6764TR device features up to 4-phase programmable operation.Documentation/hwmon/pm6764tr.rst new file +2
-0+ +The PM6764TR supports power state transitions featuring VFDE, andprogrammable DPM
+maintaining the best efficiency over all loading conditions without compromising transient
+response. The device assures fast and independent protectionagainstload overcurrent,Documentation/hwmon/pm6764tr.rst new file +2
-0+under/overvoltage and feedback disconnections. +drivers/hwmon/pmbus/Kconfig +0
-0@@ -220,6 +220,15 @@ config SENSORS_MP2975This driver can also be built as a module. If so, the module will be called mp2975.
drivers/hwmon/pmbus/Kconfig +9
-0+config SENSORS_PM6764TR + tristate "ST PM6764TR" + help + If you say yes here you get hardware monitoring support for ST + PM6764TR. + + This driver can also be built as a module. If so, the module will + be called pm6764tr. +config
SENSORS_PXE1610
tristate "Infineon PXE1610"
helpdrivers/hwmon/pmbus/Makefile +0
-0@@ -25,6 +25,7 @@ obj-$(CONFIG_SENSORS_MAX31785) += max31785.oobj-$(CONFIG_SENSORS_MAX34440) += max34440.o
obj-$(CONFIG_SENSORS_MAX8688) += max8688.o
obj-$(CONFIG_SENSORS_MP2975) += mp2975.o
+obj-$(CONFIG_SENSORS_PM6764TR) += pm6764tr.o
obj-$(CONFIG_SENSORS_PXE1610) += pxe1610.o
obj-$(CONFIG_SENSORS_TPS40422) += tps40422.o
obj-$(CONFIG_SENSORS_TPS53679) += tps53679.odrivers/hwmon/pmbus/pm6764tr.c new file +3
-0@@ -0,0 +1,78 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for STMicroelectronics digital controller PM6764TR
+ */
drivers/hwmon/pmbus/pm6764tr.c
Quoted 9 lines
drivers/hwmon/pmbus/pm6764tr.c new file +9
-0+ +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/mutex.h> +#include <linux/pmbus.h> +#include <linux/slab.h>
Please check include file requirements. (At least) mutex.h and slab.h seem unnecessary.
Quoted 6 lines
drivers/hwmon/pmbus/pm6764tr.c new file +5
-0+#include "pmbus.h" + +#define PM6764TR_PMBUS_READ_VOUT 0xD4 + +static int pm6764tr_read_word_data(struct i2c_client *client, int page, intreg)
Another corruption.
Quoted 20 lines
drivers/hwmon/pmbus/pm6764tr.c new file +20
-0+{ + int ret; + + switch (reg) { + case PMBUS_VIRT_READ_VMON: + ret = pmbus_read_word_data(client, page, PM6764TR_PMBUS_READ_VOUT); + break; + default: + ret = -ENODATA; + break; + } + return ret; +} + +static struct pmbus_driver_info pm6764tr_info = { + .pages = 1, + .format[PSC_VOLTAGE_IN] = linear, + .format[PSC_VOLTAGE_OUT] = vid, + .format[PSC_TEMPERATURE] = linear, + .format[PSC_CURRENT_OUT] = linear,
drivers/hwmon/pmbus/pm6764tr.c
Quoted 10 lines
drivers/hwmon/pmbus/pm6764tr.c new file +10
-0+ .format[PSC_POWER] = linear, + .func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | + PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT | PMBUS_HAVE_VMON | + PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP, + .read_word_data = pm6764tr_read_word_data, +}; + +static int pm6764tr_probe (struct i2c_client *client, + const struct i2c_device_id *id)
Please align continuation lines with "(" in the preceding line (checkpatch --strict will tell).
drivers/hwmon/pmbus/pm6764tr.c
Quoted 12 lines
drivers/hwmon/pmbus/pm6764tr.c new file +12
-0+{ + return pmbus_do_probe(client, id, &pm6764tr_info); +} + +static const struct i2c_device_id pm6764tr_id[] = { + {"pm6764tr", 0}, + {} +}; +MODULE_DEVICE_TABLE (i2c, pm6764tr_id); + +static const struct of_device_id pm6764tr_of_match[] = { + {.compatible = "pm6764tr"},
As mentioned in the other e-mail, this should be something like "st,pm6764tr", and a reference should be added to Documentation/devicetree/bindings/trivial-devices.yaml.
Thanks,
Guenter
Quoted 21 lines
+ {}
drivers/hwmon/pmbus/pm6764tr.c new file +17
-0+}; + +/* This is the driver that will be inserted */ +static struct i2c_driver pm6764tr_driver = { + .driver = { + .name = "pm6764tr", + .of_match_table = of_match_ptr(pm6764tr_of_match), + }, + .probe_new = pm6764tr_probe, + .id_table = pm6764tr_id, +}; + +module_i2c_driver (pm6764tr_driver); + +MODULE_AUTHOR ("Charles Hsu" ); +MODULE_DESCRIPTION ("PMBus driver for ST PM6764TR" ); +MODULE_LICENSE ("GPL" );Signature · 1 line
2.25.1