Skip to contentSkip to conversation

usb: cdns3: gadget: clear trb->length as zero after preparing every trb

PATCH In review Peter Chen 3 participants 4 messages Nov 26, 2020 – Nov 27, 2020

Subsystems (3)
lore
Share & tools
lore

Peter Chen

author maintainer
#0 lore raw

PATCH 1/2 usb: cdns3: gadget: clear trb->length as zero after preparing every trb

From: Peter Chen <[email protected]>

It clears trb->length as zero before preparing td, but if scatter buffer is used for td, there are several trbs within td, it needs to clear every trb->length as zero, otherwise, the default value for trb->length may not be zero after it begins to use the second round of trb rings.

Fixes abc6b579048e ("usb: cdns3: gadget: using correct sg operations")
---
 drivers/usb/cdns3/gadget.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/cdns3/gadget.c +1 -0
index 365f30fb1159..0aa85cc07ff1 100644
@@ -1260,6 +1260,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
 		priv_req->end_trb = priv_ep->enqueue;
 		cdns3_ep_inc_enq(priv_ep);
 		trb = priv_ep->trb_pool + priv_ep->enqueue;
+		trb->length = 0;
 	} while (sg_iter < num_trb);
 
 	trb = priv_req->trb;
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/2 usb: cdns3: core: fix goto label for error path

From: Peter Chen <[email protected]>

The usb_role_switch_register has already called, so if the devm_request_irq has failed, it needs to call usb_role_switch_unregister.

Fixes b1234e3b3b26 ("usb: cdns3: add runtime PM support")
---
 drivers/usb/cdns3/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/cdns3/core.c +1 -1
index 170deb3eacf0..039ab5d2435e 100644
@@ -553,7 +553,7 @@ static int cdns3_probe(struct platform_device *pdev)
 
 		if (ret) {
 			dev_err(cdns->dev, "couldn't register wakeup irq handler\n");
-			goto err3;
+			goto err4;
 		}
 	}
 
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 2/2] usb: cdns3: core: fix goto label for error path

Hello!

Quoted 3 lines · Peter Chen

From: Peter Chen <[email protected]>

The usb_role_switch_register has already called, so if the devm_request_irq

^ been

Quoted 4 lines

has failed, it needs to call usb_role_switch_unregister.

Fixes b1234e3b3b26 ("usb: cdns3: add runtime PM support")

[...]

MBR, Sergei

#3 lore raw

Re: [PATCH 2/2] usb: cdns3: core: fix goto label for error path

Quoted 9 lines · Sergei Shtylyov

Hello!

Quoted 3 lines · Peter Chen

From: Peter Chen <[email protected]>

The usb_role_switch_register has already called, so if the devm_request_irq

^ been

Thanks, will fix it.

Quoted 7 lines
Quoted 4 lines

has failed, it needs to call usb_role_switch_unregister.

Fixes b1234e3b3b26 ("usb: cdns3: add runtime PM support")

[...]

MBR, Sergei

Signature · 2 lines
Thanks,
Peter Chen