media: rockchip: rkisp1: Fix typos in comments and macro definitions
Subsystems (3)
PATCH 1/1 media: rockchip: rkisp1: Fix typos in comments and macro definitions
Fix 4 typos under drivers/media/platform/rockchip/rkisp1/ found by checkpatch, including the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macro definitions.
---
Hi Helen, Dafna,
I noticed that the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macros are not being used yet, but according to page 12 of this developer guide [1] I think they are for *enabling* the ping-pong ("double buffers") mode?
Based on linux-next 9d3e48f20e11 ("Add linux-next specific files for 20201125").
Thanks,
Peilin Ye
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 4 ++-- drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c +2 -2
@@ -46,7 +46,7 @@ enum rkisp1_plane {/* * @fourcc: pixel format * @fmt_type: helper filed for pixel format -* @uv_swap: if cb cr swaped, for yuv +* @uv_swap: if cb cr swapped, for yuv * @write_format: defines how YCbCr self picture data is written to memory * @output_format: defines sp output format * @mbus: the mbus code on the src resizer pad that matches the pixel format
@@ -870,7 +870,7 @@ static void rkisp1_cap_stream_disable(struct rkisp1_capture *cap) {int ret; -/* Stream should stop in interrupt. If it dosn't, stop it by force. */ +/* Stream should stop in interrupt. If it doesn't, stop it by force. */ cap->is_stopping = true; ret = wait_event_timeout(cap->done, !cap->is_streaming,
drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h +2 -2
@@ -106,8 +106,8 @@#define RKISP1_CIF_MI_SP_Y_FULL_YUV2RGB BIT(8)#define RKISP1_CIF_MI_SP_CBCR_FULL_YUV2RGB BIT(9)#define RKISP1_CIF_MI_SP_422NONCOSITEED BIT(10) -#define RKISP1_CIF_MI_MP_PINGPONG_ENABEL BIT(11) -#define RKISP1_CIF_MI_SP_PINGPONG_ENABEL BIT(12) +#define RKISP1_CIF_MI_MP_PINGPONG_ENABLE BIT(11) +#define RKISP1_CIF_MI_SP_PINGPONG_ENABLE BIT(12)#define RKISP1_CIF_MI_MP_AUTOUPDATE_ENABLE BIT(13)#define RKISP1_CIF_MI_SP_AUTOUPDATE_ENABLE BIT(14)#define RKISP1_CIF_MI_LAST_PIXEL_SIG_ENABLE BIT(15)
Signature · 1 line
2.25.1
Hi Peilin,
Quoted 5 lines · Peilin Ye
Fix 4 typos under
drivers/media/platform/rockchip/rkisp1/found by checkpatch, including the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macro definitions.Signed-off-by Peilin Ye <[email protected]>
Thanks
Quoted 6 lines
---
Hi Helen, Dafna,I noticed that the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macros are not being used yet, but according to page 12 of this developer guide [1] I think they are for *enabling* the ping-pong ("double buffers") mode?
Looks like. The documentation I have doesn't explain much about this mode, it just mention that bit is used to enable it, and that MI_{MP,SP}_{CR,CB}_BASE_AD_INIT2 are used to configure base address 2.
Regards,
Helen
Quoted 51 lines
Based on linux-next
9d3e48f20e11("Add linux-next specific files for 20201125").Thanks,
Peilin Yedrivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 4 ++-- drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c +2
-2@@ -46,7 +46,7 @@ enum rkisp1_plane {/* * @fourcc: pixel format * @fmt_type: helper filed for pixel format -* @uv_swap: if cb cr swaped, for yuv +* @uv_swap: if cb cr swapped, for yuv * @write_format: defines how YCbCr self picture data is written to memory * @output_format: defines sp output format * @mbus: the mbus code on the src resizer pad that matches the pixel format @@ -870,7 +870,7 @@ static void rkisp1_cap_stream_disable(struct rkisp1_capture *cap) {int ret; -/* Stream should stop in interrupt. If it dosn't, stop it by force. */ +/* Stream should stop in interrupt. If it doesn't, stop it by force. */ cap->is_stopping = true; ret = wait_event_timeout(cap->done, !cap->is_streaming,drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h +2
-2@@ -106,8 +106,8 @@#define RKISP1_CIF_MI_SP_Y_FULL_YUV2RGB BIT(8)#define RKISP1_CIF_MI_SP_CBCR_FULL_YUV2RGB BIT(9)#define RKISP1_CIF_MI_SP_422NONCOSITEED BIT(10) -#define RKISP1_CIF_MI_MP_PINGPONG_ENABEL BIT(11) -#define RKISP1_CIF_MI_SP_PINGPONG_ENABEL BIT(12) +#define RKISP1_CIF_MI_MP_PINGPONG_ENABLE BIT(11) +#define RKISP1_CIF_MI_SP_PINGPONG_ENABLE BIT(12)#define RKISP1_CIF_MI_MP_AUTOUPDATE_ENABLE BIT(13)#define RKISP1_CIF_MI_SP_AUTOUPDATE_ENABLE BIT(14)#define RKISP1_CIF_MI_LAST_PIXEL_SIG_ENABLE BIT(15)