Skip to contentSkip to conversation

parisc: signal: remove _SA_SIGGFAULT

PATCH In review Anders Roxell 3 participants 5 messages Nov 26, 2020 – Dec 15, 2020 PA-RISC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parisc: signal: remove _SA_SIGGFAULT

When building tinyconfig on parisc the following error shows up:

/tmp/kernel/signal.c: In function 'do_sigaction':
/tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?

 #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
                              ^~~~~~~~~~~~~

The changes in the two individual patches listed in 'Fixes' below are OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags").

Fixes 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
Fixes 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
---
 arch/parisc/include/asm/signal.h | 2 --
 1 file changed, 2 deletions(-)
arch/parisc/include/asm/signal.h +0 -2
index 30dd1e43ef88..715c96ba2ec8 100644
@@ -21,8 +21,6 @@ typedef struct {
 	unsigned long sig[_NSIG_WORDS];
 } sigset_t;
 
-#define __ARCH_UAPI_SA_FLAGS	_SA_SIGGFAULT
-
 #include <asm/sigcontext.h>
 
 #endif /* !__ASSEMBLY */
Signature · 1 line
2.29.2
maintainer
#1 lore raw
Quoted 24 lines · Anders Roxell

When building tinyconfig on parisc the following error shows up:

/tmp/kernel/signal.c: In function 'do_sigaction':
/tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?

 #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
                              ^~~~~~~~~~~~~

The changes in the two individual patches listed in 'Fixes' below are OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags").

Fixes 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
Fixes 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
---
 arch/parisc/include/asm/signal.h | 2 --
 1 file changed, 2 deletions(-)
arch/parisc/include/asm/signal.h +0 -0
index 30dd1e43ef88..715c96ba2ec8 100644

arch/parisc/include/asm/signal.h typedef struct { · line 25

Quoted 5 lines
arch/parisc/include/asm/signal.h +0 -2
@@ -21,8 +21,6 @@ typedef struct {
 	unsigned long sig[_NSIG_WORDS];
 } sigset_t;
 
-#define __ARCH_UAPI_SA_FLAGS	_SA_SIGGFAULT
-

Which kernel are you testing?
I don't see this line in current git head...?!?

Helge

Quoted 4 lines
arch/parisc/include/asm/signal.h +0 -0
 #include <asm/sigcontext.h>
 
 #endif /* !__ASSEMBLY */
#2 lore raw
Quoted 29 lines · Helge Deller
Quoted 27 lines · Anders Roxell

When building tinyconfig on parisc the following error shows up:

/tmp/kernel/signal.c: In function 'do_sigaction':
/tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?

 #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
                              ^~~~~~~~~~~~~

The changes in the two individual patches listed in 'Fixes' below are OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags").

Fixes 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
Fixes 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")
---
 arch/parisc/include/asm/signal.h | 2 --
 1 file changed, 2 deletions(-)
arch/parisc/include/asm/signal.h +0 -0
index 30dd1e43ef88..715c96ba2ec8 100644
@@ -21,8 +21,6 @@ typedef struct {
      unsigned long sig[_NSIG_WORDS];
 } sigset_t;
 
Quoted 4 lines

arch/parisc/include/asm/signal.h typedef struct { · line 25

Quoted 2 lines
arch/parisc/include/asm/signal.h +0 -2
-#define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
-

Which kernel are you testing?

I used used linux-next tag: next-20201126

Cheers,
Anders

Quoted 9 lines

I don't see this line in current git head...?!?

Helge

Quoted 4 lines
arch/parisc/include/asm/signal.h +0 -0
 #include <asm/sigcontext.h>
 
 #endif /* !__ASSEMBLY */
#3 lore raw

Anders,

Quoted 11 lines · Anders Roxell
Quoted 9 lines · Helge Deller
Quoted 7 lines · Anders Roxell

When building tinyconfig on parisc the following error shows up:

/tmp/kernel/signal.c: In function 'do_sigaction':
/tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?

 #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
                              ^~~~~~~~~~~~~
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

The changes in the two individual patches listed in 'Fixes' below are OK. Remove the _SA_SIGGFAULT define since PH-UX isn't going to be supported according to commit 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags").

Fixes 23acdc76f179 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
Fixes 41f5a81c07cd ("parisc: Drop HP-UX specific fcntl and signal flags")

Thanks for your patch the builds are successful now.

Fixes (compared to build next-20201130)
------------------------------------------------------------------------

parisc:
build:
* gcc-10-allnoconfig
* gcc-10-defconfig
* gcc-10-tinyconfig
* gcc-8-allnoconfig
* gcc-8-defconfig
* gcc-8-tinyconfig
* gcc-9-allnoconfig
* gcc-9-defconfig
* gcc-9-tinyconfig

- Naresh

#4 lore raw

Anders,

Quoted 14 lines · Naresh Kamboju

Anders,

Quoted 10 lines · Anders Roxell
Quoted 8 lines · Helge Deller
Quoted 6 lines · Anders Roxell

When building tinyconfig on parisc the following error shows up:

/tmp/kernel/signal.c: In function 'do_sigaction':
/tmp/arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function); did you mean 'SIL_FAULT'?

 #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
                              ^~~~~~~~~~~~~

I see these build failures on Linux mainline.

ref:
https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline/-/jobs/911416687

Steps to reproduce:
-----------------------------
# TuxMake is a command line tool and Python library that provides

# portable and repeatable Linux kernel builds across a variety of
# architectures, toolchains, kernel configurations, and make targets.
#
# TuxMake supports the concept of runtimes.
# See https://docs.tuxmake.org/runtimes/, for that to work it requires
# that you install podman or docker on your system.
#
# To install tuxmake on your system globally:
# sudo pip3 install -U tuxmake
#
# See https://docs.tuxmake.org/ for complete documentation.

tuxmake --runtime docker --target-arch parisc --toolchain gcc-9 --kconfig defconfig

- Naresh