Skip to contentSkip to conversation

package/systemd: add a menu entry to enable portable services

PATCH New Francois Gervais 3 participants 3 messages Nov 26, 2020 – Dec 15, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/systemd: add a menu entry to enable portable services

---
 package/systemd/Config.in  | 17 +++++++++++++++++
 package/systemd/systemd.mk |  7 ++++++-
 2 files changed, 23 insertions(+), 1 deletion(-)
package/systemd/Config.in +17 -0
index ec34478e3d..3966ba2fc7 100644
@@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
 		!BR2_USE_WCHAR
 
+config BR2_PACKAGE_SYSTEMD_PORTABLED
+	bool "enable portable services"
+	help
+	  Portable services are systemd services that can be dynamically
+	  attached and detached from the system.
+
+	  These services must come with their own root directory which
+	  they are bond to through an automatically generated drop-in.
+
+	  They also have restrictions applied by the host system in the
+	  form of profiles.
+
+	  This functionality is provided by the system service systemd-portabled
+	  along with the corresponding CLI portablectl.
+
+	  https://systemd.io/PORTABLE_SERVICES/
+
 config BR2_PACKAGE_SYSTEMD_QUOTACHECK
 	bool "enable quotacheck tools"
 	help
package/systemd/systemd.mk +6 -1
index cb12f667d6..5aed87f452 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \
 	-Dman=false \
 	-Dmount-path=/usr/bin/mount \
 	-Dnss-systemd=true \
-	-Dportabled=false \
 	-Dquotacheck-path=/usr/sbin/quotacheck \
 	-Dquotaon-path=/usr/sbin/quotaon \
 	-Drootlibdir='/usr/lib' \
@@ -417,6 +416,12 @@ else
 SYSTEMD_CONF_OPTS += -Dpolkit=false
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
+SYSTEMD_CONF_OPTS += -Dportabled=true
+else
+SYSTEMD_CONF_OPTS += -Dportabled=false
+endif
+
 ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
 SYSTEMD_CONF_OPTS += -Dnetworkd=true
 SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 1/1 package/systemd: add a menu entry to enable portable services

Is there something more required on my part for this patch?

The delay might be normal but since my previous patches where merged in quite quickly I'd like to make sure I'm not missing something.

From: Gervais, Francois <[email protected]>
Sent: November 26, 2020 10:55 AM
To: buildroot at buildroot.org <[email protected]>
Cc: Maxime Hadjinlian <[email protected]>; Yann E . MORIN <[email protected]>; Norbert Lange <[email protected]>; Gervais, Francois <[email protected]>
Subject: [PATCH v3 1/1] package/systemd: add a menu entry to enable portable services
?

---
?package/systemd/Config.in? | 17 +++++++++++++++++ ?package/systemd/systemd.mk |? 7 ++++++- ?2 files changed, 23 insertions(+), 1 deletion(-)

package/systemd/Config.in +0 -0
index ec34478e3d..3966ba2fc7 100644
@@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"

???????????????? !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
???????????????? !BR2_USE_WCHAR
?
+config BR2_PACKAGE_SYSTEMD_PORTABLED
+?????? bool "enable portable services"
+?????? help
+???????? Portable services are systemd services that can be dynamically +???????? attached and detached from the system.
+
+???????? These services must come with their own root directory which +???????? they are bond to through an automatically generated drop-in. +
+???????? They also have restrictions applied by the host system in the +???????? form of profiles.
+
+???????? This functionality is provided by the system service systemd-portabled +???????? along with the corresponding CLI portablectl.
+
+???????? https://systemd.io/PORTABLE_SERVICES/
+
?config BR2_PACKAGE_SYSTEMD_QUOTACHECK
???????? bool "enable quotacheck tools"
???????? help

package/systemd/systemd.mk +0 -0
index cb12f667d6..5aed87f452 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \

???????? -Dman=false \
???????? -Dmount-path=/usr/bin/mount \
???????? -Dnss-systemd=true \
-?????? -Dportabled=false \
???????? -Dquotacheck-path=/usr/sbin/quotacheck \
???????? -Dquotaon-path=/usr/sbin/quotaon \
???????? -Drootlibdir='/usr/lib' \
@@ -417,6 +416,12 @@ else
?SYSTEMD_CONF_OPTS += -Dpolkit=false
?endif
?
+ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
+SYSTEMD_CONF_OPTS += -Dportabled=true
+else
+SYSTEMD_CONF_OPTS += -Dportabled=false
+endif
+
?ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
?SYSTEMD_CONF_OPTS += -Dnetworkd=true
?SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management

Signature · 1 line
2.17.1
#2 lore raw

PATCH v3 1/1 package/systemd: add a menu entry to enable portable services

Quoted 4 lines · Francois via buildroot

Is there something more required on my part for this patch?

The delay might be normal but since my previous patches where merged in quite quickly I'd like to make sure I'm not missing something.

It's not really normal, but it is usual :-) We have a huge patch backlog, as
you can see on http://patchwork.ozlabs.org/project/buildroot/list/ It can sometimes take up to a year before even a simple patch gets merged, unfortunately.

That said, I've applied your patch now.

Quoted 24 lines

From: Gervais, Francois <[email protected]>
Sent: November 26, 2020 10:55 AM
To: buildroot at buildroot.org <[email protected]>
Cc: Maxime Hadjinlian <[email protected]>; Yann E . MORIN <[email protected]>; Norbert Lange <[email protected]>; Gervais, Francois <[email protected]>
Subject: [PATCH v3 1/1] package/systemd: add a menu entry to enable portable services
?

---
?package/systemd/Config.in? | 17 +++++++++++++++++ ?package/systemd/systemd.mk |? 7 ++++++- ?2 files changed, 23 insertions(+), 1 deletion(-)

package/systemd/Config.in +0 -0
index ec34478e3d..3966ba2fc7 100644
@@ -343,6 +343,23 @@ comment "polkit support needs a toolchain with C++, wchar, NPTL, gcc >= 4.9"
 ???????????????? !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \

???????????????? !BR2_USE_WCHAR
?

package/systemd/Config.in +3 -0
+config BR2_PACKAGE_SYSTEMD_PORTABLED
+?????? bool "enable portable services"
+?????? help

package/systemd/Config.in

Quoted 10 lines
package/systemd/Config.in +10 -0
+???????? Portable services are systemd services that can be dynamically
+???????? attached and detached from the system.
+
+???????? These services must come with their own root directory which
+???????? they are bond to through an automatically generated drop-in.
+
+???????? They also have restrictions applied by the host system in the
+???????? form of profiles.
+
+???????? This functionality is provided by the system service systemd-portabled

This line was too long, as reported by utils/check-package. I fixed that while
applying.

Regards,
Arnout

Quoted 33 lines

+???????? along with the corresponding CLI portablectl.

package/systemd/Config.in +3 -0
+
+???????? https://systemd.io/PORTABLE_SERVICES/
+

?config BR2_PACKAGE_SYSTEMD_QUOTACHECK
???????? bool "enable quotacheck tools"
???????? help

package/systemd/systemd.mk +0 -1
index cb12f667d6..5aed87f452 100644
@@ -33,7 +33,6 @@ SYSTEMD_CONF_OPTS += \
 ???????? -Dman=false \
 ???????? -Dmount-path=/usr/bin/mount \
 ???????? -Dnss-systemd=true \
-?????? -Dportabled=false \
 ???????? -Dquotacheck-path=/usr/sbin/quotacheck \
 ???????? -Dquotaon-path=/usr/sbin/quotaon \
 ???????? -Drootlibdir='/usr/lib' \
@@ -417,6 +416,12 @@ else

?SYSTEMD_CONF_OPTS += -Dpolkit=false
?endif
?

package/systemd/systemd.mk +6 -0
+ifeq ($(BR2_PACKAGE_SYSTEMD_PORTABLED),y)
+SYSTEMD_CONF_OPTS += -Dportabled=true
+else
+SYSTEMD_CONF_OPTS += -Dportabled=false
+endif
+

?ifeq ($(BR2_PACKAGE_SYSTEMD_NETWORKD),y)
?SYSTEMD_CONF_OPTS += -Dnetworkd=true
?SYSTEMD_NETWORKD_USER = systemd-network -1 systemd-network -1 * - - - systemd Network Management