Skip to contentSkip to conversation

nfsd: Fix message level for normal termination

PATCH In review kazuo ito 2 participants 4 messages Nov 27, 2020

Subsystems (2)
lore
Share & tools
lore

kazuo ito

author
#0 lore raw

PATCH 1/1 nfsd: Fix message level for normal termination

A warning message from nfsd terminating normally can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it originated, the current form in the current place started to appear in:

Fixes e096bbc6488d ("knfsd: remove special handling for SIGHUP")
---
 fs/nfsd/nfssvc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfsd/nfssvc.c +2 -2
index f7f6473578af..b08cccb71787 100644
@@ -527,8 +527,8 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
 		return;
 
 	nfsd_shutdown_net(net);
-	printk(KERN_WARNING "nfsd: last server has exited, flushing export "
-			    "cache\n");
+	printk(KERN_INFO "nfsd: last server has exited, flushing export "
+			 "cache\n");
 	nfsd_export_flush(net);
 }
 
Signature · 1 line
2.20.1
#1 lore raw
Quoted 21 lines · kazuo ito

A warning message from nfsd terminating normally can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it originated, the current form in the current place started to appear in:

Fixes e096bbc6488d ("knfsd: remove special handling for SIGHUP")

---
fs/nfsd/nfssvc.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfsd/nfssvc.c +0 -0
index f7f6473578af..b08cccb71787 100644

fs/nfsd/nfssvc.c static void nfsd_last_thread(struct svc_serv *serv, struct net *net) · line 531

Quoted 7 lines
fs/nfsd/nfssvc.c +2 -2
@@ -527,8 +527,8 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
       return;
 
   nfsd_shutdown_net(net);
-    printk(KERN_WARNING "nfsd: last server has exited, flushing export "
-                "cache\n");
+    printk(KERN_INFO "nfsd: last server has exited, flushing export "
+             "cache\n");

pr_info(), please! And see if it will fit on one line.

Quoted 6 lines
fs/nfsd/nfssvc.c +0 -0
   nfsd_export_flush(net);
 }
 
Signature · 1 line
2.20.1
author
#2 lore raw

PATCH 1/1 nfsd: Fix message level for normal termination

The warning message from nfsd terminating normally can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it originated, the current form in the current place started to appear in:

Fixes e096bbc6488d ("knfsd: remove special handling for SIGHUP")
---
 fs/nfsd/nfssvc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/nfsd/nfssvc.c +1 -2
index 27b1ad136150..9323e30a7eaf 100644
@@ -527,8 +527,7 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
 		return;
 
 	nfsd_shutdown_net(net);
-	printk(KERN_WARNING "nfsd: last server has exited, flushing export "
-			    "cache\n");
+	pr_info("nfsd: last server has exited, flushing export cache\n");
 	nfsd_export_flush(net);
 }
 
Signature · 1 line
2.20.1
#3 lore raw
Quoted 21 lines · kazuo ito

The warning message from nfsd terminating normally can confuse system adminstrators or monitoring software.

Though it's not exactly fair to pin-point a commit where it originated, the current form in the current place started to appear in:

Fixes e096bbc6488d ("knfsd: remove special handling for SIGHUP")

---
fs/nfsd/nfssvc.c | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)
fs/nfsd/nfssvc.c +0 -0
index 27b1ad136150..9323e30a7eaf 100644

fs/nfsd/nfssvc.c static void nfsd_last_thread(struct svc_serv *serv, struct net *net) · line 532

Quoted 8 lines
fs/nfsd/nfssvc.c +1 -2
@@ -527,8 +527,7 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
 		return;
 
 	nfsd_shutdown_net(net);
-	printk(KERN_WARNING "nfsd: last server has exited, flushing export "
-			    "cache\n");
+	pr_info("nfsd: last server has exited, flushing export cache\n");
 	nfsd_export_flush(net);
 }

Thanks.

Applied internally for the next full merge window. It should appear soon in the cel-next topic branch at:

git://git.linux-nfs.org/projects/cel/cel-2.6.git

or

https://git.linux-nfs.org/?p=cel/cel-2.6.git;a=summary

--
Chuck Lever