i40e: Fix VFs not created
Subsystems (2)
PATCH 1/1 i40e: Fix VFs not created
From: Sylwester Dziedziuch <[email protected]>
When creating VFs they were sometimes not getting resources. It was caused by not executing i40e_reset_all_vfs due to flag __I40E_VF_DISABLE being set on PF. Because of this IAVF was never able to finish setup sequence never getting reset indication from PF.
Changed test_and_set_bit __I40E_VF_DISABLE in i40e_sync_filters_subtask to test_bit and removed clear_bit. This function should not set this bit it should only check if it hasn't been already set.
--- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +1 -2
@@ -2623,7 +2623,7 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf)return ;if (!test_and_clear_bit (__I40E_MACVLAN_SYNC_PENDING, pf->state))return ; -if (test_and_set_bit (__I40E_VF_DISABLE, pf->state)) { +if (test_bit (__I40E_VF_DISABLE, pf->state)) {set_bit (__I40E_MACVLAN_SYNC_PENDING, pf->state);return ; }
@@ -2641,7 +2641,6 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf) } } } -clear_bit (__I40E_VF_DISABLE, pf->state); }/**
Signature · 7 lines
2.17.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN. Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.
Jankowski
PATCH 1/1 i40e: Fix VFs not created
Quoted 50 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Mateusz Palczewski
Sent: pi?tek, 27 listopada 2020 12:23
To: intel-wired-lan at lists.osuosl.org
Cc: Dziedziuch, SylwesterX <[email protected]>
Subject: [Intel-wired-lan] [PATCH net v1] i40e: Fix VFs not createdFrom: Sylwester Dziedziuch <[email protected]>
When creating VFs they were sometimes not getting resources.
It was caused by not executingi40e_reset_all_vfsdue to flag__I40E_VF_DISABLEbeing set on PF. Because of this IAVF was never able to finish setup sequence never getting reset indication from PF. Changedtest_and_set_bit__I40E_VF_DISABLEini40e_sync_filters_subtasktotest_bitand removedclear_bit.
This function should not set this bit it should only check if it hasn't been already set.Fixes a7542b876075 ("i40e: check __I40E_VF_DISABLE bit in
i40e_sync_filters_subtask")Signed-off-by Sylwester Dziedziuch <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/net/ethernet/intel/i40e/i40e_main.c +1
-1@@ -2623,7 +2623,7 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf)return ;if (!test_and_clear_bit (__I40E_MACVLAN_SYNC_PENDING, pf- >state))return ; -if (test_and_set_bit (__I40E_VF_DISABLE, pf->state)) { +if (test_bit (__I40E_VF_DISABLE, pf->state)) {set_bit (__I40E_MACVLAN_SYNC_PENDING, pf->state);drivers/net/ethernet/intel/i40e/i40e_main.c +0
-1return ; }@@ -2641,7 +2641,6 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf) } } } -clear_bit (__I40E_VF_DISABLE, pf->state); }
Quoted 2 lines
/**
--
PATCH 1/1 i40e: Fix VFs not created
In reply to Mateusz Palczewski[+cc Stefan as author of commit under Fixes:]
Am 27.11.20 um 12:23 schrieb Mateusz Palczewski:
Quoted 39 lines
From: Sylwester Dziedziuch <[email protected]>
When creating VFs they were sometimes not getting resources. It was caused by not executing
i40e_reset_all_vfsdue to flag__I40E_VF_DISABLEbeing set on PF. Because of this IAVF was never able to finish setup sequence never getting reset indication from PF.
Changedtest_and_set_bit__I40E_VF_DISABLEini40e_sync_filters_subtasktotest_bitand removedclear_bit. This function should not set this bit it should only check if it hasn't been already set.Fixes a7542b876075 ("i40e: check __I40E_VF_DISABLE bit in i40e_sync_filters_subtask")Signed-off-by Sylwester Dziedziuch <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/net/ethernet/intel/i40e/i40e_main.c +1
-2@@ -2623,7 +2623,7 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf)return ;if (!test_and_clear_bit (__I40E_MACVLAN_SYNC_PENDING, pf->state))return ; -if (test_and_set_bit (__I40E_VF_DISABLE, pf->state)) { +if (test_bit (__I40E_VF_DISABLE, pf->state)) {set_bit (__I40E_MACVLAN_SYNC_PENDING, pf->state);return ; }@@ -2641,7 +2641,6 @@ static void i40e_sync_filters_subtask(struct i40e_pf *pf) } } } -clear_bit (__I40E_VF_DISABLE, pf->state); }/**