media: rc: add keymap for pine64 remote
Subsystems (3)
PATCH v2 1/1 media: rc: add keymap for pine64 remote
From: Jonas Karlman <[email protected]>
Add a keymap for the pine64 IR remote [0]. The mouse key has been mapped to KEY_EPG to provide a more useful remote.
[0] http://files.pine64.org/doc/Pine%20A64%20Schematic/remote-wit-logo.jpg
---
Changes since v1 [1]:
- reorder code to match the physical layout
- assign KEY_EPG instead of KEY_CONTEXT_MENU
KEY_CONTEXT_MENU duplicates KEY_MENU, and while Seans suggestion of BTN_LEFT visually matches the key, this duplicates KEY_OK in most GUI's designed for remote naviagation, e.g. Kodi and Plex. I've chosen to map KEY_EPG as this is a common tweak in user forums to extend IR remote functionality.
.../devicetree/bindings/media/rc.yaml | 1 + drivers/media/rc/keymaps/Makefile | 1 + drivers/media/rc/keymaps/rc-pine64.c | 65 +++++++++++++++++++ 3 files changed, 67 insertions(+) create mode 100644 drivers/media/rc/keymaps/rc-pine64.c
Documentation/devicetree/bindings/media/rc.yaml +1 -0
@@ -103,6 +103,7 @@ properties: - rc-npgtech - rc-odroid - rc-pctv-sedna + - rc-pine64 - rc-pinnacle-color - rc-pinnacle-grey - rc-pinnacle-pctv-hd
drivers/media/rc/keymaps/Makefile +1 -0
@@ -80,6 +80,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \ rc-npgtech.o \ rc-odroid.o \ rc-pctv-sedna.o \ + rc-pine64.o \ rc-pinnacle-color.o \ rc-pinnacle-grey.o \ rc-pinnacle-pctv-hd.o \
drivers/media/rc/keymaps/rc-pine64.c new file +65 -0
65 lines not on this page · raw message
Signature · 1 line
2.17.1
kernel test robot
build botI love your patch! Yet something to improve:
Hi Christian,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.10-rc5 next-20201126]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christian-Hewitt/media-rc-add-keymap-for-pine64-remote/20201127-110954 base: git://linuxtv.org/media_tree.git master config: mips-randconfig-r005-20201127 (attached as .config) compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f91c9e789bb50680477d0af197fc4d3ccb806c3d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-Hewitt/media-rc-add-keymap-for-pine64-remote/20201127-110954 git checkout f91c9e789bb50680477d0af197fc4d3ccb806c3d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/media/rc/keymaps/rc-pine64.c:47:15: error: 'RC_MAP_PINE64' undeclared here (not in a function); did you mean 'RC_MAP_CINERGY'?
47 | .name = RC_MAP_PINE64,
| ^~~~~~~~~~~~~
| RC_MAP_CINERGYvim +47 drivers/media/rc/keymaps/rc-pine64.c
41
42 static struct rc_map_list pine64_map = {
43 .map = {
44 .scan = pine64,
45 .size = ARRAY_SIZE(pine64),
46 .rc_proto = RC_PROTO_NECX,
> 47 .name = RC_MAP_PINE64,
48 }
49 };
50 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org