Skip to contentSkip to conversation

net: bna: remove trailing semicolon in macro definition

PATCH In review [email protected] 2 participants 3 messages Nov 27, 2020 – Dec 1, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: bna: remove trailing semicolon in macro definition

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/brocade/bna/bna_hw_defs.h +2 -2
index f335b7115c1b..4b19855017d7 100644
@@ -218,7 +218,7 @@ do {									\
 
 /* Set the coalescing timer for the given ib */
 #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
-	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
+	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
 
 /* Acks 'events' # of events for a given ib while disabling interrupts */
 #define bna_ib_ack_disable_irq(_i_dbell, _events)			\
@@ -260,7 +260,7 @@ do {									\
 
 #define bna_txq_prod_indx_doorbell(_tcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
-		(_tcb)->q_dbell));
+		(_tcb)->q_dbell))
 
 #define bna_rxq_prod_indx_doorbell(_rcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \
Signature · 1 line
2.18.4
maintainer
#1 lore raw
Quoted 23 lines · On Fri, 27 Nov 2020 08:55:50 -0800 [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/brocade/bna/bna_hw_defs.h +1 -1
index f335b7115c1b..4b19855017d7 100644
@@ -218,7 +218,7 @@ do {									\
 
 /* Set the coalescing timer for the given ib */
 #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
-	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
+	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
 
 /* Acks 'events' # of events for a given ib while disabling interrupts */
 #define bna_ib_ack_disable_irq(_i_dbell, _events)			\

drivers/net/ethernet/brocade/bna/bna_hw_defs.h do { \ · line 266

Quoted 8 lines
drivers/net/ethernet/brocade/bna/bna_hw_defs.h +1 -1
@@ -260,7 +260,7 @@ do {									\
 
 #define bna_txq_prod_indx_doorbell(_tcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
-		(_tcb)->q_dbell));
+		(_tcb)->q_dbell))
 
 #define bna_rxq_prod_indx_doorbell(_rcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \

Same story here as Daniel pointed out for the BPF patch.

There are 2 macros right below here which also have a semicolon at the end. And these ones are used. So the patch appears to be pretty arbitrary.

author
#2 lore raw
Quoted 30 lines · Jakub Kicinski
Quoted 29 lines · On Fri, 27 Nov 2020 08:55:50 -0800 [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/net/ethernet/brocade/bna/bna_hw_defs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/brocade/bna/bna_hw_defs.h +2 -2
index f335b7115c1b..4b19855017d7 100644
@@ -218,7 +218,7 @@ do {									\
 
 /* Set the coalescing timer for the given ib */
 #define bna_ib_coalescing_timer_set(_i_dbell, _cls_timer)		\
-	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0));
+	((_i_dbell)->doorbell_ack = BNA_DOORBELL_IB_INT_ACK((_cls_timer), 0))
 
 /* Acks 'events' # of events for a given ib while disabling interrupts */
 #define bna_ib_ack_disable_irq(_i_dbell, _events)			\
@@ -260,7 +260,7 @@ do {									\
 
 #define bna_txq_prod_indx_doorbell(_tcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_tcb)->producer_index), \
-		(_tcb)->q_dbell));
+		(_tcb)->q_dbell))
 
Quoted 6 lines

drivers/net/ethernet/brocade/bna/bna_hw_defs.h do { \ · line 266

Quoted 2 lines
drivers/net/ethernet/brocade/bna/bna_hw_defs.h +0 -0
 #define bna_rxq_prod_indx_doorbell(_rcb)				\
 	(writel(BNA_DOORBELL_Q_PRD_IDX((_rcb)->producer_index), \

Same story here as Daniel pointed out for the BPF patch.

There are 2 macros right below here which also have a semicolon at the end. And these ones are used. So the patch appears to be pretty arbitrary.

I will add the other macros in the next revision.

Sorry,

Tom

Quoted 1 line