Skip to contentSkip to conversation

net: cisco: remove trailing semicolon in macro definition

PATCH In review [email protected] 3 participants 3 messages Nov 27, 2020 – Dec 2, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: cisco: remove trailing semicolon in macro definition

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/net/wireless/cisco/airo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/cisco/airo.c +1 -1
index 74acf9af2adb..ba62bb2995d9 100644
@@ -5785,7 +5785,7 @@ static int airo_get_quality (StatusRid *status_rid, CapabilityRid *cap_rid)
 }
 
 #define airo_get_max_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x20 : 0xa0)
-#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50);
+#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50)
 
 /*------------------------------------------------------------------*/
 /*
Signature · 1 line
2.18.4
Reviewed-by on v1 1/1
#1 lore raw

Hi Tom,

Quoted 5 lines · On 27/11/2020 17:58, [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

Seems to be the only occurrence in this file.

Quoted 18 lines
---
 drivers/net/wireless/cisco/airo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/cisco/airo.c +1 -1
index 74acf9af2adb..ba62bb2995d9 100644
@@ -5785,7 +5785,7 @@ static int airo_get_quality (StatusRid *status_rid, CapabilityRid *cap_rid)
 }
 
 #define airo_get_max_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x20 : 0xa0)
-#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50);
+#define airo_get_avg_quality(cap_rid) (memcmp((cap_rid)->prodName, "350", 3) ? 0x10 : 0x50)
 
 /*------------------------------------------------------------------*/
 /*
#2 lore raw

Re: airo: remove trailing semicolon in macro definition

In reply to [email protected]
Quoted 6 lines · [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

Patch applied to wireless-drivers-next.git, thanks.

a460b0e1bab8 airo: remove trailing semicolon in macro definition

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches