hwmon: corsair-psu: update supported devices
Wilken Gottwalt
maintainerPATCH 1/1 hwmon: corsair-psu: update supported devices
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver update
--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)
Documentation/hwmon/corsair-psu.rst +10 -0
@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650i
drivers/hwmon/Kconfig +4 -3
@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.
drivers/hwmon/corsair-psu.c +22 -11
@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2 +* are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen with +* these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first PSU of +* this series which has an unique usb hid id. Though, the actual device name is part of +* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + {HID_USB_DEVICE (0x1B1C ,0x1C00 ) },/* Corsair Link USB/COM Dongle rev1 */ + {HID_USB_DEVICE (0x1B1C ,0x1C01 ) },/* Corsair Link USB/COM Dongle rev2 */ + {HID_USB_DEVICE (0x1B1C ,0x1C02 ) },/* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + {HID_USB_DEVICE (0x1B1C ,0x1C03 ) },/* Corsair HX550i */ + {HID_USB_DEVICE (0x1B1C ,0x1C04 ) },/* Corsair HX650i */ + {HID_USB_DEVICE (0x1B1C ,0x1C05 ) },/* Corsair HX750i */ + {HID_USB_DEVICE (0x1B1C ,0x1C06 ) },/* Corsair HX850i */ + {HID_USB_DEVICE (0x1B1C ,0x1C07 ) },/* Corsair HX1000i */ + {HID_USB_DEVICE (0x1B1C ,0x1C08 ) },/* Corsair HX1200i */ + {HID_USB_DEVICE (0x1B1C ,0x1C09 ) },/* Corsair RM550i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0A ) },/* Corsair RM650i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0B ) },/* Corsair RM750i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0C ) },/* Corsair RM850i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0D ) },/* Corsair RM1000i */ + {HID_USB_DEVICE (0x1B1C ,0x1C11 ) },/* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable);
Signature · 1 line
2.29.2
Quoted 12 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
Quoted 5 lines
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>
Applied.
Thanks,
Guenter
Quoted 91 lines
--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +22
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2 +* are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen with +* these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first PSU of +* this series which has an unique usb hid id. Though, the actual device name is part of +* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + {HID_USB_DEVICE (0x1B1C ,0x1C00 ) },/* Corsair Link USB/COM Dongle rev1 */ + {HID_USB_DEVICE (0x1B1C ,0x1C01 ) },/* Corsair Link USB/COM Dongle rev2 */ + {HID_USB_DEVICE (0x1B1C ,0x1C02 ) },/* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + {HID_USB_DEVICE (0x1B1C ,0x1C03 ) },/* Corsair HX550i */ + {HID_USB_DEVICE (0x1B1C ,0x1C04 ) },/* Corsair HX650i */ + {HID_USB_DEVICE (0x1B1C ,0x1C05 ) },/* Corsair HX750i */ + {HID_USB_DEVICE (0x1B1C ,0x1C06 ) },/* Corsair HX850i */ + {HID_USB_DEVICE (0x1B1C ,0x1C07 ) },/* Corsair HX1000i */ + {HID_USB_DEVICE (0x1B1C ,0x1C08 ) },/* Corsair HX1200i */ + {HID_USB_DEVICE (0x1B1C ,0x1C09 ) },/* Corsair RM550i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0A ) },/* Corsair RM650i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0B ) },/* Corsair RM750i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0C ) },/* Corsair RM850i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0D ) },/* Corsair RM1000i */ + {HID_USB_DEVICE (0x1B1C ,0x1C11 ) },/* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable);
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
AXi dongle:
- https://github.com/ka87/cpsumon
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLink
- https://github.com/notaz/corsairmi
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Thanks,
Jonas
[1] https://github.com/ka87/cpsumon/issues/4
Quoted 104 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +22
-12@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2 +* are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen with +* these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first PSU of +* this series which has an unique usb hid id. Though, the actual device name is part of +* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + {HID_USB_DEVICE (0x1B1C ,0x1C00 ) },/* Corsair Link USB/COM Dongle rev1 */ + {HID_USB_DEVICE (0x1B1C ,0x1C01 ) },/* Corsair Link USB/COM Dongle rev2 */ + {HID_USB_DEVICE (0x1B1C ,0x1C02 ) },/* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + {HID_USB_DEVICE (0x1B1C ,0x1C03 ) },/* Corsair HX550i */ + {HID_USB_DEVICE (0x1B1C ,0x1C04 ) },/* Corsair HX650i */ + {HID_USB_DEVICE (0x1B1C ,0x1C05 ) },/* Corsair HX750i */ + {HID_USB_DEVICE (0x1B1C ,0x1C06 ) },/* Corsair HX850i */ + {HID_USB_DEVICE (0x1B1C ,0x1C07 ) },/* Corsair HX1000i */ + {HID_USB_DEVICE (0x1B1C ,0x1C08 ) },/* Corsair HX1200i */ + {HID_USB_DEVICE (0x1B1C ,0x1C09 ) },/* Corsair RM550i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0A ) },/* Corsair RM650i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0B ) },/* Corsair RM750i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0C ) },/* Corsair RM850i */ + {HID_USB_DEVICE (0x1B1C ,0x1C0D ) },/* Corsair RM1000i */ + {HID_USB_DEVICE (0x1B1C ,0x1C11 ) },/* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Wilken Gottwalt
maintainerQuoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
Quoted 2 lines
AXi dongle:
- https://github.com/ka87/cpsumon
This tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLink
This tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
Quoted 1 line
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit b9326057a3d8447f5d2e74a7b521ccf21add2ec0 actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.
Quoted 4 lines
Thanks,
Jonas
Yes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
Wilken
Quoted 106 lines
Quoted 106 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
drivers/hwmon/corsair-psu.c +2
-0+* are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen with +* these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first PSU of
drivers/hwmon/corsair-psu.c +18
-1+* this series which has an unique usb hid id. Though, the actual device name is part of +* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The corsairlink_driver_dongle has no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]
I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106
Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
Thanks again,
Jonas
Quoted 125 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 106 lines
Quoted 106 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
drivers/hwmon/corsair-psu.c +2
-0+* are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen with +* these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first PSU of
drivers/hwmon/corsair-psu.c +18
-1+* this series which has an unique usb hid id. Though, the actual device name is part of +* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Wilken Gottwalt
maintainerQuoted 90 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.
Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Guenter, what would you suggest?
Quoted 131 lines
Thanks again,
JonasQuoted 127 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 108 lines
Quoted 108 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen
with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first
PSU of
+ * this series which has an unique usb hid id. Though, the actual device name is
part ofdrivers/hwmon/corsair-psu.c +17
-1+* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Guenter Roeck
maintainerQuoted 105 lines · Wilken Gottwalt
Quoted 90 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Quoted 2 lines
Guenter, what would you suggest?
I'd suggest to remove it completely, and explain the reason. Anything else will just create trouble with people demanding to know why their power supply is not supported even though it is listed as supported. And, believe me, you don't want to be on the receiving side of those complaints. The Internet is much less friendly nowadays than it used to be.
Guenter
Quoted 132 lines
Quoted 131 lines
Thanks again,
JonasQuoted 127 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 108 lines
Quoted 108 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely seen
with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the first
PSU of
+ * this series which has an unique usb hid id. Though, the actual device name is
part ofdrivers/hwmon/corsair-psu.c +17
-1+* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3 (AX1500i) */ + { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Wilken Gottwalt
maintainerQuoted 106 lines · On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 105 lines · Wilken Gottwalt
Quoted 90 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Quoted 7 lines
Quoted 2 lines
Guenter, what would you suggest?
I'd suggest to remove it completely, and explain the reason. Anything else will just create trouble with people demanding to know why their power supply is not supported even though it is listed as supported. And, believe me, you don't want to be on the receiving side of those complaints. The Internet is much less friendly nowadays than it used to be.
So how is the procedure for this? Just revert it and make a common patch out of it with a proper explanation?
And yeah, I know exactly what you mean. I remember very well how the "internet" got it first ugly hit in the 90s with the upcoming of Flash ... and then the "social media". :D Thanks for your help.
greetings,
Wilken
Quoted 135 lines
Guenter
Quoted 133 lines
Quoted 132 lines
Thanks again,
JonasQuoted 128 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 109 lines
Quoted 109 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely
seen with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the
first PSU of
+ * this series which has an unique usb hid id. Though, the actual device name is
part ofdrivers/hwmon/corsair-psu.c +5
-0+* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3(AX1500i) */
drivers/hwmon/corsair-psu.c +12
-1+ { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Guenter Roeck
maintainerQuoted 117 lines · Wilken Gottwalt
Quoted 106 lines · On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 105 lines · Wilken Gottwalt
Quoted 90 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Quoted 7 lines
Quoted 2 lines
Guenter, what would you suggest?
I'd suggest to remove it completely, and explain the reason. Anything else will just create trouble with people demanding to know why their power supply is not supported even though it is listed as supported. And, believe me, you don't want to be on the receiving side of those complaints. The Internet is much less friendly nowadays than it used to be.
Quoted 7 lines
So how is the procedure for this? Just revert it and make a common patch out of it with a proper explanation?
And yeah, I know exactly what you mean. I remember very well how the "internet" got it first ugly hit in the 90s with the upcoming of Flash ... and then the "social media". :D Thanks for your help.
Can I just drop your previous patch and you send me another - more restrictive - one ?
Thanks,
Guenter
Quoted 139 lines
greetings,
WilkenQuoted 135 lines
Guenter
Quoted 133 lines
Quoted 132 lines
Thanks again,
JonasQuoted 128 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 109 lines
Quoted 109 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is rarely
seen with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the
first PSU of
+ * this series which has an unique usb hid id. Though, the actual device name is
part ofdrivers/hwmon/corsair-psu.c +5
-0+* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3(AX1500i) */
drivers/hwmon/corsair-psu.c +12
-1+ { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Wilken Gottwalt
maintainerQuoted 123 lines · On Sun, 29 Nov 2020 13:59:33 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 122 lines · Wilken Gottwalt
Quoted 108 lines · On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 107 lines · Wilken Gottwalt
Quoted 92 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2]
https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3]
https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Quoted 7 lines
Quoted 2 lines
Guenter, what would you suggest?
I'd suggest to remove it completely, and explain the reason. Anything else will just create trouble with people demanding to know why their power supply is not supported even though it is listed as supported. And, believe me, you don't want to be on the receiving side of those complaints. The Internet is much less friendly nowadays than it used to be.
So how is the procedure for this? Just revert it and make a common patch out of it with a proper explanation?
Quoted 7 lines
Quoted 4 lines
And yeah, I know exactly what you mean. I remember very well how the "internet" got it first ugly hit in the 90s with the upcoming of Flash ... and then the "social media". :D Thanks for your help.
Can I just drop your previous patch and you send me another - more restrictive - one ?
Yeah, dropping is fine. There is no need for another patch after that, this was a patch only dealing with the AXi series.
greetings,
Wilken
Quoted 142 lines
Thanks,
GuenterQuoted 139 lines
greetings,
WilkenQuoted 135 lines
Guenter
Quoted 133 lines
Quoted 132 lines
Thanks again,
JonasQuoted 128 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 109 lines
Quoted 109 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)(quoted diff) +0
-0
b/Documentation/hwmon/corsair-psu.rstindex396b95c9a76a..6227e9046d73100644Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is
rarely seen with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the
first PSU of
+ * this series which has an unique usb hid id. Though, the actual device
name is part ofdrivers/hwmon/corsair-psu.c +5
-0+* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3(AX1500i) */
drivers/hwmon/corsair-psu.c +12
-1+ { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Quoted 132 lines · Wilken Gottwalt
Quoted 128 lines · On Sun, 29 Nov 2020 13:59:33 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 126 lines · Wilken Gottwalt
Quoted 108 lines · On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 107 lines · Wilken Gottwalt
Quoted 92 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1] https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231
Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2]
https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3]
https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Quoted 7 lines
Quoted 2 lines
Guenter, what would you suggest?
I'd suggest to remove it completely, and explain the reason. Anything else will just create trouble with people demanding to know why their power supply is not supported even though it is listed as supported. And, believe me, you don't want to be on the receiving side of those complaints. The Internet is much less friendly nowadays than it used to be.
So how is the procedure for this? Just revert it and make a common patch out of it with a proper explanation?
And yeah, I know exactly what you mean. I remember very well how the "internet" got it first ugly hit in the 90s with the upcoming of Flash ... and then the "social media". :D Thanks for your help.
Quoted 5 lines
Quoted 2 lines
Can I just drop your previous patch and you send me another - more restrictive - one ?
Yeah, dropping is fine. There is no need for another patch after that, this was a patch only dealing with the AXi series.
And I'm sorry for throwing cold water at the patch.
Hopefully we'll find someone with one of these AXi PSUs once the RMi/HXi driver is widely available on distros.
Thanks,
Jonas
Quoted 146 lines
greetings,
WilkenQuoted 142 lines
Thanks,
GuenterQuoted 139 lines
greetings,
WilkenQuoted 135 lines
Guenter
Quoted 133 lines
Quoted 132 lines
Thanks again,
JonasQuoted 128 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 109 lines
Quoted 109 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)(quoted diff) +0
-0
b/Documentation/hwmon/corsair-psu.rstindex396b95c9a76a..6227e9046d73100644Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is
rarely seen with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i is the
first PSU of
+ * this series which has an unique usb hid id. Though, the actual device
name is part ofdrivers/hwmon/corsair-psu.c +5
-0+* the HID message protocol, so it doesn't matter which dongle is connected. +*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1 */ + { HID_USB_DEVICE(0x1B1C, 0x1C01) }, /* Corsair Link USB/COM Dongle rev2 */ + { HID_USB_DEVICE(0x1B1C, 0x1C02) }, /* Corsair Link USB/COM Dongle rev3(AX1500i) */
drivers/hwmon/corsair-psu.c +12
-1+ { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Wilken Gottwalt
maintainerQuoted 138 lines · On Mon, 30 Nov 2020 07:53:48 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 136 lines · Wilken Gottwalt
Quoted 131 lines · On Sun, 29 Nov 2020 13:59:33 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 120 lines · Wilken Gottwalt
Quoted 109 lines · On Sun, 29 Nov 2020 05:00:49 -0800 Guenter Roeck <[email protected]> wrote:
Quoted 108 lines · Wilken Gottwalt
Quoted 93 lines · On Sat, 28 Nov 2020 17:21:40 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 20 lines · Wilken Gottwalt
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 6 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
I think the similarities come from all using wrappers over the PMBus interface to the voltage controller. But I am not sure the wrapping protocols are identical.
For example, cpsumon shows significantly more things going on during a read than what is needed for the RMi/HXi series.[1]
[1]
https://github.com/ka87/cpsumon/blob/fd639684d7f9/libcpsumon/src/cpsumon.c#L213-L231Quoted 10 lines
Quoted 3 lines
AXi dongle:
- https://github.com/ka87/cpsumonThis tool made me to consider including the AX series, because it uses some of the same commands on the AX760i, AX860i, AX1200i and AX1500i. But it is a usb-serial tool only. But it was nice to know, that the commands are mostly the same. I left out all the commands for configuring, PCIe power rails, efficiency and others which do not really belong into hwmon.
Quoted 6 lines
Quoted 3 lines
RMi/HXi:
- https://github.com/jonasmalacofilho/liquidctl
- https://github.com/audiohacked/OpenCorsairLinkThis tool made me include the AX series, because it uses the rmi protocol component for the rmi driver (RM/HX series) and the corsair dongles.
The
corsairlink_driver_donglehas no implementations for reading sensor data (compare that with the corsairlink_driver_rmi).[2][3] There is also no code that actually tries to read (write) from (to) the device using that dongle driver.[4]I also looked at a few of the issues, and all of the ones I read mentioned AXi support being under development, and the hypothesis of the AXi series being compatible with the RMi/HXi code still remaining to be confirmed.
[2]
https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/dongle.c#L33-L39
[3]
https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/drivers/rmi.c#L33-L57
[4] https://github.com/audiohacked/OpenCorsairLink/blob/61d336a61b85/main.c#L106Quoted 10 lines
Quoted 2 lines
This one covers only some HX/RM PSUs, but is uses the rawhid access which made me looking up the actual usb chips/bridges Corsair uses.
Quoted 3 lines
One additional concern is that the non-HID AXi dongles may only have bulk USB endpoints, and this is a HID driver.[1]
Quoted 8 lines
You are right, in the case of the dongles it could be different. But I did some research on Corsair usb driven devices and they really like to stick to the cp210x, which is an usb hid bridge. The commit
b9326057a3d8447f5d2e74a7b521ccf21add2ec0actually covers two Corsair USB dongles as a cp210x device. So it is very likely that all Corsair PSUs with such an interface/dongle use usb hid. But I'm completely open to get proven wrong. Actually I really would like to see this tested by people who have access to the more rare devices.Quoted 2 lines
I could be wrong (and I am sorry for the noise if that is the case), but as far as I can see the cp210x does not create a HID device.
No no, this is fine. It really helps if some more people are looking into this. I wish I had access to at least one of the later models (AX1500i/AX1600i), I make mistakes from time to time. And it really doesn't help that Corsair changes single devices in the same product line by firmware update. The AX1600i seems to be the only one, which uses exactly the same protocol like the RM/HX series, but is missing the actual usb hid part. But there seems to be a firmware where the usb hid part was available for a short time. So, what to do? Remove the AXi part completely or keep only the AX1600i?
Quoted 7 lines
Quoted 2 lines
Guenter, what would you suggest?
I'd suggest to remove it completely, and explain the reason. Anything else will just create trouble with people demanding to know why their power supply is not supported even though it is listed as supported. And, believe me, you don't want to be on the receiving side of those complaints. The Internet is much less friendly nowadays than it used to be.
Quoted 7 lines
So how is the procedure for this? Just revert it and make a common patch out of it with a proper explanation?
And yeah, I know exactly what you mean. I remember very well how the "internet" got it first ugly hit in the 90s with the upcoming of Flash ... and then the "social media". :D Thanks for your help.
Can I just drop your previous patch and you send me another - more restrictive - one ?
Quoted 7 lines
Quoted 2 lines
Yeah, dropping is fine. There is no need for another patch after that, this was a patch only dealing with the AXi series.
And I'm sorry for throwing cold water at the patch.
Hopefully we'll find someone with one of these AXi PSUs once the RMi/HXi driver is widely available on distros.
This is absolutely fine. If a patch is nonsense, and if the AXi series has no usb hid support, than the patch is nonsense. So reverting is the right option.
greetings,
Wilken
Quoted 152 lines
Thanks,
JonasQuoted 149 lines
greetings,
WilkenQuoted 145 lines
Thanks,
GuenterQuoted 142 lines
greetings,
WilkenQuoted 138 lines
Guenter
Quoted 136 lines
Quoted 135 lines
Thanks again,
JonasQuoted 131 lines
Quoted 5 lines
Thanks,
JonasYes ... that one. The last revision of the dongle could indeed be a problem. But I'm not really sure what is described here. The last commenter is actually the one who provided the cp210x patch mentioned up there. The problem here is, the AX1500i has both connectors, USB and that other one. I call it the other one because it is the only PSU where it is labeled I2C COMM instead of COMM only. But at the same time this tools uses the same commands for this PSU.
So, only some real hardware tests will show.
Greetings,
WilkenQuoted 112 lines
Quoted 112 lines
The patch also changes the usb hid ids to use upper case letters to be consistent with the rest of the hex numbers in the driver and updates the hwmon documentation.
This patch adds:
- hwmon/corsair-psu documentation update
- corsair-psu driver updateSigned-off-by Wilken Gottwalt <[email protected]>--- Documentation/hwmon/corsair-psu.rst | 10 +++++++++ drivers/hwmon/Kconfig | 7 +++--- drivers/hwmon/corsair-psu.c | 33 +++++++++++++++++++---------- 3 files changed, 36 insertions(+), 14 deletions(-)(quoted diff) +0
-0
b/Documentation/hwmon/corsair-psu.rstindex396b95c9a76a..6227e9046d73100644Documentation/hwmon/corsair-psu.rst +10
-0@@ -7,6 +7,16 @@ Supported devices: * Corsair Power Supplies + Corsair AX760i (by Corsair Link USB Dongle) + + Corsair AX860i (by Corsair Link USB Dongle) + + Corsair AX1200i (by Corsair Link USB Dongle) + + Corsair AX1500i (by builtin Corsair Link USB Dongle) + + Corsair AX1600i + Corsair HX550i Corsair HX650idrivers/hwmon/Kconfig +4
-3@@ -453,11 +453,12 @@ config SENSORS_CORSAIR_PSU tristate "Corsair PSU HID controller" depends on HID help - If you say yes here you get support for Corsair PSUs with a HID + If you say yes here you get support for Corsair PSUs with an USB HID interface. Currently this driver supports the (RM/HX)550i, (RM/HX)650i, - (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i and HX1200i power supplies - by Corsair. + (RM/HX)750i, (RM/HX)850i, (RM/HX)1000i, HX1200i and AX1600i power + supplies by Corsair. The AX760i, AX860i, AX1200i and AX1500i + power supplies are supported through the Corsair Link USB Dongle. This driver can also be built as a module. If so, the module will be called corsair-psu.drivers/hwmon/corsair-psu.c +2
-11@@ -571,17 +571,28 @@ static int corsairpsu_raw_event(struct hid_device *hdev, struct hid_report *repo }static const struct hid_device_id corsairpsu_idtable[] = { - {HID_USB_DEVICE (0x1b1c ,0x1c03 ) },/* Corsair HX550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c04 ) },/* Corsair HX650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c05 ) },/* Corsair HX750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c06 ) },/* Corsair HX850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c07 ) },/* Corsair HX1000i */ - {HID_USB_DEVICE (0x1b1c ,0x1c08 ) },/* Corsair HX1200i */ - {HID_USB_DEVICE (0x1b1c ,0x1c09 ) },/* Corsair RM550i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0a ) },/* Corsair RM650i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0b ) },/* Corsair RM750i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0c ) },/* Corsair RM850i */ - {HID_USB_DEVICE (0x1b1c ,0x1c0d ) },/* Corsair RM1000i */ +/* +* The Corsair USB/COM Dongles appear in at least 3 different revisions, where rev 1 and 2
+ * are commonly used with the AX760i, AX860i and AX1200i, while rev3 is
rarely seen with
+ * these PSUs. Rev3 is also build into the AX1500i, while the AX1600i
is the first PSU of
+ * this series which has an unique usb hid id. Though, the actual device
name is part of
+ * the HID message protocol, so it doesn't matter which dongle is
connected.drivers/hwmon/corsair-psu.c +2
-0+*/ + { HID_USB_DEVICE(0x1B1C, 0x1C00) }, /* Corsair Link USB/COM Dongle rev1*/
+ {HID_USB_DEVICE(0x1B1C, 0x1C01)}, /* Corsair Link USB/COM Dongle rev2
*/
+ {HID_USB_DEVICE(0x1B1C, 0x1C02)}, /* Corsair Link USB/COM Dongle rev3
(AX1500i) */drivers/hwmon/corsair-psu.c +12
-1+ { HID_USB_DEVICE(0x1B1C, 0x1C03) }, /* Corsair HX550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C04) }, /* Corsair HX650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C05) }, /* Corsair HX750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C06) }, /* Corsair HX850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C07) }, /* Corsair HX1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C08) }, /* Corsair HX1200i */ + { HID_USB_DEVICE(0x1B1C, 0x1C09) }, /* Corsair RM550i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0A) }, /* Corsair RM650i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0B) }, /* Corsair RM750i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0C) }, /* Corsair RM850i */ + { HID_USB_DEVICE(0x1B1C, 0x1C0D) }, /* Corsair RM1000i */ + { HID_USB_DEVICE(0x1B1C, 0x1C11) }, /* Corsair AX1600i */ { }, };MODULE_DEVICE_TABLE (hid, corsairpsu_idtable); --2.29.2
Guenter Roeck
maintainerOn Mon, Nov 30, 2020 at 06:22:30AM +0100, Wilken Gottwalt wrote:
[ ... ]
Quoted 7 lines
Quoted 3 lines
Can I just drop your previous patch and you send me another - more restrictive - one ?
Yeah, dropping is fine. There is no need for another patch after that, this was a patch only dealing with the AXi series.
Done.
Thanks,
Guenter
Den 28.11.2020 kl. 12:35, skrev Wilken Gottwalt:
Quoted 19 lines
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 7 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
What kind of tests do you want / need ?
I have an AX860i here.
--
Regards
Thomas Backlund
Wilken Gottwalt
maintainerQuoted 28 lines · On Mon, 30 Nov 2020 14:43:44 +0200 Thomas Backlund <[email protected]> wrote:
Den 28.11.2020 kl. 12:35, skrev Wilken Gottwalt:
Quoted 19 lines
Quoted 11 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 8 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
Quoted 7 lines
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
Quoted 3 lines
What kind of tests do you want / need ?
I have an AX860i here.
Oh nice. Lets start with an usb info dump. Can you give me the full dump of lsusb -vd <device> of the Corsair USB dongle?
greetings,
Wilken
Quoted 5 lines
--
RegardsThomas Backlund
Den 30.11.2020 kl. 16:49, skrev Wilken Gottwalt:
Quoted 27 lines
Quoted 24 lines · On Mon, 30 Nov 2020 14:43:44 +0200 Thomas Backlund <[email protected]> wrote:
Den 28.11.2020 kl. 12:35, skrev Wilken Gottwalt:
Quoted 23 lines
Quoted 9 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 7 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
Quoted 5 lines
Quoted 3 lines
What kind of tests do you want / need ?
I have an AX860i here.
Oh nice. Lets start with an usb info dump. Can you give me the full dump of lsusb -vd <device> of the Corsair USB dongle?
$ lsusb -vd 1b1c:1c00
Bus 011 Device 005: ID 1b1c:1c00 Corsair Controller for Corsair Link Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 1.10
bDeviceClass 0
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
idVendor 0x1b1c Corsair
idProduct 0x1c00 Controller for Corsair Link bcdDevice 1.00
iManufacturer 1 Silicon Labs
iProduct 2 Corsair Link TM USB Dongle iSerial 3 R7480347
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 0x0020
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 100mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 0
bInterfaceProtocol 0
iInterface 2 Corsair Link TM USB Dongle Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
can't get debug descriptor: Resource temporarily unavailable Device Status: 0x0000
(Bus Powered)
--
Thomas
Wilken Gottwalt
maintainerQuoted 87 lines · On Mon, 30 Nov 2020 18:25:30 +0200 Backlund Thomas <[email protected]> wrote:
Den 30.11.2020 kl. 16:49, skrev Wilken Gottwalt:
Quoted 27 lines
Quoted 24 lines · On Mon, 30 Nov 2020 14:43:44 +0200 Thomas Backlund <[email protected]> wrote:
Den 28.11.2020 kl. 12:35, skrev Wilken Gottwalt:
Quoted 23 lines
Quoted 9 lines · On Sat, 28 Nov 2020 02:37:38 -0300 Jonas Malaco <[email protected]> wrote:
Quoted 7 lines · Wilken Gottwalt
Adds support for another Corsair PSUs series: AX760i, AX860i, AX1200i, AX1500i and AX1600i. The first 3 power supplies are supported through the Corsair Link USB Dongle which is some kind of USB/Serial/TTL converter especially made for the COM ports of these power supplies. There are 3 known revisions of these adapters. The AX1500i power supply has revision 3 built into the case and AX1600i is the only one in that series, which has an unique usb hid id like the RM/RX series.
Quoted 4 lines
Can I ask what AXi power supplies were tested?
I ask because, based on the user-space implementations I am aware of, the AXi dongle protocol appears to be different from the RMi/HXi series.
I was not able to test this against the AX power supplies, they are really hard to find (and are far to expensive). But I went through all these tools and stuck to the most common commands, which all 3 series support. Not every series supports all commands (there also seem to be different firmwares in the micro-conrollers). But this is fine, some sensors will show up as N/A. Even my HX850i does not support all commands covered in this driver.
Quoted 5 lines
Quoted 3 lines
What kind of tests do you want / need ?
I have an AX860i here.
Oh nice. Lets start with an usb info dump. Can you give me the full dump of lsusb -vd <device> of the Corsair USB dongle?
$ lsusb -vd 1b1c:1c00Bus 011 Device 005: ID 1b1c:1c00 Corsair Controller for Corsair Link Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 1.10
bDeviceClass 0
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
idVendor0x1b1cCorsair
idProduct0x1c00Controller for Corsair Link bcdDevice 1.00
iManufacturer 1 Silicon Labs
iProduct 2 Corsair Link TM USB Dongle iSerial 3 R7480347
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength0x0020
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 0
bmAttributes0x80
(Bus Powered)
MaxPower 100mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 0
bInterfaceProtocol 0
iInterface 2 Corsair Link TM USB Dongle Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Quoted 8 lines
Transfer Type Bulk
Synch Type None
Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0
can't get debug descriptor: Resource temporarily unavailable Device Status:0x0000
(Bus Powered)
Thank you. Hmm yeah, this dongle has no usb hid part. So this driver will not work with this dongle for sure. I already have an idea how to support all 3 series, though it involves a lot of testing. I would provide a github repo with tools and test kernel modules if you are interested. But I don't know yet how long it will take, I work on other stuff which has a higher prio.
greetings,
Wilken
Quoted 5 lines
--
Thomas
Den 01.12.2020 kl. 09:24, skrev Wilken Gottwalt:
Quoted 6 lines
Thank you. Hmm yeah, this dongle has no usb hid part. So this driver will not work with this dongle for sure. I already have an idea how to support all 3 series, though it involves a lot of testing. I would provide a github repo with tools and test kernel modules if you are interested. But I don't know yet how long it will take, I work on other stuff which has a higher prio.
Yes, I'm interested...
Just drop me a note when you have something to test.
--
Thomas