Skip to contentSkip to conversation

package/lynx: fix reproducible build issues

PATCH New Peter Korsgaard 1 participant 3 messages Nov 29, 2020 – Dec 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lynx: fix reproducible build issues

Fixes (part of) http://autobuild.buildroot.net/results/23fe4365ca65f37eace8265a70fbfb9723b8ee9d/

Lynx by default contains logic to generate a "configuration info" HTML page, which leaks build paths, and adds the build timestamp to the version output. Disable both when building in reproducible mode.

---
 package/lynx/lynx.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
package/lynx/lynx.mk +8 -1
index 07a3ddfcf0..d115682d64 100644
@@ -12,6 +12,13 @@ LYNX_LICENSE_FILES = COPYING
 
 LYNX_DEPENDENCIES = host-pkgconf $(TARGET_NLS_DEPENDENCIES)
 
+ifeq ($(BR2_REPRODUCIBLE),y)
+# configuration info leaks build paths
+LYNX_CONF_OPTS += --disable-config-info
+# disable build timestamp
+LYNX_CFLAGS += -DNO_BUILDSTAMP
+endif
+
 ifeq ($(BR2_PACKAGE_NCURSES),y)
 LYNX_DEPENDENCIES += ncurses
 LYNX_CONF_OPTS += --with-screen=ncurses$(if $(BR2_PACKAGE_NCURSES_WCHAR),w)
@@ -41,6 +48,6 @@ LYNX_DEPENDENCIES += libidn
 LYNX_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libidn`
 endif
 
-LYNX_CONF_ENV = LIBS="$(LYNX_LIBS)"
+LYNX_CONF_ENV = LIBS="$(LYNX_LIBS)" CFLAGS="$(TARGET_CFLAGS) $(LYNX_CFLAGS)"
 
 $(eval $(autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/lynx: fix reproducible build issues

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes (part of) http://autobuild.buildroot.net/results/23fe4365ca65f37eace8265a70fbfb9723b8ee9d/
Lynx by default contains logic to generate a "configuration info" HTML page, which leaks build paths, and adds the build timestamp to the version output. Disable both when building in reproducible mode.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/lynx: fix reproducible build issues

In reply to Peter Korsgaard
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes (part of) http://autobuild.buildroot.net/results/23fe4365ca65f37eace8265a70fbfb9723b8ee9d/
Lynx by default contains logic to generate a "configuration info" HTML page, which leaks build paths, and adds the build timestamp to the version output. Disable both when building in reproducible mode.

Committed to 2020.02.x and 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard