Skip to contentSkip to conversation

drm/amdgpu: fix compiler warnings

PATCH In review Wayne Lin 2 participants 2 messages Nov 30, 2020

lore
Share & tools
lore

Wayne Lin

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix compiler warnings

Fixes below compiler warnings:

All warnings (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5:

warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,

       ^

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:1:
note: declare 'static' if the function is not intended to be used outside of this translation unit
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, ^
static

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:5:

warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,

       ^

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:1:
note: declare 'static' if the function is not intended to be used outside of this translation unit
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc, ^
static
2 warnings generated.

---
 amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
amdgpu_dm/amdgpu_dm.c +2 -2
index 1818d9392..f42046d04 100644
@@ -4975,7 +4975,7 @@ dm_crtc_duplicate_state(struct drm_crtc *crtc)
 }
 
 #ifdef CONFIG_DEBUG_FS
-int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
+static int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
 					    struct drm_crtc_state *crtc_state,
 					    struct drm_property *property,
 					    uint64_t val)
@@ -4999,7 +4999,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
 	return 0;
 }
 
-int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
+static int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
 					    const struct drm_crtc_state *state,
 					    struct drm_property *property,
 					    uint64_t *val)
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 59 lines · Wayne Lin

Fixes below compiler warnings:

All warnings (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:5:

warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_set_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,

       ^

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5374:1:
note: declare 'static' if the function is not intended to be used outside of this translation unit
int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc, ^
static

Quoted 1 line
Quoted 1 line

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:5:

warning: no previous prototype for function 'amdgpu_dm_crtc_atomic_get_property' [-Wmissing-prototypes]
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,

       ^

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5398:1:
note: declare 'static' if the function is not intended to be used outside of this translation unit
int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc, ^
static
2 warnings generated.

---
 amdgpu_dm/amdgpu_dm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
amdgpu_dm/amdgpu_dm.c +2 -2
index 1818d9392..f42046d04 100644
@@ -4975,7 +4975,7 @@ dm_crtc_duplicate_state(struct drm_crtc *crtc)
 }
 
 #ifdef CONFIG_DEBUG_FS
-int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
+static int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
 					    struct drm_crtc_state *crtc_state,
 					    struct drm_property *property,
 					    uint64_t val)
@@ -4999,7 +4999,7 @@ int amdgpu_dm_crtc_atomic_set_property(struct drm_crtc *crtc,
 	return 0;
 }
 
-int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
+static int amdgpu_dm_crtc_atomic_get_property(struct drm_crtc *crtc,
 					    const struct drm_crtc_state *state,
 					    struct drm_property *property,
 					    uint64_t *val)
Signature · 1 line
2.17.1
Signature · 2 lines
Rodrigo Siqueira
https://siqueira.tech

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx