habanalabs: put devices before driver removal
PATCH 1/1 habanalabs: put devices before driver removal
From: Ofir Bitton <[email protected]>
Driver never puts its device and control_device objects, hence a memory leak is introduced every driver removal.
Signed-off-by Ofir Bitton <[email protected]>
Reviewed-by Oded Gabbay <[email protected]>
Signed-off-by Oded Gabbay <[email protected]>
--- drivers/misc/habanalabs/common/device.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/misc/habanalabs/common/device.c +8 -8
@@ -231,16 +231,16 @@ static int device_cdev_sysfs_add(struct hl_device *hdev)static void device_cdev_sysfs_del (struct hl_device *hdev) { -/* device_release() won't be called so must free devices explicitly */ -if (!hdev->cdev_sysfs_created) { -kfree (hdev->dev_ctrl); -kfree (hdev->dev); -return ; - } +if (!hdev->cdev_sysfs_created) + goto put_devices;hl_sysfs_fini (hdev);cdev_device_del (&hdev->cdev_ctrl, hdev->dev_ctrl);cdev_device_del (&hdev->cdev, hdev->dev); + +put_devices: +put_device (hdev->dev); +put_device (hdev->dev_ctrl); }/*
@@ -1371,9 +1371,9 @@ int hl_device_init(struct hl_device *hdev, struct class *hclass) early_fini:device_early_fini (hdev); free_dev_ctrl: -kfree (hdev->dev_ctrl); +put_device (hdev->dev_ctrl); free_dev: -kfree (hdev->dev); +put_device (hdev->dev); out_disabled: hdev->disabled = true;if (add_cdev_sysfs_on_err)
Signature · 1 line
2.17.1