dm crypt: export sysfs of kcryptd workqueue
PATCH 1/1 dm crypt: export sysfs of kcryptd workqueue
It should be helpful to export sysfs of "kcryptd" workqueue in some cases, such as setting specific CPU affinity of the workqueue.
Besides, also tweak the name format a little. The slash inside a directory name will be translate into exclamation mark, such as /sys/devices/virtual/workqueue/'kcryptd!253:0'.
--- drivers/md/dm-crypt.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/md/dm-crypt.c +4 -3
@@ -3166,11 +3166,12 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv) }if (test_bit (DM_CRYPT_SAME_CPU , &cc->flags)) - cc->crypt_queue =alloc_workqueue ("kcryptd/%s" ,WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM , + cc->crypt_queue =alloc_workqueue ("kcryptd-%s" ,WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM ,1 , devname);else - cc->crypt_queue =alloc_workqueue ("kcryptd/%s" , -WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM |WQ_UNBOUND , + cc->crypt_queue =alloc_workqueue ("kcryptd-%s" , +WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM | +WQ_UNBOUND |WQ_SYSFS ,num_online_cpus (), devname);if (!cc->crypt_queue) { ti->error ="Couldn't create kcryptd queue" ;
Signature · 6 lines
2.27.0 -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Hi Mike,
What about this patch?
Quoted 33 lines · Jeffle Xu
It should be helpful to export sysfs of "kcryptd" workqueue in some cases, such as setting specific CPU affinity of the workqueue.
Besides, also tweak the name format a little. The slash inside a directory name will be translate into exclamation mark, such as /sys/devices/virtual/workqueue/'kcryptd!253:0'.
Signed-off-by Jeffle Xu <[email protected]>--- drivers/md/dm-crypt.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/md/dm-crypt.c +4
-3@@ -3166,11 +3166,12 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv) }if (test_bit (DM_CRYPT_SAME_CPU , &cc->flags)) - cc->crypt_queue =alloc_workqueue ("kcryptd/%s" ,WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM , + cc->crypt_queue =alloc_workqueue ("kcryptd-%s" ,WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM ,1 , devname);else - cc->crypt_queue =alloc_workqueue ("kcryptd/%s" , -WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM |WQ_UNBOUND , + cc->crypt_queue =alloc_workqueue ("kcryptd-%s" , +WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM | +WQ_UNBOUND |WQ_SYSFS ,num_online_cpus (), devname);if (!cc->crypt_queue) { ti->error ="Couldn't create kcryptd queue" ;
Signature · 7 lines
Thanks, Jeffle -- dm-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/dm-devel
Quoted 24 lines · JeffleXu
Hi Mike,
What about this patch?
Quoted 19 lines · Jeffle Xu
It should be helpful to export sysfs of "kcryptd" workqueue in some cases, such as setting specific CPU affinity of the workqueue.
Besides, also tweak the name format a little. The slash inside a directory name will be translate into exclamation mark, such as /sys/devices/virtual/workqueue/'kcryptd!253:0'.
Signed-off-by Jeffle Xu <[email protected]>--- drivers/md/dm-crypt.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)drivers/md/dm-crypt.c +0
-0@@ -3166,11 +3166,12 @@ static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv) }
Quoted 14 lines
Quoted 4 lines
drivers/md/dm-crypt.c +1
-1if (test_bit (DM_CRYPT_SAME_CPU , &cc->flags)) - cc->crypt_queue = alloc_workqueue("kcryptd/%s", WQ_CPU_INTENSIVE | WQ_MEM_RECLAIM, + cc->crypt_queue = alloc_workqueue("kcryptd-%s", WQ_CPU_INTENSIVE | WQ_MEM_RECLAIM,drivers/md/dm-crypt.c static int crypt_ctr(struct dm_target *ti, unsigned int argc, char **argv) · line 3177
Quoted 10 lines
drivers/md/dm-crypt.c +3
-21, devname); else - cc->crypt_queue = alloc_workqueue("kcryptd/%s", -WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM |WQ_UNBOUND , + cc->crypt_queue = alloc_workqueue("kcryptd-%s", +WQ_CPU_INTENSIVE |WQ_MEM_RECLAIM | +WQ_UNBOUND |WQ_SYSFS ,num_online_cpus (), devname);if (!cc->crypt_queue) { ti->error ="Couldn't create kcryptd queue" ;
Looks fine, I'll get it staged for 5.11.
Mike
--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel