Skip to contentSkip to conversation

devlink: Extend man page for port function set command

PATCH Superseded Parav Pandit 2 participants 6 messages Nov 30, 2020 – Jan 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devlink: Extend man page for port function set command

Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute.

---
 man/man8/devlink-port.8 | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
man/man8/devlink-port.8 +21 -0
index 966faae6..7e2dc110 100644
@@ -46,6 +46,12 @@ devlink-port \- devlink port configuration
 .ti -8
 .B devlink port help
 
+.ti -8
+.BR "devlink port function set "
+.RI "[ "
+.BR "hw_addr "
+.RI "ADDR ]"
+
 .SH "DESCRIPTION"
 .SS devlink port set - change devlink port attributes
 
@@ -99,6 +105,16 @@ If this argument is omitted all ports are listed.
 Is an alias for
 .BR devlink-health (8).
 
+.SS devlink port function set - Set the port function attribute.
+
+.PP
+.B "DEV/PORT_INDEX"
+- specifies the devlink port to operate on.
+
+.PP
+.BI hw_addr " ADDR"
+- hardware address of the function to set.
+
 .SH "EXAMPLES"
 .PP
 devlink port show
@@ -135,6 +151,11 @@ devlink port health show pci/0000:01:00.0/1 reporter tx
 .RS 4
 Shows status and configuration of tx reporter registered on pci/0000:01:00.0/1 devlink port.
 .RE
+.PP
+devlink port function set pci/0000:01:00.0/1 hw_addr 00:00:00:11:22:33
+.RS 4
+Configure hardware address of the PCI function represented by devlink port.
+.RE
 
 .SH SEE ALSO
 .BR devlink (8),
Signature · 1 line
2.26.2
#1 lore raw
Quoted 14 lines · Parav Pandit

Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute.

---
 man/man8/devlink-port.8 | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
man/man8/devlink-port.8 +0 -0
index 966faae6..7e2dc110 100644

man/man8/devlink-port.8 devlink-port \- devlink port configuration · line 50

Quoted 5 lines
man/man8/devlink-port.8 +2 -0
@@ -46,6 +46,12 @@ devlink-port \- devlink port configuration
 .ti -8
 .B devlink port help
 
+.ti -8
+.BR "devlink port function set "

The command exists in iproute2 main branch correct?

#2 lore raw
Quoted 22 lines

From: David Ahern <[email protected]>
Sent: Thursday, December 3, 2020 9:12 AM

Quoted 16 lines · Parav Pandit

Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute.

---
 man/man8/devlink-port.8 | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
man/man8/devlink-port.8 index renamed from man/man8/devlink-port.8 +0 -0

966faae6..7e2dc110 100644

man/man8/devlink-port.8 +0 -0
@@ -46,6 +46,12 @@ devlink-port \- devlink port configuration  .ti -8

.B devlink port help

Quoted 4 lines
Quoted 2 lines

+.ti -8
+.BR "devlink port function set "

The command exists in iproute2 main branch correct?

Yes, you are correct.

#3 lore raw

PATCH RESEND 1/1 devlink: Extend man page for port function set command

In reply to Parav Pandit

Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute.

---
 man/man8/devlink-port.8 | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
man/man8/devlink-port.8 +21 -0
index 966faae6..7e2dc110 100644
@@ -46,6 +46,12 @@ devlink-port \- devlink port configuration
 .ti -8
 .B devlink port help
 
+.ti -8
+.BR "devlink port function set "
+.RI "[ "
+.BR "hw_addr "
+.RI "ADDR ]"
+
 .SH "DESCRIPTION"
 .SS devlink port set - change devlink port attributes
 
@@ -99,6 +105,16 @@ If this argument is omitted all ports are listed.
 Is an alias for
 .BR devlink-health (8).
 
+.SS devlink port function set - Set the port function attribute.
+
+.PP
+.B "DEV/PORT_INDEX"
+- specifies the devlink port to operate on.
+
+.PP
+.BI hw_addr " ADDR"
+- hardware address of the function to set.
+
 .SH "EXAMPLES"
 .PP
 devlink port show
@@ -135,6 +151,11 @@ devlink port health show pci/0000:01:00.0/1 reporter tx
 .RS 4
 Shows status and configuration of tx reporter registered on pci/0000:01:00.0/1 devlink port.
 .RE
+.PP
+devlink port function set pci/0000:01:00.0/1 hw_addr 00:00:00:11:22:33
+.RS 4
+Configure hardware address of the PCI function represented by devlink port.
+.RE
 
 .SH SEE ALSO
 .BR devlink (8),
Signature · 1 line
2.26.2
#4 lore raw

Hi Stephen,

Quoted 8 lines

From: Parav Pandit <[email protected]>
Sent: Friday, January 22, 2021 10:32 AM

Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute.

Can you please review this short update?

Quoted 51 lines
---
 man/man8/devlink-port.8 | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
man/man8/devlink-port.8 index renamed from man/man8/devlink-port.8 +0 -0

966faae6..7e2dc110 100644

man/man8/devlink-port.8 +0 -0
@@ -46,6 +46,12 @@ devlink-port \- devlink port configuration  .ti -8  .B

devlink port help

+.ti -8
+.BR "devlink port function set "
+.RI "[ "
+.BR "hw_addr "
+.RI "ADDR ]"

man/man8/devlink-port.8 +11 -0
+
 .SH "DESCRIPTION"
 .SS devlink port set - change devlink port attributes
@@ -99,6 +105,16 @@ If this argument is omitted all ports are listed.
 Is an alias for
 .BR devlink-health (8).
 
+.SS devlink port function set - Set the port function attribute.
+
+.PP
+.B "DEV/PORT_INDEX"
+- specifies the devlink port to operate on.
+
+.PP
+.BI hw_addr " ADDR"
+- hardware address of the function to set.
+
 .SH "EXAMPLES"
 .PP
 devlink port show
@@ -135,6 +151,11 @@ devlink port health show pci/0000:01:00.0/1 reporter

tx .RS 4 Shows status and configuration of tx reporter registered on pci/0000:01:00.0/1 devlink port.
.RE
+.PP

man/man8/devlink-port.8 +4 -1
+devlink port function set pci/0000:01:00.0/1 hw_addr 00:00:00:11:22:33
+.RS 4 Configure hardware address of the PCI function represented by
+devlink port.
+.RE
 
 .SH SEE ALSO
 .BR devlink (8),
--

2.26.2

#5 lore raw

Hi David, Stephen,

Quoted 8 lines

From: Parav Pandit <[email protected]>
Sent: Tuesday, January 26, 2021 6:54 PM

Hi Stephen,

Quoted 3 lines

From: Parav Pandit <[email protected]>
Sent: Friday, January 22, 2021 10:32 AM

Quoted 7 lines
Quoted 5 lines

Extended devlink-port man page for synopsis, description and example for setting devlink port function attribute.

Can you please review this short update?

Please discard this patch, I am sending the subfunction patches and this piece is covered in it now.