Skip to contentSkip to conversation

ASoC: adau1372: add missing dependencies

PATCH In review Alexandre Belloni 2 participants 3 messages Nov 30, 2020 – Dec 1, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: adau1372: add missing dependencies

SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP config they need but forget to depend on the underlying bus.

---
 sound/soc/codecs/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/Kconfig +2 -0
index a457300f95da..625f762903ea 100644
@@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
 
 config SND_SOC_ADAU1372_I2C
 	tristate "Analog Devices ADAU1372 CODEC (I2C)"
+	depends on I2C
 	select SND_SOC_ADAU1372
 	select REGMAP_I2C
 
 config SND_SOC_ADAU1372_SPI
 	tristate "Analog Devices ADAU1372 CODEC (SPI)"
+	depends on SPI
 	select SND_SOC_ADAU1372
 	select REGMAP_SPI
 
Signature · 1 line
2.28.0
#1 lore raw
Quoted 4 lines · Alexandre Belloni

SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP config they need but forget to depend on the underlying bus.

I forgot:

Quoted 25 lines
---
 sound/soc/codecs/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/codecs/Kconfig +2 -0
index a457300f95da..625f762903ea 100644
@@ -371,11 +371,13 @@ config SND_SOC_ADAU1372
 
 config SND_SOC_ADAU1372_I2C
 	tristate "Analog Devices ADAU1372 CODEC (I2C)"
+	depends on I2C
 	select SND_SOC_ADAU1372
 	select REGMAP_I2C
 
 config SND_SOC_ADAU1372_SPI
 	tristate "Analog Devices ADAU1372 CODEC (SPI)"
+	depends on SPI
 	select SND_SOC_ADAU1372
 	select REGMAP_SPI
 
Signature · 1 line
2.28.0
Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer
#2 lore raw
In reply to Alexandre Belloni
Quoted 2 lines · Alexandre Belloni

SND_SOC_ADAU1372_I2C and SND_SOC_ADAU1372_SPI prpoerly select the REGMAP config they need but forget to depend on the underlying bus.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: adau1372: add missing dependencies
(no commit info)

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark