Skip to contentSkip to conversation

dt-bindings: soc: imx: Add binding doc for spba bus

PATCH Applied Adam Ford 3 participants 7 messages Nov 18, 2020 – Nov 20, 2021 Device tree bindings

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v5 1/1 dt-bindings: soc: imx: Add binding doc for spba bus

Add binding doc for fsl,spba-bus.

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

V4: Remove an accidental makefile change
Move type:object under additional properties

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml new file +68 -0
new file mode 100644
index 000000000000..e9f77ecae3d3
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/fsl,spba-bus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Shared Peripherals Bus Interface
+
+maintainers:
+  - Shawn Guo <[email protected]>
+
+description: |
+  A simple bus enabling access to shared peripherals.
+
+  The "spba-bus" follows the "simple-bus" set of properties, as
+  specified in the Devicetree Specification.  It is an extension of
+  "simple-bus" because the SDMA controller uses this compatible flag to
+  determine which peripherals are available to it and the range over which
+  the SDMA can access.  There are no special clocks for the bus, because
+  the SDMA controller itself has its interrupt, and clock assignments.
+
+select:
+  properties:
+    compatible:
+      contains:
+        const: fsl,spba-bus
+  required:
+    - compatible
+
+properties:
+  $nodename:
+    pattern: "^bus(@[0-9a-f]+)?$"
+
+  compatible:
+    items:
+      - const: fsl,spba-bus
+      - const: simple-bus
+
+  '#address-cells':
+    enum: [ 1, 2 ]
+
+  '#size-cells':
+    enum: [ 1, 2 ]
+
+  reg:
+    maxItems: 1
+
+  ranges: true
+
+required:
+  - compatible
+  - '#address-cells'
+  - '#size-cells'
+  - reg
+  - ranges
+
+additionalProperties:
+  type: object
+
+examples:
+  - |
+    bus@30000000 {
+        compatible = "fsl,spba-bus", "simple-bus";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0x30000000 0x100000>;
+        ranges;
+    };
Signature · 1 line
2.25.1
author
#1 lore raw
Quoted 4 lines · Adam Ford

Add binding doc for fsl,spba-bus.

Rob,

Sorry to be a pest. I have a series for the i.MX8M Nano that's waiting on this. Have you had time to review my latest attempt?

adam

Quoted 94 lines

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

V4: Remove an accidental makefile change
Move type:object under additional properties

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Documentation/devicetree/bindings/bus/fsl,spba-bus.yaml new file +68 -1
new file mode 100644
index 000000000000..e9f77ecae3d3
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/bus/fsl,spba-bus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Shared Peripherals Bus Interface
+
+maintainers:
+  - Shawn Guo <[email protected]>
+
+description: |
+  A simple bus enabling access to shared peripherals.
+
+  The "spba-bus" follows the "simple-bus" set of properties, as
+  specified in the Devicetree Specification.  It is an extension of
+  "simple-bus" because the SDMA controller uses this compatible flag to
+  determine which peripherals are available to it and the range over which
+  the SDMA can access.  There are no special clocks for the bus, because
+  the SDMA controller itself has its interrupt, and clock assignments.
+
+select:
+  properties:
+    compatible:
+      contains:
+        const: fsl,spba-bus
+  required:
+    - compatible
+
+properties:
+  $nodename:
+    pattern: "^bus(@[0-9a-f]+)?$"
+
+  compatible:
+    items:
+      - const: fsl,spba-bus
+      - const: simple-bus
+
+  '#address-cells':
+    enum: [ 1, 2 ]
+
+  '#size-cells':
+    enum: [ 1, 2 ]
+
+  reg:
+    maxItems: 1
+
+  ranges: true
+
+required:
+  - compatible
+  - '#address-cells'
+  - '#size-cells'
+  - reg
+  - ranges
+
+additionalProperties:
+  type: object
+
+examples:
+  - |
+    bus@30000000 {
+        compatible = "fsl,spba-bus", "simple-bus";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0x30000000 0x100000>;
+        ranges;
+    };
--

2.25.1

maintainer Applied
#2 lore raw
In reply to Adam Ford
Quoted 12 lines · Adam Ford

Add binding doc for fsl,spba-bus.

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

Quoted 8 lines

V4: Remove an accidental makefile change
Move type:object under additional properties

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Applied, thanks!

author
#3 lore raw
Quoted 17 lines · Rob Herring
Quoted 15 lines · Adam Ford

Add binding doc for fsl,spba-bus.

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

V4: Remove an accidental makefile change
Move type:object under additional properties

Quoted 7 lines
Quoted 5 lines

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Applied, thanks!

Rob,

I am not seeing this anywhere. Can you tell me where this was applied? It's not appearing in Linux-next

adam

author
#4 lore raw
Quoted 25 lines · Adam Ford
Quoted 23 lines · Rob Herring
Quoted 20 lines · Adam Ford

Add binding doc for fsl,spba-bus.

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

V4: Remove an accidental makefile change
Move type:object under additional properties

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Quoted 6 lines
Quoted 1 line

Applied, thanks!

Rob,

I am not seeing this anywhere. Can you tell me where this was applied? It's not appearing in Linux-next

Rob,

Patchwork shows this has been accepted [1], however I don't see that it's still applied.

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

Can you apply it? It looks like building the device tree is throwing messages because this is missing.

adam

Quoted 2 lines

adam

author
#5 lore raw
Quoted 36 lines · Adam Ford
Quoted 25 lines · Adam Ford
Quoted 23 lines · Rob Herring
Quoted 20 lines · Adam Ford

Add binding doc for fsl,spba-bus.

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

V4: Remove an accidental makefile change
Move type:object under additional properties

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Quoted 6 lines
Quoted 1 line

Applied, thanks!

Rob,

I am not seeing this anywhere. Can you tell me where this was applied? It's not appearing in Linux-next

Rob,

Quoted 9 lines

Patchwork shows this has been accepted [1], however I don't see that it's still applied.

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

Can you apply it? It looks like building the device tree is throwing messages because this is missing.

Shawn,

Since you're the maintainer for the IMX stuff, can I update the MAINTAINERS file to add this yaml file under the IMX section? When building device trees, it throws a bunch of splat because this patch was never applied, and checkpatch is showing it wants a maintainer.

Quoted 3 lines

adam

Quoted 2 lines

adam

#6 lore raw
Quoted 47 lines · Adam Ford
Quoted 36 lines · Adam Ford
Quoted 25 lines · Adam Ford
Quoted 23 lines · Rob Herring
Quoted 20 lines · Adam Ford

Add binding doc for fsl,spba-bus.

---
make dt_binding_check -j8 |grep spba

  DTEX    Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dts
  DTC     Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/bus/fsl,spba-bus.example.dt.yaml

V5: Rebase on 5.10-rc2 to be able to check yaml
Add Reg entry

V4: Remove an accidental makefile change
Move type:object under additional properties

V3: Rebase sample from aips-bus example
Split off from series adding i.MX8M Nano functions to reduce noise

V2: Attempted to update yaml from feedback

Quoted 6 lines
Quoted 1 line

Applied, thanks!

Rob,

I am not seeing this anywhere. Can you tell me where this was applied? It's not appearing in Linux-next

Rob,

Quoted 9 lines

Patchwork shows this has been accepted [1], however I don't see that it's still applied.

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]/

Can you apply it? It looks like building the device tree is throwing messages because this is missing.

Quoted 6 lines

Shawn,

Since you're the maintainer for the IMX stuff, can I update the MAINTAINERS file to add this yaml file under the IMX section? When building device trees, it throws a bunch of splat because this patch was never applied, and checkpatch is showing it wants a maintainer.

checkpatch warning on maintainer shouldn't be a problem. We don't really want to bloat IMX entry in MAINTAINERS.

Shawn