Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4
Subsystems (2)
PATCH 1/1 Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4
The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang.
You can see it at https://godbolt.org/z/6ed1oW
For gcc 4.5.3 pane, line 37: .value 0x4
For clang 10.0.1 pane, line 117: .short 4
Given Documentation/process/changes.rst stating GCC 4.9 is the minimal version, this cc-option is unneeded.
Note
----
CONFIG_DEBUG_INFO_DWARF4 controls the DWARF version only for C files.
As you can see in the top Makefile, -gdwarf-4 is only passed to CFLAGS.
ifdef CONFIG_DEBUG_INFO_DWARF4
DEBUG_CFLAGS += -gdwarf-4
endif
This flag is used when compiling *.c files.
On the other hand, the assembler is always given -gdwarf-2.
KBUILD_AFLAGS += -Wa,-gdwarf-2
Hence, the debug info that comes from *.S files is always DWARF v2. This is simply because GAS supported only -gdwarf-2 for a long time.
Recently, GAS gained the support for --dwarf-[3|4|5] options. [1] And, also we have Clang integrated assembler. So, the debug info for *.S files might be improved if we want.
In my understanding, the current code is intentional, not a bug.
[1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=31bf18645d98b4d3d7357353be840e320649a67d
---
lib/Kconfig.debug | 1 - 1 file changed, 1 deletion(-)
lib/Kconfig.debug +0 -1
@@ -258,7 +258,6 @@ config DEBUG_INFO_SPLIT config DEBUG_INFO_DWARF4 bool "Generate dwarf4 debuginfo" - depends on $(cc-option,-gdwarf-4) help Generate dwarf4 debug info. This requires recent versions of gcc and gdb. It makes the debug information larger.
Signature · 1 line
2.27.0
Quoted 58 lines · Masahiro Yamada
The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang.
You can see it at https://godbolt.org/z/6ed1oW
For gcc 4.5.3 pane, line 37: .value
0x4
For clang 10.0.1 pane, line 117: .short 4Given
Documentation/process/changes.rststating GCC 4.9 is the minimal version, this cc-option is unneeded.Note
----
CONFIG_DEBUG_INFO_DWARF4controls the DWARF version only for C files.As you can see in the top
Makefile, -gdwarf-4 is only passed to CFLAGS.ifdef
CONFIG_DEBUG_INFO_DWARF4
DEBUG_CFLAGS+= -gdwarf-4
endifThis flag is used when compiling *.c files.
On the other hand, the assembler is always given -gdwarf-2.
KBUILD_AFLAGS+= -Wa,-gdwarf-2Hence, the debug info that comes from *.S files is always DWARF v2. This is simply because GAS supported only -gdwarf-2 for a long time.
Recently, GAS gained the support for --dwarf-[3|4|5] options. [1] And, also we have Clang integrated assembler. So, the debug info for *.S files might be improved if we want.
In my understanding, the current code is intentional, not a bug.
[1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=31bf18645d98b4d3d7357353be840e320649a67d
Signed-off-by Masahiro Yamada <[email protected]>---
lib/Kconfig.debug | 1 - 1 file changed, 1 deletion(-)lib/Kconfig.debug +0
-2@@ -258,7 +258,6 @@ config DEBUG_INFO_SPLIT config DEBUG_INFO_DWARF4 bool "Generate dwarf4 debuginfo" - depends on $(cc-option,-gdwarf-4) help Generate dwarf4 debug info. This requires recent versions of gcc and gdb. It makes the debug information larger. --
Quoted 1 line
2.27.
Maybe, this can be squashed into Nick's patch.
Signature · 2 lines
Best Regards Masahiro Yamada
Nick Desaulniers
Reviewed-byQuoted 6 lines · Masahiro Yamada
Quoted 4 lines · Masahiro Yamada
The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang.
You can see it at https://godbolt.org/z/6ed1oW
(this link misses -gdwarf-4 for clang, but I think that's ok)
Quoted 47 lines
Quoted 47 lines
For gcc 4.5.3 pane, line 37: .value
0x4
For clang 10.0.1 pane, line 117: .short 4Given
Documentation/process/changes.rststating GCC 4.9 is the minimal version, this cc-option is unneeded.Note
----
CONFIG_DEBUG_INFO_DWARF4controls the DWARF version only for C files.As you can see in the top
Makefile, -gdwarf-4 is only passed to CFLAGS.ifdef
CONFIG_DEBUG_INFO_DWARF4
DEBUG_CFLAGS+= -gdwarf-4
endifThis flag is used when compiling *.c files.
On the other hand, the assembler is always given -gdwarf-2.
KBUILD_AFLAGS+= -Wa,-gdwarf-2Hence, the debug info that comes from *.S files is always DWARF v2. This is simply because GAS supported only -gdwarf-2 for a long time.
Recently, GAS gained the support for --dwarf-[3|4|5] options. [1] And, also we have Clang integrated assembler. So, the debug info for *.S files might be improved if we want.
In my understanding, the current code is intentional, not a bug.
[1] https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=31bf18645d98b4d3d7357353be840e320649a67d
Signed-off-by Masahiro Yamada <[email protected]>---
lib/Kconfig.debug | 1 - 1 file changed, 1 deletion(-)lib/Kconfig.debug +0
-0@@ -258,7 +258,6 @@ config DEBUG_INFO_SPLIT
Quoted 11 lines
Quoted 8 lines
lib/Kconfig.debug +0
-2config DEBUG_INFO_DWARF4 bool "Generate dwarf4 debuginfo" - depends on $(cc-option,-gdwarf-4) help Generate dwarf4 debug info. This requires recent versions of gcc and gdb. It makes the debug information larger. --2.27.
Maybe, this can be squashed into Nick's patch.
I have no preference.
(I'll reroll this into my DWARFv5 series either way, but when/how you merge this doesn't matter to me)
Signature · 2 lines
Thanks, ~Nick Desaulniers