platform/x86: dell-wmi-sysman: work around for BIOS bug
Subsystems (2)
PATCH 1/1 platform/x86: dell-wmi-sysman: work around for BIOS bug
BIOS sets incorrect value (zero) when SET value passed for integer attribute with + sign. Added workaround to remove + sign before passing input to BIOS
--- drivers/platform/x86/dell-wmi-sysman/int-attributes.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/platform/x86/dell-wmi-sysman/int-attributes.c +7 -1
@@ -39,7 +39,7 @@ static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *a* @instance_id: The instance on which input is validated * @buf: Input value */ -static int validate_integer_input (int instance_id,const char *buf) +static int validate_integer_input (int instance_id,char *buf) {int in_val;int ret;
@@ -51,6 +51,12 @@ static int validate_integer_input(int instance_id, const char *buf) in_val > wmi_priv.integer_data[instance_id].max_value) return -EINVAL; +/* workaround for BIOS error. +* validate input to avoid setting 0 when integer input passed with + sign +*/ +if (*buf =='+' ) +memmove (buf, (buf +1 ),strlen (buf)); +return ret; }
Signature · 1 line
2.25.1
Hi,
Quoted 26 lines · Divya Bharathi
BIOS sets incorrect value (zero) when SET value passed for integer attribute with + sign. Added workaround to remove + sign before passing input to BIOS
Co-developed-by Mario Limonciello <[email protected]>Signed-off-by Mario Limonciello <[email protected]>Co-developed-by Prasanth KSR <[email protected]>Signed-off-by Prasanth KSR <[email protected]>Signed-off-by Divya Bharathi <[email protected]>--- drivers/platform/x86/dell-wmi-sysman/int-attributes.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)drivers/platform/x86/dell-wmi-sysman/int-attributes.c +1
-1@@ -39,7 +39,7 @@ static ssize_t current_value_show(struct kobject *kobj, struct kobj_attribute *a* @instance_id: The instance on which input is validated * @buf: Input value */ -static int validate_integer_input (int instance_id,const char *buf) +static int validate_integer_input (int instance_id,char *buf) {int in_val;int ret;
drivers/platform/x86/dell-wmi-sysman/int-attributes.c static int validate_integer_input(int instance_id, const char *buf) · line 58
Quoted 8 lines
drivers/platform/x86/dell-wmi-sysman/int-attributes.c +5
-0@@ -51,6 +51,12 @@ static int validate_integer_input(int instance_id, const char *buf) in_val > wmi_priv.integer_data[instance_id].max_value)return -EINVAL ; +/* workaround for BIOS error. +* validate input to avoid setting 0 when integer input passed with + sign +*/ +if (*buf =='+' ) +memmove (buf, (buf +1 ),strlen (buf));
Can you please use "strlen(buf + 1) + 1" as last argument to the memmove?
I know the effect is the same but that makes it much clearer that you are also moving the terminating 0 (which at first I thought you were not).
Otherwise this looks good to me.
Regards,
Hans