Skip to contentSkip to conversation

drivers: acpi: add opt-out of apple-specific property parsing

PATCH In review Enrico Weigelt, metux IT consult 3 participants 3 messages Dec 2, 2020 – Dec 3, 2020 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drivers: acpi: add opt-out of apple-specific property parsing

Most x86 machines aren't Apple machines, especially VMs. Therefore allow opt-out, making the kernel a few KBs smaller, eg. for embedded or high-density VMs.

v2: fixed spelling

---
 drivers/acpi/Kconfig    | 9 +++++++++
 drivers/acpi/Makefile   | 2 +-
 drivers/acpi/internal.h | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)
drivers/acpi/Kconfig +9 -0
index edf1558c1105..fc37a9a5c2a8 100644
@@ -79,6 +79,15 @@ config ACPI_DEBUGGER_USER
 
 endif
 
+config ACPI_APPLE
+	bool "Apple ACPI properties support"
+	default y if X86
+	help
+	  Extraction of apple specific ACPI properties.
+
+	  Say N if you're sure the kernel won't be used on an Apple machine
+	  and wanna save a few kb of memory. (embedded or high-density VMs)
+
 config ACPI_SPCR_TABLE
 	bool "ACPI Serial Port Console Redirection Support"
 	default y if X86
drivers/acpi/Makefile +1 -1
index 44e412506317..ed1f4405c90a 100644
@@ -52,7 +52,7 @@ acpi-y				+= evged.o
 acpi-y				+= sysfs.o
 acpi-y				+= property.o
 acpi-$(CONFIG_X86)		+= acpi_cmos_rtc.o
-acpi-$(CONFIG_X86)		+= x86/apple.o
+acpi-$(CONFIG_ACPI_APPLE)	+= x86/apple.o
 acpi-$(CONFIG_X86)		+= x86/utils.o
 acpi-$(CONFIG_DEBUG_FS)		+= debugfs.o
 acpi-y				+= acpi_lpat.o
drivers/acpi/internal.h +1 -1
index e3638bafb941..fa1b6ef7829a 100644
@@ -239,7 +239,7 @@ static inline void suspend_nvs_restore(void) {}
 void acpi_init_properties(struct acpi_device *adev);
 void acpi_free_properties(struct acpi_device *adev);
 
-#ifdef CONFIG_X86
+#ifdef CONFIG_ACPI_APPLE
 void acpi_extract_apple_properties(struct acpi_device *adev);
 #else
 static inline void acpi_extract_apple_properties(struct acpi_device *adev) {}
Signature · 1 line
2.11.0
#1 lore raw

Hi--

Quoted 18 lines · metux IT consult

Most x86 machines aren't Apple machines, especially VMs. Therefore allow opt-out, making the kernel a few KBs smaller, eg. for embedded or high-density VMs.

v2: fixed spelling

---
 drivers/acpi/Kconfig    | 9 +++++++++
 drivers/acpi/Makefile   | 2 +-
 drivers/acpi/internal.h | 2 +-
 3 files changed, 11 insertions(+), 2 deletions(-)
drivers/acpi/Kconfig +0 -0
index edf1558c1105..fc37a9a5c2a8 100644

drivers/acpi/Kconfig config ACPI_DEBUGGER_USER · line 86

Quoted 8 lines
drivers/acpi/Kconfig +5 -0
@@ -79,6 +79,15 @@ config ACPI_DEBUGGER_USER
 
 endif
 
+config ACPI_APPLE
+	bool "Apple ACPI properties support"
+	default y if X86
+	help
+	  Extraction of apple specific ACPI properties.

Apple-specific

drivers/acpi/Kconfig config ACPI_DEBUGGER_USER · line 89

Quoted 3 lines
drivers/acpi/Kconfig +3 -0
+
+	  Say N if you're sure the kernel won't be used on an Apple machine
+	  and wanna save a few kb of memory. (embedded or high-density VMs)

want to

and kb == kilobits. Is that what you mean here?

Quoted 4 lines
drivers/acpi/Kconfig +1 -0
+
 config ACPI_SPCR_TABLE
 	bool "ACPI Serial Port Console Redirection Support"
 	default y if X86
Signature · 1 line
~Randy
#2 lore raw

On 02.12.20 18:51, Randy Dunlap wrote:

Hi,

Quoted 6 lines

drivers/acpi/Kconfig config ACPI_DEBUGGER_USER

Quoted 5 lines
drivers/acpi/Kconfig +5 -0
+config ACPI_APPLE
+	bool "Apple ACPI properties support"
+	default y if X86
+	help
+	  Extraction of apple specific ACPI properties.>

Apple-specific

ok, thanks.

Quoted 7 lines

drivers/acpi/Kconfig config ACPI_DEBUGGER_USER · line 89

Quoted 3 lines
drivers/acpi/Kconfig +3 -0
+
+	  Say N if you're sure the kernel won't be used on an Apple machine
+	  and wanna save a few kb of memory. (embedded or high-density VMs)

want to

and kb == kilobits. Is that what you mean here?

around 6.6kb stripped, 74kb unstripped.

--mtx

Signature · 8 lines
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
[email protected] -- +49-151-27565287