Skip to contentSkip to conversation

arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing

PATCH In review Adam Ford 2 participants 4 messages Dec 2, 2020 – Jan 5, 2021

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing

The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.

Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +3 -1
index 6de86a4f0ec4..90fd15e95798 100644
@@ -217,8 +217,10 @@
 &usdhc1 {
 	#address-cells = <1>;
 	#size-cells = <0>;
-	pinctrl-names = "default";
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
 	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
 	bus-width = <4>;
 	non-removable;
 	cap-power-off-card;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Adam Ford

The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.

Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

This looks more like an improvement than bug fix.

Shawn

Quoted 21 lines
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +3 -1
index 6de86a4f0ec4..90fd15e95798 100644
@@ -217,8 +217,10 @@
 &usdhc1 {
 	#address-cells = <1>;
 	#size-cells = <0>;
-	pinctrl-names = "default";
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
 	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
 	bus-width = <4>;
 	non-removable;
 	cap-power-off-card;
Signature · 1 line
2.17.1
author
#2 lore raw
Quoted 10 lines · Shawn Guo
Quoted 6 lines · Adam Ford

The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.

Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

This looks more like an improvement than bug fix.

Do you want me to resubmit without the fixes tag?

adam

Quoted 24 lines

Shawn

Quoted 21 lines
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +3 -2
index 6de86a4f0ec4..90fd15e95798 100644
@@ -217,8 +217,10 @@
 &usdhc1 {
      #address-cells = <1>;
      #size-cells = <0>;
-     pinctrl-names = "default";
+     pinctrl-names = "default", "state_100mhz", "state_200mhz";
      pinctrl-0 = <&pinctrl_usdhc1>;
+     pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+     pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
      bus-width = <4>;
      non-removable;
      cap-power-off-card;
--

2.17.1

#3 lore raw
Quoted 8 lines · Adam Ford
Quoted 7 lines · Shawn Guo
Quoted 5 lines · Adam Ford

The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

This looks more like an improvement than bug fix.

Do you want me to resubmit without the fixes tag?

Yes, please. Also, update patch subject like below maybe.

arm64: dts: imx8mm-beacon: add more pinctrl states for usdhc1

Shawn