arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing
Subsystems (2)
PATCH 1/1 arm64: dts: imx8mm-beacon: Fix WiFi Pinmuxing
The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +3 -1
@@ -217,8 +217,10 @@ &usdhc1 { #address-cells = <1>; #size-cells = <0>; - pinctrl-names = "default"; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; pinctrl-0 = <&pinctrl_usdhc1>; + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; bus-width = <4>; non-removable; cap-power-off-card;
Signature · 1 line
2.17.1
Quoted 6 lines · Adam Ford
The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
This looks more like an improvement than bug fix.
Shawn
Quoted 21 lines
Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +3
-1@@ -217,8 +217,10 @@ &usdhc1 { #address-cells = <1>; #size-cells = <0>; - pinctrl-names = "default"; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; pinctrl-0 = <&pinctrl_usdhc1>; + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; bus-width = <4>; non-removable; cap-power-off-card;Signature · 1 line
2.17.1
Quoted 10 lines · Shawn Guo
Quoted 6 lines · Adam Ford
The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")This looks more like an improvement than bug fix.
Do you want me to resubmit without the fixes tag?
adam
Quoted 24 lines
Shawn
Quoted 21 lines
Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi +3
-2@@ -217,8 +217,10 @@ &usdhc1 { #address-cells = <1>; #size-cells = <0>; - pinctrl-names = "default"; + pinctrl-names = "default", "state_100mhz", "state_200mhz"; pinctrl-0 = <&pinctrl_usdhc1>; + pinctrl-1 = <&pinctrl_usdhc1_100mhz>; + pinctrl-2 = <&pinctrl_usdhc1_200mhz>; bus-width = <4>; non-removable; cap-power-off-card; --2.17.1
Quoted 8 lines · Adam Ford
Quoted 7 lines · Shawn Guo
Quoted 5 lines · Adam Ford
The WiFi chip is capable of communication at SDR104 speeds, and the pinmux was configured to support this, but the sdhc1 controller didn't properly reference the pinmux. Enable 100Mhz and 200MHz pinmux as was originally intended.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Fixes 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")This looks more like an improvement than bug fix.
Do you want me to resubmit without the fixes tag?
Yes, please. Also, update patch subject like below maybe.
arm64: dts: imx8mm-beacon: add more pinctrl states for usdhc1
Shawn