x86/sgx: Initialize "ret" in sgx_ioc_enclave_add_pages()
Jarkko Sakkinen
maintainerPATCH 1/1 x86/sgx: Initialize "ret" in sgx_ioc_enclave_add_pages()
Initialize "ret" to zero as otherwise a zero length address range will leave it uninitialized.
--- arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/sgx/ioctl.c +1 -1
@@ -415,7 +415,7 @@ static long sgx_ioc_enclave_add_pages(struct sgx_encl *encl, void __user *arg)struct sgx_enclave_add_pages add_arg;struct sgx_secinfo secinfo;unsigned long c; -int ret; +int ret =0 ;if (!test_bit (SGX_ENCL_CREATED , &encl->flags) ||test_bit (SGX_ENCL_INITIALIZED , &encl->flags))
Signature · 1 line
2.27.0
Borislav Petkov
maintainerQuoted 2 lines · Jarkko Sakkinen
Initialize "ret" to zero as otherwise a zero length address range will leave it uninitialized.
That length is:
* @length: length of the data (multiple of the page size)
I think we wanna fail this even earlier when it wants to add data of length 0 because that sounds nonsensical to me. Or is there some use case for zero-length data?
Btw, pls CC lkml on patch submissions.
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteQuoted 6 lines · Borislav Petkov
Quoted 2 lines · Jarkko Sakkinen
Initialize "ret" to zero as otherwise a zero length address range will leave it uninitialized.
That length is:
Quoted 7 lines
* @length: length of the data (multiple of the page size)
I think we wanna fail this even earlier when it wants to add data of length 0 because that sounds nonsensical to me. Or is there some use case for zero-length data?
Btw, pls CC lkml on patch submissions.
Yeah, makes sense to fail right after copying the parameter struct with -EINVAL.
Quoted 8 lines
Thx.
Signature · 4 lines
Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
/Jarkko