Skip to contentSkip to conversation

usertools: show hugepages on POWER systems

PATCH Superseded David Christensen 3 participants 4 messages Dec 2, 2020 – Feb 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usertools: show hugepages on POWER systems

The IBM PowerNV systems include NUMA nodes that don't have associated CPUs or hugepage memory. Here is an example on an IBM AC922 system:

$ lscpu
...
NUMA node0 CPU(s):   0-63
NUMA node8 CPU(s):   64-127
NUMA node252 CPU(s):
...
$ numastat -m
...
                          Node 0          Node 8        Node 252
                 --------------- --------------- ---------------
MemTotal               126763.19       130785.06            0.00
MemFree                119513.38       125294.44            0.00
MemUsed                  7249.81         5490.62            0.00
...
HugePages_Total             4.00         1734.00            0.00
HugePages_Free              0.00            4.00            0.00
HugePages_Surp              4.00         1730.00            0.00
...

Modify dpdk-hugepages.py to test for the ../hugepages directory before attempting to parse the hugepage entries.

---
 usertools/dpdk-hugepages.py | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
usertools/dpdk-hugepages.py +8 -7
index 1be100ca3..89945f187 100755
@@ -70,13 +70,14 @@ def show_numa_pages():
     for numa_path in glob.glob('/sys/devices/system/node/node*'):
         node = numa_path[29:]  # slice after /sys/devices/system/node/node
         path = numa_path + '/hugepages'
-        for hdir in os.listdir(path):
-            pages = get_hugepages(path + '/' + hdir)
-            if pages > 0:
-                kb = int(hdir[10:-2])  # slice out of hugepages-NNNkB
-                print('{:<4} {:<5} {:<6} {}'.format(node, pages,
-                                                    fmt_memsize(kb),
-                                                    fmt_memsize(pages * kb)))
+        if os.path.exists(path):
+            for hdir in os.listdir(path):
+                pages = get_hugepages(path + '/' + hdir)
+                if pages > 0:
+                    kb = int(hdir[10:-2])  # slice out of hugepages-NNNkB
+                    print('{:<4} {:<5} {:<6} {}'.format(node, pages,
+                                                        fmt_memsize(kb),
+                                                        fmt_memsize(pages * kb)))
 
 
 def show_non_numa_pages():
Signature · 1 line
2.27.0
#1 lore raw
Quoted 23 lines · On Wed, 2 Dec 2020 10:19:59 -0800 David Christensen <[email protected]>…

The IBM PowerNV systems include NUMA nodes that don't have associated CPUs or hugepage memory. Here is an example on an IBM AC922 system:

$ lscpu
...
NUMA node0 CPU(s):   0-63
NUMA node8 CPU(s):   64-127
NUMA node252 CPU(s):
...
$ numastat -m
...
                          Node 0          Node 8        Node 252
                 --------------- --------------- ---------------
MemTotal               126763.19       130785.06            0.00
MemFree                119513.38       125294.44            0.00
MemUsed                  7249.81         5490.62            0.00
...
HugePages_Total             4.00         1734.00            0.00
HugePages_Free              0.00            4.00            0.00
HugePages_Surp              4.00         1730.00            0.00
...
Quoted 4 lines

Modify dpdk-hugepages.py to test for the ../hugepages directory before attempting to parse the hugepage entries.

Ok, but using continue avoids having to do so much indentation.

if not os.path.exists(path):
continue

#2 lore raw

PATCH v2 1/1 usertools: show hugepages on POWER systems

In reply to David Christensen

The IBM PowerNV systems include NUMA nodes that don't have associated CPUs or hugepage memory. Here is an example on an IBM AC922 system:

$ lscpu
...
NUMA node0 CPU(s):   0-63
NUMA node8 CPU(s):   64-127
NUMA node252 CPU(s):
...
$ numastat -m
...
                          Node 0          Node 8        Node 252
                 --------------- --------------- ---------------
MemTotal               126763.19       130785.06            0.00
MemFree                119513.38       125294.44            0.00
MemUsed                  7249.81         5490.62            0.00
...
HugePages_Total             4.00         1734.00            0.00
HugePages_Free              0.00            4.00            0.00
HugePages_Surp              4.00         1730.00            0.00
...

Modify dpdk-hugepages.py to test for the ../hugepages directory before attempting to parse the hugepage entries.

---
v2:
- reduce indentation and use continue to skip non-existent paths

---
 usertools/dpdk-hugepages.py | 2 ++
 1 file changed, 2 insertions(+)
usertools/dpdk-hugepages.py +2 -0
index 1be100ca3..4b6401dc2 100755
@@ -70,6 +70,8 @@ def show_numa_pages():
     for numa_path in glob.glob('/sys/devices/system/node/node*'):
         node = numa_path[29:]  # slice after /sys/devices/system/node/node
         path = numa_path + '/hugepages'
+        if not os.path.exists(path):
+            continue
         for hdir in os.listdir(path):
             pages = get_hugepages(path + '/' + hdir)
             if pages > 0:
Signature · 1 line
2.27.0
#3 lore raw

02/12/2020 21:57, David Christensen:

Quoted 23 lines

The IBM PowerNV systems include NUMA nodes that don't have associated CPUs or hugepage memory. Here is an example on an IBM AC922 system:

$ lscpu
...
NUMA node0 CPU(s):   0-63
NUMA node8 CPU(s):   64-127
NUMA node252 CPU(s):
...
$ numastat -m
...
                          Node 0          Node 8        Node 252
                 --------------- --------------- ---------------
MemTotal               126763.19       130785.06            0.00
MemFree                119513.38       125294.44            0.00
MemUsed                  7249.81         5490.62            0.00
...
HugePages_Total             4.00         1734.00            0.00
HugePages_Free              0.00            4.00            0.00
HugePages_Surp              4.00         1730.00            0.00
...
Quoted 4 lines

Modify dpdk-hugepages.py to test for the ../hugepages directory before attempting to parse the hugepage entries.

Applied, thanks