Skip to contentSkip to conversation

add ath11k MODULE_FIRMWARE macros

PATCH In review Devin Bayer 2 participants 5 messages Dec 2, 2020 – Dec 8, 2020 Qualcomm Atheros ATH11K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add ath11k MODULE_FIRMWARE macros

Hello,

I am trying to get the ath11k driver to work with VyOS and during the build it tries to discover the firmware blobs which drivers require.

This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE macro. This patch fixes that.

Thanks,
Devin

---
 drivers/net/wireless/ath/ath11k/core.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/wireless/ath/ath11k/core.c +6 -0
index af59c23fea56..2add42ce729b 100644
@@ -991,3 +991,9 @@ EXPORT_SYMBOL(ath11k_core_resume);
 
 MODULE_DESCRIPTION("Core module for Qualcomm Atheros 802.11ax wireless LAN cards.");
 MODULE_LICENSE("Dual BSD/GPL");
+
+/* QCA639x 2.0 firmware files */
+MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_BOARD_API2_FILE);
+MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_AMSS_FILE);
+MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_M3_FILE);
+
Signature · 7 lines
2.25.1


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 9 lines · Devin Bayer

I am trying to get the ath11k driver to work with VyOS and during the build it tries to discover the firmware blobs which drivers require.

This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE macro. This patch fixes that.

[[email protected]: cleanup commit log, move to pci.c]

I cleaned up the commit log and moved the macros to pci.c, please check my changes:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=9fc43fa2b621fa84a312d9eba538bf75c9049f3b

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20201202182705.dhkml4nb4rf2vwav@orac/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#2 lore raw
In reply to Devin Bayer
Quoted 9 lines · Devin Bayer

I am trying to get the ath11k driver to work with VyOS and during the build it tries to discover the firmware blobs which drivers require.

This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE macro. This patch fixes that.

[[email protected]: cleanup commit log, move to pci.c]

I cleaned up the commit log and moved the macros to pci.c, please check my changes:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=9fc43fa2b621fa84a312d9eba538bf75c9049f3b

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20201202182705.dhkml4nb4rf2vwav@orac/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#3 lore raw
In reply to Devin Bayer
Quoted 9 lines · Devin Bayer

I am trying to get the ath11k driver to work with VyOS and during the build it tries to discover the firmware blobs which drivers require.

This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE macro. This patch fixes that.

[[email protected]: cleanup commit log, move to pci.c]

Patch applied to ath-next branch of ath.git, thanks.

3dbd7fe78c42 ath11k: pci: add MODULE_FIRMWARE macros

Signature · 9 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20201202182705.dhkml4nb4rf2vwav@orac/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#4 lore raw
In reply to Devin Bayer
Quoted 9 lines · Devin Bayer

I am trying to get the ath11k driver to work with VyOS and during the build it tries to discover the firmware blobs which drivers require.

This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE macro. This patch fixes that.

[[email protected]: cleanup commit log, move to pci.c]

Patch applied to ath-next branch of ath.git, thanks.

3dbd7fe78c42 ath11k: pci: add MODULE_FIRMWARE macros

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/20201202182705.dhkml4nb4rf2vwav@orac/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches