mnl: reply netlink error message might be larger than MNL_SOCKET_BUFFER_SIZE
Pablo Neira Ayuso
maintainerPATCH 1/1 mnl: reply netlink error message might be larger than MNL_SOCKET_BUFFER_SIZE
Netlink attribute maximum size is 65536 bytes (given nla_len is 16-bits). NFTA_SET_ELEM_LIST_ELEMENTS stores as many set elements as possible that can fit into this netlink attribute.
Netlink messages with NLMSG_ERROR type originating from the kernel contain the original netlink message as payload, they might be larger than 65536 bytes.
Add NFT_MNL_ACK_MAXSIZE which estimates the maximum Netlink header coming as (error) reply from the kernel.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/mnl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
src/mnl.c +4 -1
@@ -359,6 +359,9 @@ static int mnl_batch_extack_cb(const struct nlmsghdr *nlh, void *data) }#define NFT_MNL_ECHO_RCVBUFF_DEFAULT (MNL_SOCKET_BUFFER_SIZE * 1024) +#define NFT_MNL_ACK_MAXSIZE ((sizeof(struct nlmsghdr) + \ + sizeof(struct nfgenmsg) + (1 << 16)) + \ + MNL_SOCKET_BUFFER_SIZE)int mnl_batch_talk (struct netlink_ctx *ctx,struct list_head *err_list,uint32_t num_cmds)
@@ -366,7 +369,7 @@ int mnl_batch_talk(struct netlink_ctx *ctx, struct list_head *err_list,struct mnl_socket *nl = ctx->nft->nf_sock;int ret, fd =mnl_socket_get_fd (nl), portid =mnl_socket_get_portid (nl);uint32_t iov_len =nftnl_batch_iovec_len (ctx->batch); -char rcv_buf[MNL_SOCKET_BUFFER_SIZE ]; +char rcv_buf[NFT_MNL_ACK_MAXSIZE ];const struct sockaddr_nl snl = { .nl_family =AF_NETLINK };
Signature · 1 line
2.20.1