remoteproc/mediatek: unprepare clk if scp_before_load fails
Subsystems (2)
PATCH v2 1/1 remoteproc/mediatek: unprepare clk if scp_before_load fails
Fixes the error handling to unprepare clk if scp_before_load fails.
---
Changes from v1[1]:
- add "Fixes" tag
- remove an unneeded change
[1]: https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
drivers/remoteproc/mtk_scp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/remoteproc/mtk_scp.c +2 -1
@@ -350,9 +350,10 @@ static int scp_load(struct rproc *rproc, const struct firmware *fw) ret = scp->data->scp_before_load (scp);if (ret <0 ) -return ret; + goto leave; ret =scp_elf_load_segments (rproc, fw); +leave:clk_disable_unprepare (scp->clk);return ret;
Signature · 7 lines
2.29.2.454.gaff20da3a2-goog _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Mathieu Poirier
maintainerQuoted 3 lines · Tzung-Bi Shih
Fixes the error handling to unprepare clk if
scp_before_loadfails.Fixes fd0b6c1ff85a4 ("remoteproc/mediatek: Add support for mt8192 SCP")
https://elixir.bootlin.com/linux/v5.10-rc6/source/Documentation/process/submitting-patches.rst#L122
Quoted 30 lines
Signed-off-by Tzung-Bi Shih <[email protected]>---
Changes from v1[1]:
- add "Fixes" tag
- remove an unneeded change[1]: https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
drivers/remoteproc/mtk_scp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/remoteproc/mtk_scp.c +2
-1@@ -350,9 +350,10 @@ static int scp_load(struct rproc *rproc, const struct firmware *fw) ret = scp->data->scp_before_load (scp);if (ret <0 ) -return ret; + goto leave; ret =scp_elf_load_segments (rproc, fw); +leave:clk_disable_unprepare (scp->clk);return ret;Signature · 1 line
2.29.2.454.gaff20da3a2-goog
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 7 lines · Mathieu Poirier
Quoted 3 lines · Tzung-Bi Shih
Fixes the error handling to unprepare clk if
scp_before_loadfails.Fixes fd0b6c1ff85a4 ("remoteproc/mediatek: Add support for mt8192 SCP")https://elixir.bootlin.com/linux/v5.10-rc6/source/Documentation/process/submitting-patches.rst#L122
Fixed in v3[1], not sure what happened when copying the hash.
[1]: https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek